New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690535 link

Starred by 2 users
Status: Fixed
Owner:
█ oetu...@nvidia.com
Email to this user bounced
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Write GPU integration test config to output JSON

Reported by oetu...@nvidia.com, Feb 9 2017 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
(1) Manually run GPU integration tests with a bunch of different configurations to test them out, using content/test/gpu/run_gpu_integration_test.py. Come back to the results later.

What is the expected result?
Easy to see from output file what configuration was used to generate it.

What happens instead?
Forget which config was used. Chaos ensues. Have to redo some test runs.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a48c5ca1a439dc23331804504df789e5b59a93be

commit a48c5ca1a439dc23331804504df789e5b59a93be
Author: oetuaho <oetuaho@nvidia.com>
Date: Thu Feb 16 19:39:36 2017

Write GPU integration test arguments to runner output JSON

Having clear idea what configuration generated a particular results
file makes it easier to keep track of things when manually testing
different browser configurations with the test runner.

BUG= 690535 
TEST=run_gpu_integration_test
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2686123002
Cr-Commit-Position: refs/heads/master@{#451055}

[modify] https://crrev.com/a48c5ca1a439dc23331804504df789e5b59a93be/content/test/gpu/run_gpu_integration_test.py
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8db424fb7191b2be7b58b89427b9b258d057d97b

commit 8db424fb7191b2be7b58b89427b9b258d057d97b
Author: oetuaho <oetuaho@nvidia.com>
Date: Thu Mar 16 02:26:10 2017

Fix writing GPU test runner arguments to results file

The command line arguments for the script changed when it was ported
to use typ. Clean up code that was written for the old runner and fix
writing test run arguments to the results json file. An extra argument
is now required to toggle writing the test run arguments.

BUG= 690535 
TEST=run_gpu_integration_test
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2735373002
Cr-Commit-Position: refs/heads/master@{#457320}

[modify] https://crrev.com/8db424fb7191b2be7b58b89427b9b258d057d97b/content/test/gpu/run_gpu_integration_test.py

Comment 3 by oetu...@nvidia.com, May 30 2017

Status: Fixed (was: Started)
►

Sign in to add a comment