I feel like isherman@ will know how to triage this, after our in-car discussion today :)

The Firefox database format has likely changed again, and the importer code will need to be updated accordingly.

Issue 548569 has been merged into this issue.

Thanks for the report. I am able to reproduce the issue in latest chrome stable - 56.0.2924.87 on windows 10. Only partial data is being imported, imported the password& autofill but not the search engines and bookmarks.

We will perform a bisect and update when its broken.

Hi Ligim and all,

thank you for working on this issue. Unfortunately I can't reconstruct how Chrome at least imported the passwords, as you describe. On my computer, on which I just reinstalled Firefox and Chrome this week, including new profiles), Chrome 56 imports nothing - at least from current Firefox 51.

Out of curiosity I tried how Chrome would import data from an older Firefox. I chose 14 months old Firefox 43: Turns out, it DOES import bookmarks and some of the search engines (still the same behavior that I described in detail in filling 548569), but no passwords. Since other Chromium browsers are well able to import passwords from current Firefox (as I described above), it looks to me that at least the password import failure is an issue about Chrome rather than Firefox.

Able to reproduce the issue on Windows 10, Mac 10.12.2 and Ubuntu 14.04 using reported version #56.0.2924.87 but the same is not reproducible in the latest canary #58.0.3010.0.

Reverse Bisect Information:
=====================
good build: 57.0.2943.0	Revision(436483)

bad build:  57.0.2942.0	Revision(436203)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/a497ed338b3e66366b2d3a548d02d682978c5049..8a1ed3436f171ff0666d15d996ee033928c7dbf0

From the above change log possible CL that fixed this issue:

Review-Url: https://codereview.chromium.org/2296633002

kszatan@ - Could you please check and merge the fix to M57 if it is a valid candidate.

Thanks...!!

Adding release block stable as it is a recent regression.

A friendly reminder that M57 Stable is launch is coming VERY soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Hi! My changes fixed import of bookmarks but passwords are a different matter entirely. I had plans to fix this but didn't have time so far.

@ kszatan: Gentle ping, any update on this as we are approaching M57 stable release. issue is tagged with M57 and has a stable blocker. Kindly look into it and please provide an update on the same.

Thanks.!

@ranjitkan: Please read the previous comment.

Looks like the Firefox DB format had indeed changed.
Tried on Mac with Firefox 55.0.2 and it fails to read the bookmarks table:

[29890:21763:0823/160947.606066:FATAL:connection.cc(1517)] SQL compile error no such column: h.favicon_id
0   libbase.dylib                       0x0000000100664ace base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x0000000100664b8d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x0000000100662e3c base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x0000000100701fef logging::LogMessage::~LogMessage() + 479
4   libbase.dylib                       0x00000001006ff955 logging::LogMessage::~LogMessage() + 21
5   libsql.dylib                        0x000000012e51c42a sql::Connection::GetStatementImpl(sql::Connection*, char const*) const + 794
6   libsql.dylib                        0x000000012e515ae7 sql::Connection::GetUniqueStatement(char const*) + 39
7   libchrome_dll.dylib                 0x000000010d13b1db FirefoxImporter::GetWholeBookmarkFolder(sql::Connection*, std::__1::vector<std::__1::unique_ptr<FirefoxImporter::BookmarkItem, std::__1::default_delete<FirefoxImporter::BookmarkItem> >, std::__1::allocator<std::__1::unique_ptr<FirefoxImporter::BookmarkItem, std::__1::default_delete<FirefoxImporter::BookmarkItem> > > >*, unsigned long, bool*) + 251
8   libchrome_dll.dylib                 0x000000010d135b65 FirefoxImporter::ImportBookmarks() + 1461
9   libchrome_dll.dylib                 0x000000010d134905 FirefoxImporter::StartImport(importer::SourceProfile const&, unsigned short, ImporterBridge*) + 501
10  libchrome_dll.dylib                 0x000000010d166748 void base::internal::FunctorTraits<void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), void>::Invoke<scoped_refptr<Importer>, importer::SourceProfile, unsigned short, ExternalProcessImporterBridge*>(void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), scoped_refptr<Importer>&&, importer::SourceProfile&&, unsigned short&&, ExternalProcessImporterBridge*&&) + 184
11  libchrome_dll.dylib                 0x000000010d1665ca void base::internal::InvokeHelper<false, void>::MakeItSo<void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), scoped_refptr<Importer>, importer::SourceProfile, unsigned short, ExternalProcessImporterBridge*>(void (Importer::*&&)(importer::SourceProfile const&, unsigned short, ImporterBridge*), scoped_refptr<Importer>&&, importer::SourceProfile&&, unsigned short&&, ExternalProcessImporterBridge*&&) + 138
12  libchrome_dll.dylib                 0x000000010d16650d void base::internal::Invoker<base::internal::BindState<void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), scoped_refptr<Importer>, importer::SourceProfile, unsigned short, base::internal::RetainedRefWrapper<ExternalProcessImporterBridge> >, void ()>::RunImpl<void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), std::__1::tuple<scoped_refptr<Importer>, importer::SourceProfile, unsigned short, base::internal::RetainedRefWrapper<ExternalProcessImporterBridge> >, 0ul, 1ul, 2ul, 3ul>(void (Importer::*&&)(importer::SourceProfile const&, unsigned short, ImporterBridge*), std::__1::tuple<scoped_refptr<Importer>, importer::SourceProfile, unsigned short, base::internal::RetainedRefWrapper<ExternalProcessImporterBridge> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul>) + 285
13  libchrome_dll.dylib                 0x000000010d166369 base::internal::Invoker<base::internal::BindState<void (Importer::*)(importer::SourceProfile const&, unsigned short, ImporterBridge*), scoped_refptr<Importer>, importer::SourceProfile, unsigned short, base::internal::RetainedRefWrapper<ExternalProcessImporterBridge> >, void ()>::RunOnce(base::internal::BindStateBase*) + 57
14  libbase.dylib                       0x000000010060238f base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() + 95
15  libbase.dylib                       0x00000001006671c0 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1040
16  libbase.dylib                       0x0000000100757a74 base::MessageLoop::RunTask(base::PendingTask*) + 900
17  libbase.dylib                       0x0000000100757fc7 base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 71
18  libbase.dylib                       0x0000000100758e18 base::MessageLoop::DoWork() + 568
19  libbase.dylib                       0x000000010076914f base::MessagePumpCFRunLoopBase::RunWork() + 95
20  libbase.dylib                       0x00000001007690dc ___ZN4base24MessagePumpCFRunLoopBase13RunWorkSourceEPv_block_invoke + 28
21  libbase.dylib                       0x000000010070a71a base::mac::CallWithEHFrame(void () block_pointer) + 10
22  libbase.dylib                       0x00000001007685e5 base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 101
23  CoreFoundation                      0x00007fff9242f321 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
24  CoreFoundation                      0x00007fff9241021d __CFRunLoopDoSources0 + 557
25  CoreFoundation                      0x00007fff9240f716 __CFRunLoopRun + 934
26  CoreFoundation                      0x00007fff9240f114 CFRunLoopRunSpecific + 420
27  libbase.dylib                       0x000000010076974c base::MessagePumpCFRunLoop::DoRun(base::MessagePump::Delegate*) + 76
28  libbase.dylib                       0x0000000100767dce base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 110
29  libbase.dylib                       0x00000001007571fb base::MessageLoop::Run() + 299
30  libbase.dylib                       0x000000010085196e base::RunLoop::Run() + 286
31  libbase.dylib                       0x00000001009535d5 base::Thread::Run(base::RunLoop*) + 405
32  libbase.dylib                       0x000000010095429c base::Thread::ThreadMain() + 2412
33  libbase.dylib                       0x000000010092b6a8 base::(anonymous namespace)::ThreadFunc(void*) + 632
34  libsystem_pthread.dylib             0x00007fffa7da893b _pthread_body + 180
35  libsystem_pthread.dylib             0x00007fffa7da8887 _pthread_body + 0
36  libsystem_pthread.dylib             0x00007fffa7da808d thread_start + 13

[29875:775:0 

 Issue 760536  has been merged into this issue.