New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690516 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit warning/error in test_results_presentation script

Project Member Reported by wnwen@chromium.org, Feb 9 2017

Issue description

git cl presubmit


Pylint (130 files using ['--disable=cyclic-import'] on 40 cores) (2.79s) failed
************* Module test_results_presentation
F: 18, 0: Unable to import 'jinja2' (import-error)

git cl upload

** Presubmit Warnings **
Pylint (130 files using ['--disable=cyclic-import'] on 40 cores) (2.85s) failed
************* Module test_results_presentation
F: 18, 0: Unable to import 'jinja2' (import-error)

 
Status: Started (was: Assigned)
Ah, I wasnt getting this because I have jinja2 installed on my workstation. Fixing
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17b8c4ad2ba2654dbb66cbdc1dd348144192db0e

commit 17b8c4ad2ba2654dbb66cbdc1dd348144192db0e
Author: mikecase <mikecase@chromium.org>
Date: Fri Feb 10 21:24:25 2017

Fix jinja pylint import error in test_results_presentation.

BUG=690516

Review-Url: https://codereview.chromium.org/2689763002
Cr-Commit-Position: refs/heads/master@{#449738}

[modify] https://crrev.com/17b8c4ad2ba2654dbb66cbdc1dd348144192db0e/build/android/pylib/results/presentation/test_results_presentation.py

Comment 4 by wnwen@chromium.org, Feb 13 2017

Thanks Michael!

Sign in to add a comment