Crash in exo::ShellSurface::UpdateShadow when closing window |
|||||||||
Issue descriptionhttps://chromium.googlesource.com/chromium/src/+/ba48072770ed46f3328f09d8147f42c8cf4a1677 started accessing surface_ in UpdateShadow without checking if surface_ is non-null. It can be null during tear down of the ShellSurface. Simply early out when surface_ is null makes the crashes go away.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da082c748163f71334651cc9d7506d18b2e169e9 commit da082c748163f71334651cc9d7506d18b2e169e9 Author: oshima <oshima@chromium.org> Date: Thu Feb 09 21:30:08 2017 Skip UpdateShadow if the surface has already been destroyed BUG= 690515 , 687742 Review-Url: https://codereview.chromium.org/2681233003 Cr-Commit-Position: refs/heads/master@{#449415} [modify] https://crrev.com/da082c748163f71334651cc9d7506d18b2e169e9/components/exo/shell_surface.cc
,
Feb 10 2017
,
Feb 10 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9eac9bcd626246dfab4b350a50ae470b0f7b2dd commit f9eac9bcd626246dfab4b350a50ae470b0f7b2dd Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Feb 13 01:34:22 2017 Skip UpdateShadow if the surface has already been destroyed BUG= 690515 , 687742 Review-Url: https://codereview.chromium.org/2681233003 Cr-Commit-Position: refs/heads/master@{#449415} (cherry picked from commit da082c748163f71334651cc9d7506d18b2e169e9) Review-Url: https://codereview.chromium.org/2690713002 . Cr-Commit-Position: refs/branch-heads/2987@{#470} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/f9eac9bcd626246dfab4b350a50ae470b0f7b2dd/components/exo/shell_surface.cc
,
Feb 13 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by osh...@chromium.org
, Feb 9 2017