New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690514 link

Starred by 2 users
Status: Started
Owner:
█ markusheintz@chromium.org
Last visit 16 days ago
Cc:
jkrcal@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[remote suggestions] Attach fetch time Suggestions and use it for measuring the fetch to view time.

Project Member Reported by markusheintz@chromium.org, Feb 9 2017 
Attach fetch time Suggestions and use it for measuring the fetch to view time.

This allows to mix suggestions from different background fetches while still being able to compute the correct fetch to view time.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05b1e88e39e1f54d14a3cc272be365ef203ea18f

commit 05b1e88e39e1f54d14a3cc272be365ef203ea18f
Author: markusheintz <markusheintz@chromium.org>
Date: Wed Feb 15 14:38:19 2017

[remote suggestions] Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle

Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle and use it for calculating metrics. This allows to mix suggestions from multiples background fetches on the fly while still beeing able to compute currect freshness metrics for each individual snippet.

BUG=690514

Review-Url: https://codereview.chromium.org/2686063003
Cr-Commit-Position: refs/heads/master@{#450692}

[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerViewTest.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/browser/android/ntp/ntp_snippets_bridge.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/suggestions/ContentSuggestionsTestUtils.java
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/content_suggestion.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/content_suggestions_metrics.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/content_suggestions_metrics.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/content_suggestions_metrics_unittest.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/json_request.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/json_request.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/json_request_unittest.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/proto/ntp_snippets.proto
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestion.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestion.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestion_unittest.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestions_fetcher.h
[modify] https://crrev.com/05b1e88e39e1f54d14a3cc272be365ef203ea18f/components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2075239e1a890ce7bd32ae54ca5575c145528649

commit 2075239e1a890ce7bd32ae54ca5575c145528649
Author: markusheintz <markusheintz@chromium.org>
Date: Thu Feb 23 11:50:59 2017

[remote suggestions] Add a new histogram for recording the time since a snippet was fetched.

This is the missing piece to https://codereview.chromium.org/2686063003/

BUG=690514

Review-Url: https://codereview.chromium.org/2707783004
Cr-Commit-Position: refs/heads/master@{#452465}

[modify] https://crrev.com/2075239e1a890ce7bd32ae54ca5575c145528649/components/ntp_snippets/content_suggestions_metrics.cc
[modify] https://crrev.com/2075239e1a890ce7bd32ae54ca5575c145528649/tools/metrics/histograms/histograms.xml

Comment 3 by treib@chromium.org, Jan 11 2018

Components: -UI>Browser>NewTabPage UI>Browser>ContentSuggestions
►

Sign in to add a comment