New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690472 link

Starred by 2 users
Status: Fixed
Owner:
█ bmcquade@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make page byte histogram logging consistent

Project Member Reported by bmcquade@chromium.org, Feb 9 2017 
The core and DRP observers both log bytes histograms, but they do so in slightly different ways:
* core only logs in OnComplete
* DRP logs as soon as any of OnComplete, FlushMetricsOnAppEnterBackground, or OnHidden is called

We'll update the policy to be consistent across all, logging in either OnComplete, or in FlushMetricsOnAppEnterBackground if we've already been committed.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5550e325a24cf8e44fa08aa4dc298051d2b5a63a

commit 5550e325a24cf8e44fa08aa4dc298051d2b5a63a
Author: bmcquade <bmcquade@chromium.org>
Date: Mon Feb 13 22:05:49 2017

Page load metrics observers cleanup

* use consistent policy for logging bytes and resource count histograms
* define a helper macro for logging bytes and resource count histograms
* only log from FlushMetrics for committed pages
* add SimulateLoadedResource test helper
* fix logic in PopulateRequiredTimingFields

BUG= 690471 ,  690472 

Review-Url: https://codereview.chromium.org/2681193003
Cr-Commit-Position: refs/heads/master@{#450109}

[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.h
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.h
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/chrome/browser/page_load_metrics/page_load_metrics_util.h
[modify] https://crrev.com/5550e325a24cf8e44fa08aa4dc298051d2b5a63a/tools/metrics/histograms/histograms.xml

Comment 2 by bmcquade@chromium.org, Feb 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment