New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690460 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

New DevTools Performance empty state UI

Reported by briangep...@briangeppert.com, Feb 9 2017

Issue description

Chrome Version       : 58.0.3006.0
OS Version: 10.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5: OK
  Firefox 4.x: OK
     IE 7/8/9: OK

What steps will reproduce the problem?
1. Open DevTools to the new Performance panel

What is the expected result?

Quickly able to use the new design.

What happens instead of that?

I was confused by the focus on communicating that the JavaScript profiler had been removed. That seems to be the core focus of the new UI.  If that's the intent, I would at least expect the removal notice to be linked to an explanation (e.g. https://developers.google.com/web/updates/2016/12/devtools-javascript-cpu-profile-migration ).

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3006.0 Safari/537.36


 
DevTools Performance panel empty state in Canary (58).PNG
95.8 KB View Download
Components: Platform>DevTools Platform>DevTools>UX Platform>DevTools>Performance
Labels: -OS-Windows -Type-Bug OS-All Type-Feature
Status: Untriaged (was: Unconfirmed)
Owner: alph@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by alph@chromium.org, Mar 18 2017

Cc: kayce@chromium.org alph@chromium.org
Owner: chowse@chromium.org
Chris, should we add more details to help CPU profiler users migration.

Comment 4 by kayce@google.com, Mar 20 2017

This bug reflects my gripe about having the CPU profiler warning on the Performance panel.

The CPU Profiler was located on what is now the Memory panel. It was removed from that panel because it's not related to Memory analysis, and because of duplicate functionality (everything you can do with the CPU Profiler, you can do with the Performance panel).

The warning should be located where the feature used to be located. That's where users are going to say "huh? what happened to the CPU profiler?"

It doesn't make sense to have it on the Performance panel. Look at how it confused the reporter of this bug. Having the warning on the Performance panel makes it seem like CPU profiling has been removed from the Performance panel

Comment 5 by chowse@chromium.org, Mar 20 2017

Cc: chowse@chromium.org
If we have a Help Center article that explains the migration, it makes sense to link to it in the deprecation warning. Let's add a "Learn more" link at the end of the first paragraph that links to https://developers.google.com/web/updates/2016/12/devtools-javascript-cpu-profile-migration .

@Kayce: The rationale was that if a developer were looking for the CPU Profiler, could no longer find a Profile tab, and were presented with the new choices of "Performance" and "Memory", they would visit "Performance" first. CPU profiling is about measuring performance, after all. The only risks would be if:

a.) They navigated those tabs spatially (i.e. Memory is in the same "place" as Profile was)
b.) They were on the Memory tab when they last opened DevTools before the update
c.) They judged each option by its "shape" (i.e. the Memory panel looks more like the old Profile panel)

(a) and (b) seemed extremely unlikely, and even in the event of (c), the next choice would be to open the Performance panel, which would provide the explanation. But, if we want to hedge our bets, we could include the warning on BOTH panels.

@alph: How much effort would it be duplicate the warning on the "Memory" panel? It could appear between the list of radio buttons and push buttons, and would need slightly different language (i.e. the first paragraph would be "The functionality of the JavaScript CPU Profiler has moved to the new Performance panel. _Learn more_").

Comment 6 by kayce@google.com, Mar 20 2017

That rationale makes sense, thanks. I definitely fall in the camp of (c), i.e. judging each option by its "shape".

Maybe the warning on the Performance panel should be more explicit about which feature has been removed. If I'm reading the reporter's original post correctly, the reporter thought that JS profiling had been removed from the Performance panel.

These are too verbose, but I would communicate the changes like this:

Warnings on Memory panel:

"This panel was previously called the Profiles panel. The "Record JavaScript CPU" feature that was previously on this panel has been moved. Learn more."

Warnings on Performance panel:

"The "Record JavaScript CPU" feature that was on the Profiles panel in previous versions of Chrome has been moved. You can use this panel to profile JavaScript. Learn more."

Comment 7 by chowse@chromium.org, Mar 20 2017

I'm okay with making this warning shorter, especially if there's now a Help article that explains the change (with visuals).

I'd cut even more aggressively:

Memory panel:
"The Memory panel provides features formerly found in the Profile panel. JavaScript CPU profiling has moved. _Learn more_"

Performance panel:
"The Performance panel provides features formerly found in the Timeline panel. You can use this panel to profile JavaScript. _Learn more_"

I think this will also help address Brain's issue with the warning being too prominent.
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03c41c3afff86bdc441eb093749f4b2a4f6056b0

commit 03c41c3afff86bdc441eb093749f4b2a4f6056b0
Author: alph <alph@chromium.org>
Date: Wed Mar 22 22:13:49 2017

DevTools: Add a link to JS CPU profiler migration notes.

BUG= 690460 

Review-Url: https://codereview.chromium.org/2764123003
Cr-Commit-Position: refs/heads/master@{#458893}

[modify] https://crrev.com/03c41c3afff86bdc441eb093749f4b2a4f6056b0/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js

@kayce Sorry for the late reply, but my misunderstanding that led me to file this was that I thought the ability to attribute CPU usage had been removed entirely.

@chowse Yes, your proposed rewording would have prevented my misunderstanding.  What I'm currently seeing in the attached screenshot would also have prevented my misunderstanding.

Thanks so much for being responsive.  I'd read the post announcing this change back when it was posted, but was surprised and confused when it actually happened.  The new UI is (in my opinion) much better.
Performance panel explanation.PNG
34.9 KB View Download
Owner: alph@chromium.org
@alph: are we done here?

Comment 11 by alph@chromium.org, Oct 20 2017

Status: Fixed (was: Assigned)

Sign in to add a comment