Remove kContentSuggestionsSource feature. |
||||
Issue descriptionCurrently kContentSuggestionsSource is not used anywhere. https://cs.chromium.org/search/?q=kContentSuggestionsSource&sq=package:chromium&type=cs Instead the source is specified through kArticleSuggestionsFeature. https://cs.chromium.org/chromium/src/components/ntp_snippets/remote/remote_suggestions_fetcher.cc?sq=package:chromium&type=cs&l=115 We should remove kContentSuggestionsSource and provide kArticleSuggestionsFeature in about::flags.
,
Feb 9 2017
Huh, correct. I'll fix the about:flags. I do not think we should remove the main feature. Shouldn't it guard whether we are allowed to create content_suggestions_service?
,
Feb 9 2017
At least it does nothing as of now :)
,
Feb 17 2017
,
Feb 22 2017
,
Mar 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f8a5670dffaf0a95d278428ae489a54b7d364bf commit 8f8a5670dffaf0a95d278428ae489a54b7d364bf Author: jkrcal <jkrcal@chromium.org> Date: Thu Mar 02 17:44:17 2017 [Remote suggestions] Add a remote suggestions flag to choose the source This CL removes an obsolete feature "NTPSnippets" and adds a flag into chrome://flags for the remote suggestions feature that allows to specify the source for remote suggestions (the flag was previously there for the obsolete feature but it had no effect). BUG= 690453 Review-Url: https://codereview.chromium.org/2705373004 Cr-Commit-Position: refs/heads/master@{#454298} [modify] https://crrev.com/8f8a5670dffaf0a95d278428ae489a54b7d364bf/chrome/app/generated_resources.grd [modify] https://crrev.com/8f8a5670dffaf0a95d278428ae489a54b7d364bf/chrome/browser/about_flags.cc [modify] https://crrev.com/8f8a5670dffaf0a95d278428ae489a54b7d364bf/components/ntp_snippets/features.cc [modify] https://crrev.com/8f8a5670dffaf0a95d278428ae489a54b7d364bf/components/ntp_snippets/features.h [modify] https://crrev.com/8f8a5670dffaf0a95d278428ae489a54b7d364bf/tools/metrics/histograms/histograms.xml
,
May 30 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by treib@chromium.org
, Feb 9 2017