New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690451 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Adjust the Reading List empty state background

Project Member Reported by gambard@chromium.org, Feb 9 2017

Issue description

Adjust the Reading List empty state background
 
Labels: M-57 ReleaseBlock-Beta
Needed: Change the color of the caret in the empty background string to match the text.
Change the width: Add a max width for the text of 270 (including in landscape).
Labels: -ReleaseBlock-Beta ReleaseBlock-Stable
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dabb468fa293d1f5c359549305ef1867c6805e9

commit 8dabb468fa293d1f5c359549305ef1867c6805e9
Author: gambard <gambard@chromium.org>
Date: Fri Feb 10 14:24:53 2017

Adjust the width of the ReadingList empty text

The text now has a max width of 270pt.

BUG= 690451 

Review-Url: https://codereview.chromium.org/2691503002
Cr-Commit-Position: refs/heads/master@{#449612}

[modify] https://crrev.com/8dabb468fa293d1f5c359549305ef1867c6805e9/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm

Status: Fixed (was: Assigned)
Labels: Merge-Request-57
merge https://codereview.chromium.org/2691503002
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 10 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: cma...@chromium.org
Labels: -Pri-3 Pri-1
+ Claude for manual review 
Status: Verified (was: Fixed)
Verified in 57.0.2987.50 dev, iPhone 6plus iOS 10.2, iPad mini 10.1
Reading List empty state has:
for iPad:
"Your reading list is available offline. To ass a page to your reading list, tap Share icon -> Read Later"
For iPhone:
"Your reading list is available offline. To ass a page to your reading list, tap menu icon -> Share icon -> Read Later"
https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLMi1acWM5R2NtTW8/view
 shbarezer@ shouldn't you be verifying this in Canary? It has not been merged into M57 yet. I wonder why it should be working in M57 when the fix did not make it there yet. 
Status: Fixed (was: Verified)
As specified in #2, the color of the arrows should match the text. They are slightly more transparent in the screenshot in #9.
The width of the label should also be shorter (270pt).
Status: Verified (was: Fixed)
Verified in 58.0.3012.0 canary, iPhone 6plus iOS 10.2, iPad mini 10.1

Claude@, I missread the issue thinking it was to do with the actual text. 
So to be clear the color of the arrows does match the text.
Looks good.
Labels: -Hotlist-Merge-Review -Merge-Review-57 Merge-Approved-57
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 15 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a128628d2b10e28a55dd24006b88a1625a87b4b9

commit a128628d2b10e28a55dd24006b88a1625a87b4b9
Author: gambard <gambard@chromium.org>
Date: Wed Feb 15 08:12:14 2017

Adjust the width of the ReadingList empty text

The text now has a max width of 270pt.

BUG= 690451 

Review-Url: https://codereview.chromium.org/2691503002
Cr-Commit-Position: refs/heads/master@{#449612}
(cherry picked from commit 8dabb468fa293d1f5c359549305ef1867c6805e9)

Review-Url: https://codereview.chromium.org/2696043003 .
Cr-Commit-Position: refs/branch-heads/2987@{#519}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/a128628d2b10e28a55dd24006b88a1625a87b4b9/ios/chrome/browser/ui/reading_list/reading_list_empty_collection_background.mm

Verified in 57.0.2987.96 dev, iPhone 6plus iOS 10.2, iPad mini 10.1
The color of the arrows does match the text.
Looks good.
Components: UI>Browser>ReaderMode

Sign in to add a comment