Potential bug in src/third_party/opus/src/silk/MacroCount.h
Reported by
pet...@gmail.com,
Feb 9 2017
|
||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Steps to reproduce the problem: The possible problem I observed is at the source code level (in the chromium code downloaded from its repo). In the file src/third_party/opus/src/silk/MacroCount.h line 702, shouldn't the return type of the silk_LIMIT_32 function be "opus_int32" instead of "opus_int"? All parameters and the variable used to compute the return value are declared as "opus_int32". Moreover, in the case of other functions from the same file, there is a consistency between these types and the return type of the corresponding functions. I detected this automatically using a CodeSonar plugin. What is the expected behavior? Not applicable. What went wrong? Not applicable. Did this work before? N/A Chrome version: Channel: n/a OS Version: OS X 10.12.2 Flash Version: Shockwave Flash 24.0 r0
,
Feb 13 2017
,
Feb 14 2017
,
Feb 14 2017
Chromium only depends on Opus as a third_party component. For bugs inside Opus, it is advisable to report to https://git.xiph.org/?p=opus.git\ Thanks. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ligim...@chromium.org
, Feb 10 2017