New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690424 link

Starred by 1 user
Status: Fixed
Owner:
rsesek@chromium.org
Closed: Mar 2017
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Browser crash is observed after hitting spacebar key for 'added folder' on bookmark bar.

Reported by vku...@etouch.net, Feb 9 2017 
Chrome Version: 58.0.3007.0 (Official Build)0e09de60e479fe2ee105fb731b403c729fce3ac1-refs/heads/master@{#449173} 64-bit.
OS: Mac (10.11.6,10.12.1)

What steps will reproduce the problem?
(1)Launch chrome and press cmd+shift+B such that bookmark bar appears.
(2)Right click and click on 'Add folder' option,press tab key till focus reached folder icon.
(3)Hit spacebar key to open folder,press down arrow key and again press hold spacebar key observe.

Actual: Browser crash is observed after hitting spacebar key (i.e after step 3)
Crash ID ad6a5a9c-bc78-4e0b-abea-b838a94b5121 (Server ID: 01b973bc80000000)

Expected: Browser should not crash after hitting spacebar key.

This is a Non-regression issue seen from 'M30' series i.e 30.0.1579.0 

Note: Issue not seen on Win & Linux OS.
Actual_Crash.mov
3.0 MB Download

Comment 1 by ranjitkan@chromium.org, Feb 9 2017

Status: Untriaged (was: Unconfirmed)
Stack trace for the Crash ID generated:

81%Show frame trust levels
0x00007fff9032b254	(libc++.1.dylib + 0x0003f254 )	std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >::basic_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)
0x000000010b447a74	(Google Chrome Framework -gurl.cc:73 )	GURL::GURL(GURL const&)
0x000000010d68c1d1	(Google Chrome Framework -bookmark_bar_controller.mm:823 )	-[BookmarkBarController openBookmark:]
0x000000010d698b3a	(Google Chrome Framework -bookmark_bar_folder_controller.mm:1708 )	-[BookmarkBarFolderController handleInputText:]
0x000000010d68ca80	(Google Chrome Framework -bookmark_bar_controller.mm:997 )	__43-[BookmarkBarController watchForExitEvent:]_block_invoke
0x00007fff98609445	(AppKit + 0x001d7445 )	_NSSendEventToObservers
0x00007fff98607083	(AppKit + 0x001d5083 )	-[NSApplication sendEvent:]
0x000000010ac425cb	(Google Chrome Framework -chrome_browser_application_mac.mm:277 )	__34-[BrowserCrApplication sendEvent:]_block_invoke
0x000000010b090f39	(Google Chrome Framework + 0x01a1bf39 )	base::mac::CallWithEHFrame(void () block_pointer)
0x000000010ac423a4	(Google Chrome Framework -chrome_browser_application_mac.mm:261 )	-[BrowserCrApplication sendEvent:]
0x00007fff9846edf1	(AppKit + 0x0003cdf1 )	-[NSApplication run]
0x000000010b0a0dad	(Google Chrome Framework -message_pump_mac.mm:637 )	base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*)
0x000000010b0a042b	(Google Chrome Framework -message_pump_mac.mm:210 )	base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*)
0x000000010b0be5d2	(Google Chrome Framework -run_loop.cc:37 )	base::RunLoop::Run()
0x000000010ac47758	(Google Chrome Framework -chrome_browser_main.cc:2004 )	ChromeBrowserMainParts::MainMessageLoopRun(int*)
0x0000000109b0ac13	(Google Chrome Framework -browser_main_loop.cc:1183 )	content::BrowserMainLoop::RunMainMessageLoopParts()
0x0000000109b0db81	(Google Chrome Framework -browser_main_runner.cc:141 )	content::BrowserMainRunnerImpl::Run()
0x0000000109b0673b	(Google Chrome Framework -browser_main.cc:46 )	content::BrowserMain(content::MainFunctionParams const&)
0x000000010ac000af	(Google Chrome Framework -content_main_runner.cc:821 )	content::ContentMainRunnerImpl::Run()
0x000000010abff375	(Google Chrome Framework -content_main.cc:20 )	content::ContentMain(content::ContentMainParams const&)
0x000000010967887a	(Google Chrome Framework -chrome_main.cc:112 )	ChromeMain
0x0000000109410d99	(Google Chrome -chrome_exe_main_mac.c:85 )	main
0x00007fff8e4855ac	(libdyld.dylib + 0x000035ac )	start

Below link gives in detail for the total number of instances in which the crash has appeared on associated builds:

https://goto.google.com/cuirx

Untriaged it so that it gets addressed.

Comment 2 by msrchandra@chromium.org, Feb 9 2017

Labels: Stability-Crash

Comment 3 by msrchandra@chromium.org, Feb 9 2017

Labels: Restrict-View-Google

Comment 4 by rsesek@chromium.org, Feb 10 2017

Labels: -Restrict-View-Google

Comment 5 by rsesek@chromium.org, Feb 13 2017

Owner: rsesek@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8da61374a11432c3b6c3acf43d50d562439dba02

commit 8da61374a11432c3b6c3acf43d50d562439dba02
Author: rsesek <rsesek@chromium.org>
Date: Mon Mar 13 20:22:11 2017

[Mac] Fix a crash in handling keyboard shortcuts for empty bookmark folder menus.

Empty bookmark bar folder menus have an "(empty)" button that is not associated
with an actual model node. This leads to a DCHECK in the BookmarkBarController,
but crashes in release mode.

BUG= 690424 

Review-Url: https://codereview.chromium.org/2752433002
Cr-Commit-Position: refs/heads/master@{#456460}

[modify] https://crrev.com/8da61374a11432c3b6c3acf43d50d562439dba02/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm
[modify] https://crrev.com/8da61374a11432c3b6c3acf43d50d562439dba02/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller_unittest.mm

Comment 7 by rsesek@chromium.org, Mar 13 2017

Status: Fixed (was: Started)

Comment 8 by rsesek@chromium.org, Mar 14 2017

Labels: -M-58 M-59
►

Sign in to add a comment