Content suggestions: Reduce whitespace related to the relative disposition of the attribution line and the thumbnail |
|||||||||||||
Issue descriptionCurrently, the disposition of content suggestions look like: +----------------------+ | Header header +----+ | | header | | | | Description +----+ | | description | | Attribution attrib...| +----------------------+ Since we are trying to condense the view, here are 2 issues: 1. When the attribution line is short, there is a lot of whitespace below the thumbnail 2. When the header + description lenght is short, we still reserve 3 lines for it to be sure the attribution line will be below the thumbnail. This results in empty space in the middle of the card (see screenshot 1) Which approach should we follow to regain vertical space? A caveat is that we might get cards of varying heights, but this can already happen (see screenshot 1) Attached are different prototypes: 1. State as currently shipping on master 2. Removes the restriction of card height, which means that sometimes the attribution line will be clipped by the thumbnail. 3. Removes the restriction of card height and makes the attribution line short enough to not be clipped by the thumbnail in an ugly way. A combination of 2 and 3 could be implemented, that would allow the attibution line to extend below the thumbnail if there is space. But we would get attribution lines of varying lenghts.
,
Feb 13 2017
,
Feb 13 2017
,
Feb 13 2017
State after https://codereview.chromium.org/2690123002
,
Feb 14 2017
Looks good to me, thanks!
,
Feb 15 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3371166ee6b13e7d34d3a8a216bf041abc3ce9b9 commit 3371166ee6b13e7d34d3a8a216bf041abc3ce9b9 Author: dgn <dgn@chromium.org> Date: Thu Feb 16 11:34:03 2017 [NTP Client] Remove whitespace between card title and attribution Allows the attribution line to move up beside the thumbnail and below the title when there is not description BUG= 690420 ,631447 Review-Url: https://codereview.chromium.org/2690123002 Cr-Commit-Position: refs/heads/master@{#450933} [modify] https://crrev.com/3371166ee6b13e7d34d3a8a216bf041abc3ce9b9/chrome/android/java/res/layout/new_tab_page_snippets_card.xml [modify] https://crrev.com/3371166ee6b13e7d34d3a8a216bf041abc3ce9b9/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/3371166ee6b13e7d34d3a8a216bf041abc3ce9b9/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
,
Feb 16 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9b5580df750abd8c3354d7c63e8a7d38c479ea39 commit 9b5580df750abd8c3354d7c63e8a7d38c479ea39 Author: vitaliii <vitaliii@chromium.org> Date: Thu Feb 16 14:42:43 2017 [NTP::Downloads] Move attribution higher if description is empty. Previously, the attribution was moved higher only for layouts which do not show description. In this CL, this is also done for cards with empty description. This is needed to make Downloads look better (they have thumbnails and do not have descriptions). BUG= 690420 Review-Url: https://codereview.chromium.org/2698833004 Cr-Commit-Position: refs/heads/master@{#450959} [modify] https://crrev.com/9b5580df750abd8c3354d7c63e8a7d38c479ea39/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by dgn@chromium.org
, Feb 9 2017