New issue
Advanced search Search tips
Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 690364



Sign in to add a comment

Implement Blink layer of mediaCapabilities.decodingInfo()

Project Member Reported by mlamouri@chromium.org, Feb 9 2017

Issue description

This is for this basically about implementing the web interface. Other bugs will be opened for the specific features (support detection, power, etc.)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff0742e6a8b37e90885d1700d625e17a71b44739

commit ff0742e6a8b37e90885d1700d625e17a71b44739
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Feb 14 23:22:12 2017

Media Capabilities: stub implementation of mediaCapabilities.query().

Returns an object that agrees with everything.

BUG= 690380 

Review-Url: https://codereview.chromium.org/2685863004
Cr-Commit-Position: refs/heads/master@{#450509}

[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/W3CImportExpectations
[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/README.md
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html
[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/BUILD.gn
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/AudioConfiguration.idl
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/BUILD.gn
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/DEPS
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.cpp
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.h
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaCapabilities.idl
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaConfiguration.idl
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.cpp
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.h
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/MediaDecodingAbility.idl
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.cpp
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.h
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/NavigatorMediaCapabilities.idl
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/OWNERS
[add] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/mediacapabilities/VideoConfiguration.idl
[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/ff0742e6a8b37e90885d1700d625e17a71b44739/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e751d794815701533203812a5ea101aa16689a27

commit e751d794815701533203812a5ea101aa16689a27
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Feb 20 23:12:54 2017

Media Capabilities: update Blink implementation and WPT to match latest spec changes.

Changes are:
- s/type/contentType/ in {Audio/Video}Configuration;
- add [SameObject] to partial Navigator interfaces;
- rename "MediaSource" enum entry to "media-source".

This is also adding more tests for checks of valid
MediaConfiguration.type when running query().

BUG= 690380 
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2706093002
Cr-Commit-Position: refs/heads/master@{#451669}

[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html
[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/query.html
[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/Source/modules/mediacapabilities/AudioConfiguration.idl
[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/Source/modules/mediacapabilities/MediaConfiguration.idl
[modify] https://crrev.com/e751d794815701533203812a5ea101aa16689a27/third_party/WebKit/Source/modules/mediacapabilities/VideoConfiguration.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2446f652488f56771631375ee11d2396de248e7

commit f2446f652488f56771631375ee11d2396de248e7
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Feb 21 22:08:57 2017

Media Capabilities: rename mediacapabilities module to media_capabilities.

It was really hard to read and that prevented me from sleeping at night.

BUG= 690380 
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2707033002
Cr-Commit-Position: refs/heads/master@{#451846}

[modify] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/BUILD.gn
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/AudioConfiguration.idl
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/BUILD.gn
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/DEPS
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaConfiguration.idl
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.idl
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.cpp
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.h
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/NavigatorMediaCapabilities.idl
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/OWNERS
[rename] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/media_capabilities/VideoConfiguration.idl
[modify] https://crrev.com/f2446f652488f56771631375ee11d2396de248e7/third_party/WebKit/Source/modules/modules_idl_files.gni

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82

commit fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Mar 13 23:22:22 2017

Media Capabilities: add plumbing between Blink and media/blink/.

So much yummy plumbing! :)

Also fixing a typo in an IDL.

BUG= 690380 
R=chcunningham@chromium.org

Review-Url: https://codereview.chromium.org/2706313002
Cr-Commit-Position: refs/heads/master@{#456536}

[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/content/child/BUILD.gn
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/content/child/blink_platform_impl.cc
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/content/child/blink_platform_impl.h
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/media/blink/BUILD.gn
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/media/blink/webmediacapabilitiesclient_impl.cc
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/media/blink/webmediacapabilitiesclient_impl.h
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/Source/modules/media_capabilities/AudioConfiguration.idl
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/Platform.h
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/OWNERS
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/WebAudioConfiguration.h
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesClient.h
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaConfiguration.h
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaDecodingAbility.h
[add] https://crrev.com/fb77ac6ce92d2d64c8ac514a7ad08a32db3c5e82/third_party/WebKit/public/platform/modules/media_capabilities/WebVideoConfiguration.h

Summary: Implement Blink layer of mediaCapabilities.decodingInfo() (was: Implement Blink layer of mediaCapabilities.query())
Labels: -M-59 M-60
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a147c6267bcb9c5321eb5e4db112a32199e92848

commit a147c6267bcb9c5321eb5e4db112a32199e92848
Author: mlamouri <mlamouri@chromium.org>
Date: Mon Apr 10 21:35:57 2017

[Media Capabilities] Rename query() to decodingInfo() and MediaDecodingAbility to MediaCapabilitiesInfo

This is matching recent spec changes:
https://github.com/WICG/media-capabilities/pull/31

The MediaConfiguration changes are not reflected in this CL.

BUG= 690380 
R=mcasas@chromium.org,sandersd@chromium.org

Review-Url: https://codereview.chromium.org/2807713002
Cr-Commit-Position: refs/heads/master@{#463403}

[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/media/blink/webmediacapabilitiesclient_impl.cc
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/media/blink/webmediacapabilitiesclient_impl.h
[rename] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/decodingInfo.html
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/BUILD.gn
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[add] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.cpp
[add] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.h
[rename] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilitiesInfo.idl
[delete] https://crrev.com/e0f87e573b0b8cba4b2d739a8c5a86c0f448d513/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.cpp
[delete] https://crrev.com/e0f87e573b0b8cba4b2d739a8c5a86c0f448d513/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingAbility.h
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesClient.h
[add] https://crrev.com/a147c6267bcb9c5321eb5e4db112a32199e92848/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaCapabilitiesInfo.h
[delete] https://crrev.com/e0f87e573b0b8cba4b2d739a8c5a86c0f448d513/third_party/WebKit/public/platform/modules/media_capabilities/WebMediaDecodingAbility.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9c64a91ffa876438944769b5921d171b5390cc8

commit e9c64a91ffa876438944769b5921d171b5390cc8
Author: mcasas <mcasas@chromium.org>
Date: Wed Apr 12 17:00:27 2017

Media Capabilities: add MediaDecodingConfiguration.idl and update to Spec

This CL shuffles around the idl data structures to match
the current Spec status, namely:
- gets MediaType and |type| out of MediaConfiguration(.idl)
- adds them to a new file MediaDecodingConfiguration(.idl),
 as MediaDecodingType |type|. MediaDecodingConfiguration
 derives from MediaConfiguration.

LayoutTests updated accordingly.

BUG= 709181 ,  690380 

Review-Url: https://codereview.chromium.org/2813133002
Cr-Commit-Position: refs/heads/master@{#464057}

[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness-expected.txt
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/LayoutTests/external/wpt/media-capabilities/idlharness.html
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.cpp
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.h
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaCapabilities.idl
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaConfiguration.idl
[add] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/media_capabilities/MediaDecodingConfiguration.idl
[modify] https://crrev.com/e9c64a91ffa876438944769b5921d171b5390cc8/third_party/WebKit/Source/modules/modules_idl_files.gni

Components: -Blink>Media Blink>Media>Capabilties
Cc: jcliang@chromium.org wuchengli@chromium.org posciak@chromium.org
Status: Fixed (was: Started)
Closing as it should be done and any remaining work will be done in follow-up bugs.

Sign in to add a comment