Regression: Show/Hide password tool tip is seen missing in Saved password details overlay of chrome://md-settings. |
|||||
Issue descriptionChrome Version: 58.0.3006.0/9265.0.0 dev-channel Daisy,Candy and Minnie OS:Chrome Precondition: Save passwords for any two sites. What steps will reproduce the problem? (1)Navigate to chrome://md-settings/passwords page >> Click on View details option in 3 dot menu of Saved Passwords (2)Hover on eye icon in Saved password details overlay and Observe for tool tip Expected: Show/Hide password tool tip should be seen upon hovering over eye icon. Actual: Instead Show/Hide password tool tip is seen missing This is regression issue as Show/Hide button is seen in chrome://settings page. Attaching screen-cast for reference.
,
Feb 9 2017
i think we just need a title="" on the <(o)> eye
,
Feb 15 2017
Adding title to button. Titles will be "Show password" and "Hide password".
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52c6fa8ea1623e667d43661526707cb4da6feed2 commit 52c6fa8ea1623e667d43661526707cb4da6feed2 Author: hcarmona <hcarmona@chromium.org> Date: Thu Feb 16 16:34:03 2017 [MD Settings] Add title to show/hide password button. BUG= 690362 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2693373002 Cr-Commit-Position: refs/heads/master@{#450987} [modify] https://crrev.com/52c6fa8ea1623e667d43661526707cb4da6feed2/chrome/app/settings_strings.grdp [modify] https://crrev.com/52c6fa8ea1623e667d43661526707cb4da6feed2/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html [modify] https://crrev.com/52c6fa8ea1623e667d43661526707cb4da6feed2/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.js [modify] https://crrev.com/52c6fa8ea1623e667d43661526707cb4da6feed2/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
,
Feb 16 2017
,
Feb 27 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by abodenha@chromium.org
, Feb 9 2017Status: Assigned (was: Untriaged)