New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690355 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Respect as much as possible the image extension

Project Member Reported by gambard@chromium.org, Feb 9 2017

Issue description

Chrome Version: M56

What steps will reproduce the problem?
(1) Download an image with Chrome
(2) Try to open it with an GIF reading app (reproducible with "gif Book").

What is the expected result?
The app should detect the gif

What happens instead?
Nothing happens

This probably because Chrome strips the file extension by resolving http://crbug.com/674555
 
Labels: ReleaseBlock-Stable M-57
Probably RBS.
To add details: in step 1 you have to download gif (as the application will only display gif).
The downloaded gif can be shared with most applications from the Photos application using the share button. For example sending a gif with the Messages app works (it is animated in the Messages app).
Cc: gambard@chromium.org
 Issue 656641  has been merged into this issue.
 Issue 690452  has been merged into this issue.
Cc: linds...@chromium.org
The behavior is the same in Firefox. It only works with Safari.
I have a fix for it. I need to evaluate how risky it is to land it on M57.
Cc: pinkerton@chromium.org
Labels: -Type-Bug Type-Bug-Regression
Marking as regression. We should try to get this landed for m57.
Labels: -Pri-3 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9efce7a0be559aa13c499f4400c2f2c3f66157c6

commit 9efce7a0be559aa13c499f4400c2f2c3f66157c6
Author: gambard <gambard@chromium.org>
Date: Thu Feb 09 18:53:17 2017

Use mime type for image extension

This CL uses the mime type to determine the best image extension when saving
an image.

BUG= 690355 

Review-Url: https://codereview.chromium.org/2687873002
Cr-Commit-Position: refs/heads/master@{#449365}

[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/BUILD.gn
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/image_data_fetcher.cc
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/image_data_fetcher.h
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/image_data_fetcher_unittest.cc
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/image_fetcher_impl.cc
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/image_fetcher_impl.h
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.h
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/ios/ios_image_data_fetcher_wrapper.mm
[add] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/request_metadata.cc
[add] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/request_metadata.h
[add] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/components/image_fetcher/request_metadata_unittest.cc
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/ios/chrome/browser/suggestions/image_fetcher_impl.mm
[modify] https://crrev.com/9efce7a0be559aa13c499f4400c2f2c3f66157c6/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Assigned)
Fixed on canary (M58).
To test this:
- Verify this bug
- Try to download different type of images (png, tiff, jpeg...)
- Verify crbug.com/674555
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-57; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-57 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD Merge-Request-57
Merge https://codereview.chromium.org/2686023003/
Project Member

Comment 13 by sheriffbot@chromium.org, Feb 10 2017

Labels: -Merge-Request-57 Hotlist-Merge-Review Merge-Review-57
This bug requires manual review: Less than 2 weeks to go before AppStore submit on M57
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: cma...@chromium.org
+cmasso for manual review.
Issue is fixed on latest chrome canary version 58.0.3011.0.

Issue is not fixed on latest chrome dev version 57.0.2987.50.  Checked on iPhone 6 plus with iOS 10.3.

Comment 16 Deleted

Labels: -Hotlist-Merge-Review -Merge-Review-57 Merge-Approved-57
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 14 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cfc7b5297cedfc19b45c9b89930d259c4a864ddd

commit cfc7b5297cedfc19b45c9b89930d259c4a864ddd
Author: gambard <gambard@chromium.org>
Date: Tue Feb 14 07:43:13 2017

Use mime type for image extension

This CL uses the mime type to determine the best image extension when saving
an image.

BUG= 690355 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2686023003
Cr-Commit-Position: refs/branch-heads/2987@{#495}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/cfc7b5297cedfc19b45c9b89930d259c4a864ddd/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/cfc7b5297cedfc19b45c9b89930d259c4a864ddd/ios/web/public/image_fetcher/image_data_fetcher.h
[modify] https://crrev.com/cfc7b5297cedfc19b45c9b89930d259c4a864ddd/ios/web/public/image_fetcher/image_data_fetcher.mm

The issue should be fixed in next beta.
Status: Verified (was: Fixed)
Verified on chrome beta version 57.0.2987.53 on iPhone 6 plus with iOS 10.3, iPhone 7 plus with iOS 10.2.1, iPad4 with iOS 10.2.1

Steps followed for verification:
Precondition: Install Gif Book app or GIF show app

Steps to reproduce:
  1. Navigate to giphy.com and save a gif by long tapping on the gif and selecting save image
  2. Open Gif Book

Verified that gif files are saved and also opened in gif apps.  Looks good.

Video : https://drive.google.com/a/google.com/file/d/0Bz2uwV55gGwDNXpwZFBIVDZ1ckk/view?usp=sharing

Cc: srikanthg@chromium.org
 Issue 687175  has been merged into this issue.
Components: UI>Browser>NewTabPage

Sign in to add a comment