Regression : Unnecessarily cursor stays in search field in chrome://md-settings/editDictionary.
Reported by
mni...@etouch.net,
Feb 9 2017
|
||||||||
Issue descriptionVersion: 58.0.3007.0 0e09de60e479fe2ee105fb731b403c729fce3ac1-refs/heads/master@{#449173} OS: Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/editDictionary and click on 'Add word' button which is in disable form , observe the cursor in 'Search settings' search field. Actual: Unnecessarily cursor stays in 'Search settings' search field Expected: Unnecessarily cursor should not stay in 'Search settings' search field This is regression issue, broken in ‘M 58’ and will soon update other info : Good build:58.0.3005.2 Bad build: 58.0.3006.0 Note : Issue is not seen in Linux and Mac OS.
,
Feb 9 2017
,
Feb 13 2017
My change is not related. This looks like an intentional change in r448524.
,
Feb 16 2017
Re-bisected the issue and below is the Narrow bisect : Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/00f7089132148e96541a6a476a68809790048e81..c9625f069b73578ab45f49be70a830d48f6141bc?pretty=fuller&n=100 Suspecting: r448797 from Narrow bisect @kenrb : Could you please help to reassign if your change is not the cause for this change. Note : Actual issue is : Cursor stays in search field after clicking mouse anywhere outside search field.Kindly review the attached video for reference
,
Feb 16 2017
This isn't related to my CL at all. Possibly r448799. cc'ing scottchen@ as per c#3.
,
Feb 16 2017
I reproduced on Linux and Mac. To reproduce you need to click "Add a new word" when the caret is "on" when blinking "on" and "off" in the Search settings box.
,
Feb 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/942dfae2326142b0af47b32c407b70c2e13e86fc commit 942dfae2326142b0af47b32c407b70c2e13e86fc Author: wangxianzhu <wangxianzhu@chromium.org> Date: Sat Feb 18 07:34:07 2017 Fix caret paint invalidation when moving between blocks Previously when caret is moved between blocks, the code only worked if the source block was visited before the target block during paint invalidation. If the target block was visited earlier (depending on the dom order), CaretDisplayItemClient::m_visualRect would be set to the visual rect of the new caret, then when the source block was visited, we invalidated the old caret at the location of the new caret. Add CaretDisplayItemClient::m_previousVisualRect, and set it to m_visualRect when m_previousBlock is set to m_layoutBlock. When m_previousBlock is visited, invalidate m_previousVisualRect. Move Source/core/paint/BlockPaintInvalidatorTest.cpp to Source/core/editing/CaretDisplayItemClientTest.cpp to be closer to the tested code. BUG= 690352 TEST=CaretDisplayItemClientTest.CaretMovesBetweenBlocks CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2698313003 Cr-Commit-Position: refs/heads/master@{#451440} [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/linux/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/LayoutTests/platform/win/virtual/disable-spinvalidation/paint/invalidation/4776765-expected.txt [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.cpp [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/Source/core/editing/CaretDisplayItemClient.h [add] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/Source/core/editing/CaretDisplayItemClientTest.cpp [modify] https://crrev.com/942dfae2326142b0af47b32c407b70c2e13e86fc/third_party/WebKit/Source/core/editing/FrameSelection.h [delete] https://crrev.com/ba7ad64c7261ca0facc8f5e9eb1765a006f457b0/third_party/WebKit/Source/core/paint/BlockPaintInvalidatorTest.cpp
,
Feb 19 2017
,
Feb 21 2017
Issue 693576 has been merged into this issue.
,
Feb 21 2017
Tested the issue on Latest Dev# 58.0.3018.0 on Windows, Mac and Linux and the issue is not reproducible. Hence adding TE-Verified Labels. Adding a screen cast for reference. Thank You.
,
Feb 23 2017
Issue 691543 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by hdodda@chromium.org
, Feb 9 2017Labels: hasbisect-per-revision
Owner: skobes@chromium.org
Status: Assigned (was: Unconfirmed)