New issue
Advanced search Search tips

Issue 690351 link

Starred by 1 user
Status: Archived
Owner:
hidehiko@chromium.org
Closed: Feb 2017
Cc:
vapier@chromium.org
satorux@chromium.org
ihf@chromium.org
nya@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

hardware_PerfCounterVerification and hardware_TLBMissCost build takes long time.

Project Member Reported by hidehiko@chromium.org, Feb 9 2017 
Chrome Version: ToT
OS: ChromeOS

autotest-tests is built after many packages because of deps,
and is on the build_package's critical path in most cases.
About 20% of its build time is consumed by the following two test cases:
- hardware_PerfCounterVerification
- hardware_TLBMissCost

Technically, we can do some improvement on the test builds.
However those tests looks introduced for experimental thing, and no longer maintained, so maybe it's ok to delete them now.

Comment 1 by jrbarnette@chromium.org, Feb 9 2017 

The tests are part of the "experimental" suite.  That suite
exists as a staging area where tests can be tried out to
prove that they're stable enough for an important suite like
bvt-inline or bvt-cq.  Tests aren't supposed to stay there
indefinitely; they're supposed to move up, or move out.

So, unless someone steps forward to say "this test will be
maintained and moved into a monitored test suite", it can/should
be deleted.  For my money, you shouldn't wait very long before
you delete the code:  Undelete is easy, and the quickest way
to find that someone cares may be to delete it.

Comment 2 by hidehiko@chromium.org, Feb 9 2017

Labels: OS-Chrome
Status: Started (was: Available)
Thank you for comments.
I'll work on removing them.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/8a12541b2c74313d45d85656718b6bc98cdc7a7a

commit 8a12541b2c74313d45d85656718b6bc98cdc7a7a
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Feb 11 08:35:20 2017

Remove hardware_PerfCounterVerification and hardware_TLBMissCost.

These seem no longer used. Also they took time to build,
even if they don't run (~30s, about 15% of autotest-tests build time).

BUG= chromium:690351 
TEST=Run pre-CQ.

Change-Id: I1c0b1db3ccdd943d0e63692b54ad78d6570d8ec0
Reviewed-on: https://chromium-review.googlesource.com/440868
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/8a12541b2c74313d45d85656718b6bc98cdc7a7a/chromeos-base/autotest-tests/autotest-tests-9999.ebuild
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/25ebcf31b7540dc1ed6cd8c9c134a83044085acf

commit 25ebcf31b7540dc1ed6cd8c9c134a83044085acf
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Feb 11 08:35:20 2017

Remove hardware_PerfCounterVerification and hardware_TLBMissCost.

These seem no longer used. Also they took time to build,
even if they don't run (~30s, about 15% of autotest-tests build time).

CQ-DEPEND=CL:440868
BUG= chromium:690351 
TEST=Run pre-CQ.

Change-Id: I293dfd831f14cb3667d4e238981c16da8cdfa79b
Reviewed-on: https://chromium-review.googlesource.com/440888
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>

[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/iTLB_benchmark_function.h
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/perf_measurement.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/generateBenchmarkFunction.sh
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/hardware_PerfCounterVerification.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/find_loop_instructions.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/src/iTLB_benchmark.c
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/src/iTLB_benchmark_function.h
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/perf_lbr_verification.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/src/generateBenchmarkFunction.sh
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/control
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/iTLB_benchmark.c
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/perf_verification.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/Makefile
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/noploop.c
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/src/dTLB_benchmark.c
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/control
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_PerfCounterVerification/stats_utils.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/hardware_TLBMissCost.py
[delete] https://crrev.com/7b4fdbf2088f9ba48f17ffaa33c5e9f0ad348cbd/client/site_tests/hardware_TLBMissCost/src/Makefile
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 11 2017

Labels: merge-merged-release-R57-9202.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4f310241051db76bf23e188ae68adf71e34b13a5

commit 4f310241051db76bf23e188ae68adf71e34b13a5
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Feb 11 08:46:00 2017

Remove hardware_PerfCounterVerification and hardware_TLBMissCost.

These seem no longer used. Also they took time to build,
even if they don't run (~30s, about 15% of autotest-tests build time).

BUG= chromium:690351 
TEST=Run pre-CQ.

Change-Id: I1c0b1db3ccdd943d0e63692b54ad78d6570d8ec0
Reviewed-on: https://chromium-review.googlesource.com/440868
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 8a12541b2c74313d45d85656718b6bc98cdc7a7a)
Reviewed-on: https://chromium-review.googlesource.com/441115
Tested-by: Ilja H. Friedel <ihf@chromium.org>

[modify] https://crrev.com/4f310241051db76bf23e188ae68adf71e34b13a5/chromeos-base/autotest-tests/autotest-tests-9999.ebuild
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 11 2017

Labels: merge-merged-release-R56-9000.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/75d065859c467e62e5664a1ca56a2dafccf5c145

commit 75d065859c467e62e5664a1ca56a2dafccf5c145
Author: Hidehiko Abe <hidehiko@chromium.org>
Date: Sat Feb 11 08:46:21 2017

Remove hardware_PerfCounterVerification and hardware_TLBMissCost.

These seem no longer used. Also they took time to build,
even if they don't run (~30s, about 15% of autotest-tests build time).

BUG= chromium:690351 
TEST=Run pre-CQ.

Change-Id: I1c0b1db3ccdd943d0e63692b54ad78d6570d8ec0
Reviewed-on: https://chromium-review.googlesource.com/440868
Commit-Ready: Ilja H. Friedel <ihf@chromium.org>
Tested-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 8a12541b2c74313d45d85656718b6bc98cdc7a7a)
Reviewed-on: https://chromium-review.googlesource.com/441115
Tested-by: Ilja H. Friedel <ihf@chromium.org>
(cherry picked from commit 4f310241051db76bf23e188ae68adf71e34b13a5)
Reviewed-on: https://chromium-review.googlesource.com/441116

[modify] https://crrev.com/75d065859c467e62e5664a1ca56a2dafccf5c145/chromeos-base/autotest-tests/autotest-tests-9999.ebuild

Comment 7 by hidehiko@chromium.org, Feb 13 2017

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 10 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment