New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690348 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CRAS: crash at cras_tm_cancel_timer

Project Member Reported by hychao@chromium.org, Feb 9 2017

Issue description

Thread 0 CRASHED [SIGSEGV @ 0x00000000 ] MAGIC SIGNATURE THREAD
Stack Quality78%Show frame trust levels
0x00007f4d2e1e5af0	(cras -cras_tm.c:81 )	cras_tm_cancel_timer
0x00007f4d2e1aec78	(cras -cras_bt_device.c:1105 )	bt_device_process_msg
0x00007f4d2e1e14e9	(cras -cras_main_message.c:95 )	handle_main_messages
0x00007f4d2e1e4530	(cras -cras_server.c:547 )	cras_server_run
0x00007f4d2e1acecc	(cras -cras.c:110 )	main
0x00007f4d2d2b9fb5	(libc-2.19.so -libc-start.c:292 )	__libc_start_main
0x00007f4d2e1acf19	(cras + 0x00008f19 )	_start
0x00007ffd7c2e9ef7		
0x00007f4d2e1acef0	(cras -cras.c:111 )	main

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/825b11343233267b67b15bbea7b399675036a824

commit 825b11343233267b67b15bbea7b399675036a824
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Thu Feb 09 19:04:38 2017

CRAS: tm - Fix invalid memory access in cras_tm

BUG= chromium:690348 
TEST=None

Change-Id: I6cb889b19358014b5c8dd655c1ecb24bde2e6f91
Reviewed-on: https://chromium-review.googlesource.com/440047
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/825b11343233267b67b15bbea7b399675036a824/cras/src/server/cras_tm.c

Comment 2 by hychao@chromium.org, Feb 10 2017

Cc: keta...@chromium.org
Labels: -Pri-3 M-57 Merge-Request-57 Pri-1
Status: Started (was: Assigned)
We need this for M57 because the crash can be reproduced with the scenario in chrome-os-partner:59015
Labels: -Merge-Request-57 Merge-Approved-57
Approving merge to M57 Chrome OS.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 11 2017

Labels: merge-merged-release-R57-9202.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e7f76b3639a0183726aede6bff75470cbafcd394

commit e7f76b3639a0183726aede6bff75470cbafcd394
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Sat Feb 11 15:15:53 2017

CRAS: tm - Fix invalid memory access in cras_tm

BUG= chromium:690348 
TEST=None

Change-Id: I6cb889b19358014b5c8dd655c1ecb24bde2e6f91
Reviewed-on: https://chromium-review.googlesource.com/440047
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit 825b11343233267b67b15bbea7b399675036a824)
Reviewed-on: https://chromium-review.googlesource.com/441564
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/e7f76b3639a0183726aede6bff75470cbafcd394/cras/src/server/cras_tm.c

Comment 5 by hychao@chromium.org, Feb 13 2017

Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 14 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by hychao@chromium.org, Feb 15 2017

Labels: -Merge-Approved-57
Status: Verified (was: Fixed)
No more crashes are seen in M57 (Chrome OS 9202.43.0, 57.0.2987.85).  




Sign in to add a comment