New issue
Advanced search Search tips

Issue 690345 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"Reset settings" does not update synced DSE if extension with search is installed

Project Member Reported by a-...@yandex-team.ru, Feb 9 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3006.0 Safari/537.36

Steps to reproduce the problem:
(0) Login to your google account, to enable sync of chrome settings
(1) open chrome://settings 
(2) set Search engine to "Bing", then able to see "Bing" on New tab page
(3) install extension wich override default search engine - for example Yandex search https://chrome.google.com/webstore/detail/%D0%BF%D0%BE%D0%B8%D1%81%D0%BA-%D1%8F%D0%BD%D0%B4%D0%B5%D0%BA%D1%81a/laddjijkcfpakbbnnedbhnnciecidncp?utm_source=chrome-app-launcher-info-dialog
(4) make sure new tab opens with yandex page
(5)  open chrome://settings,  click on "Reset settings".  Then, "Google" is reset to default search engine on NTP/chrome://settings

What is the expected behavior?
Expect that google engine is propagated to sync and other devices.

What went wrong?
synced_guid in profile prefs still corresponds to search engine that user choose on step 2 (Bing)
Other devices will not receive google search engine with sync.

Did this work before? No 

Chrome version: 58.0.3006.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

Similar to
https://bugs.chromium.org/p/chromium/issues/detail?id=680197
Only with extension search engine and user search engine.

 
Labels: Needs-Triage-M58
I have created https://codereview.chromium.org/2659353002/ with fix for this problem.

Comment 3 by ajha@chromium.org, Mar 3 2017

Cc: a-...@yandex-team.ru ajha@chromium.org
Labels: -Needs-Triage-M58 TE-Verified-M58 TE-Verified-58.0.3028.0 M-58
Status: Untriaged (was: Unconfirmed)
Verified the fix on the latest canary(58.0.3028.0) of Windows-10. On reported version: 58.0.3006.0 even on syncing the profile it was still showing 'Bing' as the Search engine. Worked fine on 58.0.3028.0 and New tab shows Google as search engine.

Alexander@: Could you please confirm if this can be closed now.
Sounds like fixed.

Comment 5 by ajha@chromium.org, Mar 3 2017

Cc: pkasting@chromium.org
Status: Fixed (was: Untriaged)
Thanks for the quick update. Marking this as Fixed as per C#4.

Cc'ing Peter@ in case this needs to be merged. 
Can you please CC vasilii@chromium.org as well.
Cc: vasi...@chromium.org

Sign in to add a comment