New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690336 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Incorrect message is seen on clicking video call for hangouts.

Reported by lpa...@etouch.net, Feb 9 2017

Issue description

Chrome Version: 58.0.3007.0 (Official Build) 0e09de60e479fe2ee105fb731b403c729fce3ac1-refs/heads/master@{#449173} (32/64-bit)

OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12)

Steps to reproduce:
1. Launch chrome, Sign In, go to Hangouts form App launcher.
2. Click on Video Call and observe.

Actual Result: Displays "Something is wrong with you camera or microphone" message overlay.
Expected Result: Should display "Allow hangouts to use your Microphone".

This is regression issue broken in 'M 58' and will soon update the bisect info.

Manual Bisect Info: 
Good build:  58.0.3007.0
Bad build: 58.0.3006.0

 
Actual result.mp4
470 KB View Download
Expected result.mp4
422 KB View Download
Actual Result.png
34.8 KB View Download
Labels: hasbisect-per-revision OS-Linux
Owner: guidou@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue and below are the bisect details for the same:

Good build: 58.0.3006.0
Bad build: 58.0.3007.0

Bisect URL: https://chromium.googlesource.com/chromium/src/+log/81022874e21cac29a6d57ac820ef26f479700fc6..9ea409c2a23810063bb280304e18b48dc6b0fe7e

Change Log: https://chromium.googlesource.com/chromium/src/+/9ea409c2a23810063bb280304e18b48dc6b0fe7e

@ guidou: Assigning to you, kindly have a look into it. Please help us to find an owner if not with respect to your change.

Note: This issue is reproduced only on devices which do not have a camera and issue is also observed on Linux OS.





Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
I'll take a look.
The CL that causes the problem actually fixes non-spec compliant behavior.
According to spec, if the request cannot be satisfied (e.g., because there are no cameras), an error shoud be returned and no permission should be requested.
Before the CL, Chrome requested permission first, and checked devices and constraints later.
The problem is that hangouts is relying on the nonspec behavior.
I will prepare a patch that temporarily restores the old behavior in this case and file a bug with Hangouts.
@guidou : Gentle ping, do we have any update on this issue. 

Thanks.!

Comment 6 by guidou@chromium.org, Feb 16 2017

The Hangouts team will try to update Hangouts to handle the new more spec-compliant behavior of getUserMedia().

If they cannot do it on time, I have a patch (http://crrev.com/2683053004) that restores the nonstandard behavior Hangouts is currently relying on. However, I prefer to wait for their fix, since we have to be as spec-compliant as possible.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c726ced4178899d86c011f633ce793910dbec556

commit c726ced4178899d86c011f633ce793910dbec556
Author: guidou <guidou@chromium.org>
Date: Wed Feb 22 18:00:02 2017

Make getUserMedia() ask for permission if video constraints cannot be satisfied, except for the deviceID constraint.

This is nonstandard behavior, but Hangouts relies on it.
Will fix back once full spec-compliant constraint processing is
implemented.

BUG= 690336 

Review-Url: https://codereview.chromium.org/2683053004
Cr-Commit-Position: refs/heads/master@{#452122}

[modify] https://crrev.com/c726ced4178899d86c011f633ce793910dbec556/content/renderer/media/user_media_client_impl.cc

Comment 8 by guidou@chromium.org, Feb 23 2017

Status: Fixed (was: Assigned)
We decided to restore the old behavior in M58 and restore the standard behavior in M59, together with other spec-compliance changes.
Labels: TE-Verified-58.0.3025.5 TE-Verified-M58
Tested the issue on Windows-10, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3025.5 as per the comment #0.

Observed that the fix is working as expected.

Attaching the screen cast for reference.

Hence, adding the verified labels.

Thanks.
690336.mov
3.7 MB Download

Sign in to add a comment