Regression: Incorrect message is seen on clicking video call for hangouts.
Reported by
lpa...@etouch.net,
Feb 9 2017
|
||||
Issue descriptionChrome Version: 58.0.3007.0 (Official Build) 0e09de60e479fe2ee105fb731b403c729fce3ac1-refs/heads/master@{#449173} (32/64-bit) OS: Windows(7,8,8.1,10), Mac(10.11.6, 10.12.1, 10.12) Steps to reproduce: 1. Launch chrome, Sign In, go to Hangouts form App launcher. 2. Click on Video Call and observe. Actual Result: Displays "Something is wrong with you camera or microphone" message overlay. Expected Result: Should display "Allow hangouts to use your Microphone". This is regression issue broken in 'M 58' and will soon update the bisect info. Manual Bisect Info: Good build: 58.0.3007.0 Bad build: 58.0.3006.0
,
Feb 9 2017
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Feb 9 2017
I'll take a look.
,
Feb 9 2017
The CL that causes the problem actually fixes non-spec compliant behavior. According to spec, if the request cannot be satisfied (e.g., because there are no cameras), an error shoud be returned and no permission should be requested. Before the CL, Chrome requested permission first, and checked devices and constraints later. The problem is that hangouts is relying on the nonspec behavior. I will prepare a patch that temporarily restores the old behavior in this case and file a bug with Hangouts.
,
Feb 15 2017
@guidou : Gentle ping, do we have any update on this issue. Thanks.!
,
Feb 16 2017
The Hangouts team will try to update Hangouts to handle the new more spec-compliant behavior of getUserMedia(). If they cannot do it on time, I have a patch (http://crrev.com/2683053004) that restores the nonstandard behavior Hangouts is currently relying on. However, I prefer to wait for their fix, since we have to be as spec-compliant as possible.
,
Feb 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c726ced4178899d86c011f633ce793910dbec556 commit c726ced4178899d86c011f633ce793910dbec556 Author: guidou <guidou@chromium.org> Date: Wed Feb 22 18:00:02 2017 Make getUserMedia() ask for permission if video constraints cannot be satisfied, except for the deviceID constraint. This is nonstandard behavior, but Hangouts relies on it. Will fix back once full spec-compliant constraint processing is implemented. BUG= 690336 Review-Url: https://codereview.chromium.org/2683053004 Cr-Commit-Position: refs/heads/master@{#452122} [modify] https://crrev.com/c726ced4178899d86c011f633ce793910dbec556/content/renderer/media/user_media_client_impl.cc
,
Feb 23 2017
We decided to restore the old behavior in M58 and restore the standard behavior in M59, together with other spec-compliance changes.
,
Feb 28 2017
Tested the issue on Windows-10, Mac 10.12.2 and Linux Ubuntu-14.04 using Chrome version 58.0.3025.5 as per the comment #0. Observed that the fix is working as expected. Attaching the screen cast for reference. Hence, adding the verified labels. Thanks. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Feb 9 2017Owner: guidou@chromium.org
Status: Assigned (was: Unconfirmed)