Show type based thumbnails for all downloads except images. |
|||
Issue descriptionCurrently we show no thumbnails for downloads in Downloads section. It was decided in issue 631447 that we need to show thumbnails for all downloads as Downloads Home does. Issue 690332 is for image downloads.
,
Feb 9 2017
MimeType to filter conversion happens here https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java?type=cs&q=DownloadFilter&sq=package:chromium&l=103
,
Feb 9 2017
But images are not blue themselves https://cs.chromium.org/chromium/src/chrome/android/java/res/drawable-mdpi/ic_drive_site_white_24dp.png
,
Feb 9 2017
,
Feb 9 2017
The color is set here https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java?type=cs&q=Thumbnail+file:%5Esrc/chrome/android/java/src/org/chromium/chrome/browser/download/ui/+package:%5Echromium$&l=66 It is <color name="light_active_color">#4285F4</color>, which I confirmed by taking a screenshot.
,
Feb 9 2017
We need - R.drawable.ic_drive_file_white_24dp; - R.drawable.ic_drive_site_white_24dp; - R.drawable.ic_play_arrow_white_24dp; - R.drawable.ic_music_note_white_24dp; - R.drawable.ic_image_white_24dp; - R.drawable.ic_drive_text_white_24dp;
,
Feb 9 2017
After a discussion, we agreed to do it in Java instead. Reason: it is more like Android UI, i.e. this icons won't be used in iOS. dgn@ suggested to do it "in SnippetArticleViewHolder#onBindViewHolder, just getting the drawable the same way as we do in FilterAdapter#getView, instead of the regular thumbnail fetching mechanism".
,
Feb 13 2017
,
Feb 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/15b486bc4330fb7892946cca2ba60eaafc24cea6 commit 15b486bc4330fb7892946cca2ba60eaafc24cea6 Author: vitaliii <vitaliii@chromium.org> Date: Thu Feb 16 10:37:37 2017 [NTP::Downloads] Show thumbnails for Download suggestions. 1) Move some bits in DownloadItemView into functions and make them public, so that NTP can reuse them; 2) Copy DownloadItemView thumbnails behaviour for Download suggestions on the NTP: - for images show preview; - for other asset downloads show mimeType based icons; - for offline pages show specific icon; BUG= 690333 , 690332 Review-Url: https://codereview.chromium.org/2688383005 Cr-Commit-Position: refs/heads/master@{#450925} [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/res/layout/new_tab_page_snippets_card.xml [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java [modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/browser/ntp_snippets/download_suggestions_provider.cc
,
Feb 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vitaliii@chromium.org
, Feb 9 2017