New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690332 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 631447



Sign in to add a comment

Show thumbnails for downloaded images.

Project Member Reported by vitaliii@chromium.org, Feb 9 2017

Issue description

Currently we have no thumbnails for downloads. It was decided in issue 631447 that we need to show thumbnails for downloaded images.
 
Labels: zine-17-02-06
Status: Started (was: Assigned)
Labels: zine-17-02-13
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15b486bc4330fb7892946cca2ba60eaafc24cea6

commit 15b486bc4330fb7892946cca2ba60eaafc24cea6
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Feb 16 10:37:37 2017

[NTP::Downloads] Show thumbnails for Download suggestions.

1) Move some bits in DownloadItemView into functions and make them
public, so that NTP can reuse them;

2) Copy DownloadItemView thumbnails behaviour for Download suggestions
on the NTP:
  - for images show preview;
  - for other asset downloads show mimeType based icons;
  - for offline pages show specific icon;

BUG= 690333 , 690332 

Review-Url: https://codereview.chromium.org/2688383005
Cr-Commit-Position: refs/heads/master@{#450925}

[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadUtils.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadFilter.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticle.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/15b486bc4330fb7892946cca2ba60eaafc24cea6/chrome/browser/ntp_snippets/download_suggestions_provider.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f08de362f51a55b550c025e29c340e773e68ad5

commit 1f08de362f51a55b550c025e29c340e773e68ad5
Author: dgn <dgn@chromium.org>
Date: Thu Feb 16 20:16:15 2017

Android: Add VectorDrawable support to TintedImageView

Swapping an ImageView using a VectorDrawable with a TintedImageView
crashes on pre-L Android versions while working without issues on
other. This rebases TintedImageView on the appcompat version of
ImageView to be consistent with the one used in XML

BUG= 690332 

Review-Url: https://codereview.chromium.org/2701533004
Cr-Commit-Position: refs/heads/master@{#451077}

[modify] https://crrev.com/1f08de362f51a55b550c025e29c340e773e68ad5/chrome/android/java/src/org/chromium/chrome/browser/widget/TintedImageView.java

Status: Fixed (was: Started)

Sign in to add a comment