New issue
Advanced search Search tips

Issue 690323 link

Starred by 2 users
Status: Fixed
Owner:
rhalavati@chromium.org
Closed: Jul 13
Cc:
battre@chromium.org
msramek@chromium.org
asanka@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 750407
issue 844014


Sign in to add a comment

Tools to check serialized text of network traffic annotation

Project Member Reported by rhalavati@chromium.org, Feb 9 2017 
Network traffic annotation tag is added to network connection request functions and all call sites in Chromium would be gradually annotated.

Annotation is passed as a text serialize protobuf to a function to create NetworkTrafficAnnotationTag, but this function does not check the format of the annotation text.

Tools should be added to check this text's format and validate it.
Showing comments 14 - 113 of 113 Older ›
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13288b3acd7908f8c2c727af52c76fe553196f09

commit 13288b3acd7908f8c2c727af52c76fe553196f09
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Aug 17 08:17:50 2017

Adding more tests to network traffic annotation auditor.

The following tests are added to network traffic annotation auditor:
1- Unittest files should be annotated.
2- Each partial annotations and all its possible pairs create a complete
   annotation having all required fields.
3- Extra ids (for incomplete annotations) match required criteria for unique
   ids (character set, not colliding hash code, not reserved word).
4- Unittest for all above.

Bug:  656607 
Bug:  690323 
Change-Id: I2a585b07a3c88d26f460283ab5d986bd8c59dc7c
Reviewed-on: https://chromium-review.googlesource.com/575146
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495106}
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/BUILD.gn
[add] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/auditor_result.cc
[add] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/auditor_result.h
[add] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/instance.cc
[add] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/auditor/traffic_annotation_file_filter.h
[modify] https://crrev.com/13288b3acd7908f8c2c727af52c76fe553196f09/tools/traffic_annotation/traffic_annotation.proto
Project Member

Comment 15 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cf574af67d5695d2d74124f0e474540b6fa29b8

commit 5cf574af67d5695d2d74124f0e474540b6fa29b8
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Aug 18 12:25:08 2017

New patterns added to network traffic annotation extractor clang tool.

To test network traffic annotations throughly, we need to find all code sites
outside annotations API functions that directly assign a value to a tag,
either using list expression constructors or assigning value to internal
arguments of a mutable tag.

Bug:  656607 
Bug:  690323 
Change-Id: I05aa4fb8f8d670ed08c368858e0fa59e8975864b
Reviewed-on: https://chromium-review.googlesource.com/598848
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495529}
[modify] https://crrev.com/5cf574af67d5695d2d74124f0e474540b6fa29b8/tools/clang/traffic_annotation_extractor/README.md
[modify] https://crrev.com/5cf574af67d5695d2d74124f0e474540b6fa29b8/tools/clang/traffic_annotation_extractor/tests/test-expected.txt
[modify] https://crrev.com/5cf574af67d5695d2d74124f0e474540b6fa29b8/tools/clang/traffic_annotation_extractor/tests/test-original.cc
[modify] https://crrev.com/5cf574af67d5695d2d74124f0e474540b6fa29b8/tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp
[modify] https://crrev.com/5cf574af67d5695d2d74124f0e474540b6fa29b8/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c80e348e0bfea10337919ebc33df6597ed90b64

commit 9c80e348e0bfea10337919ebc33df6597ed90b64
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Aug 28 05:52:39 2017

Traffic annotation auditor detects wrong direct assignments.

Network traffic annotation auditor is updated to detect cases where a mutable
annotation is directly assigned (without proper API functions) or an annotation
is initialized using list expression.

Bug:  656607 
Bug:  690323 
Change-Id: I13ddd486f8adb20dbb99ff235bc8622ffee8f94b
Reviewed-on: https://chromium-review.googlesource.com/625997
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497700}
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/safe_list.txt
[add] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/tests/extractor_outputs/bad_assignment1.txt
[add] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/tests/extractor_outputs/bad_assignment2.txt
[add] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/tests/extractor_outputs/good_assignment.txt
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/9c80e348e0bfea10337919ebc33df6597ed90b64/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 17 by bugdroid1@chromium.org, Aug 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/863ea2c9035d3d625b908b8a267ac8f0690fd270

commit 863ea2c9035d3d625b908b8a267ac8f0690fd270
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Aug 28 14:37:29 2017

Windows incompatibility problems sovled for traffic annotation auditor.

The clang tool on Windows has some extra outputs that had to be ignored while
post processing them, and this extra output resulted in a big (>40M) file that
removing unnecessary carriage returns from it was very inefficient. Also
replacing 'gn' call with 'gn.bat' call on Windows makes the process much
faster.

Bug:  656607 
Bug:  690323 
Change-Id: I923fb6e52c95eecd1979a094160486c3218c0407
Reviewed-on: https://chromium-review.googlesource.com/637694
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#497756}
[modify] https://crrev.com/863ea2c9035d3d625b908b8a267ac8f0690fd270/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
Project Member

Comment 18 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9

commit 3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Sep 12 07:26:16 2017

Traffic annotation auditor and unittest updated.

The following changes were done:
 1- Auditor adds a list of OSes that actively use each annotation to
    annotations.xml, so that removing annotation from one OS and keeping
    it in another would not result in marking it deprecated.
 2- A script is added to tools/traffic_anntotation/scripts, to call all
    scripts that update a give file when annotations.xml is modified, or
    to run unittests that ensure these files are up to date.
 3- 'test-only' switch added to Auditor. When this switch is present,
    auditor only checks if annotations.xml is up to date and issues an
    error it if is not. When switch is not specified, annotations.xml
    may get updated and if so, the above mentioned script is called to
    update downstream files.
 4- Auditor will prevent use of deprecated unique ids.
 5- Unittest checks that annotations.xml is loadable and its content are
    valid.
 6- Unittest calls the script mentioned in (2) to test if downstream
    files are correctly updated.

Bug:  656607 
Bug:  690323 
Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7
Reviewed-on: https://chromium-review.googlesource.com/645088
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501206}
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[add] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/scripts/README.md
[add] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/scripts/annotations_xml_downstream_caller.py
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/summary/README.md
[modify] https://crrev.com/3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e104a64545c3506040150d0903a79efb3353e41

commit 7e104a64545c3506040150d0903a79efb3353e41
Author: Ben Wells <benwells@chromium.org>
Date: Tue Sep 12 07:45:16 2017

Revert "Traffic annotation auditor and unittest updated."

This reverts commit 3c6304c0f5a3744b06c4908fd21ced2a1a61a2f9.

Reason for revert: Doesn't compile on Mac.

Original change's description:
> Traffic annotation auditor and unittest updated.
> 
> The following changes were done:
>  1- Auditor adds a list of OSes that actively use each annotation to
>     annotations.xml, so that removing annotation from one OS and keeping
>     it in another would not result in marking it deprecated.
>  2- A script is added to tools/traffic_anntotation/scripts, to call all
>     scripts that update a give file when annotations.xml is modified, or
>     to run unittests that ensure these files are up to date.
>  3- 'test-only' switch added to Auditor. When this switch is present,
>     auditor only checks if annotations.xml is up to date and issues an
>     error it if is not. When switch is not specified, annotations.xml
>     may get updated and if so, the above mentioned script is called to
>     update downstream files.
>  4- Auditor will prevent use of deprecated unique ids.
>  5- Unittest checks that annotations.xml is loadable and its content are
>     valid.
>  6- Unittest calls the script mentioned in (2) to test if downstream
>     files are correctly updated.
> 
> Bug:  656607 
> Bug:  690323 
> Change-Id: I3cea4254dc4ff8bb2c31a8adc1ff5a7daf5006d7
> Reviewed-on: https://chromium-review.googlesource.com/645088
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#501206}

TBR=msramek@chromium.org,rhalavati@chromium.org

Change-Id: Id4c9b556ec5e93d7d5e4d0cd2bd60137811e663f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  656607 ,  690323 
Reviewed-on: https://chromium-review.googlesource.com/662503
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501210}
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[delete] https://crrev.com/0fc91f55cf308b433218986414d70150087da545/tools/traffic_annotation/scripts/README.md
[delete] https://crrev.com/0fc91f55cf308b433218986414d70150087da545/tools/traffic_annotation/scripts/annotations_xml_downstream_caller.py
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/summary/README.md
[modify] https://crrev.com/7e104a64545c3506040150d0903a79efb3353e41/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 20 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91f12c77f68c11c84f73a9d33eed823e028e8cfe

commit 91f12c77f68c11c84f73a9d33eed823e028e8cfe
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Sep 13 10:02:22 2017

Reland 'Traffic annotation auditor and unittest updated.'

The following changes were done:
 1- Auditor adds a list of OSes that actively use each annotation to
    annotations.xml, so that removing annotation from one OS and keeping
    it in another would not result in marking it deprecated.
 2- A script is added to tools/traffic_anntotation/scripts, to call all
    scripts that update a give file when annotations.xml is modified, or
    to run unittests that ensure these files are up to date.
 3- 'test-only' switch added to Auditor. When this switch is present,
    auditor only checks if annotations.xml is up to date and issues an
    error it if is not. When switch is not specified, annotations.xml
    may get updated and if so, the above mentioned script is called to
    update downstream files.
 4- Auditor will prevent use of deprecated unique ids.
 5- Unittest checks that annotations.xml is loadable and its content are
    valid.
 6- Unittest calls the script mentioned in (2) to test if downstream
    files are correctly updated.

Bug:  656607 
Bug:  690323 
Change-Id: I00acbddbe14eeee23317bb9990069e00558a5bb4
Reviewed-on: https://chromium-review.googlesource.com/645088
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501206}
Reviewed-on: https://chromium-review.googlesource.com/663724
Cr-Commit-Position: refs/heads/master@{#501584}
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[add] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/scripts/README.md
[add] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/scripts/annotations_xml_downstream_caller.py
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/summary/README.md
[modify] https://crrev.com/91f12c77f68c11c84f73a9d33eed823e028e8cfe/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e095db10c8125d183801c89d575b1aaaf77d07cd

commit e095db10c8125d183801c89d575b1aaaf77d07cd
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Sep 13 11:19:49 2017

Traffic annotation auditor updated to accept tool from arbitrary path.

Traffic annotation auditor would need to accept its clang tool from arbitrary
(non-default) path and is updated to accept a switch for this.

Bug:  656607 
Bug:  690323 
Change-Id: I071718f0410ecc636d71cbfc4fa9f18f9fcf1d19
Reviewed-on: https://chromium-review.googlesource.com/634908
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501592}
[modify] https://crrev.com/e095db10c8125d183801c89d575b1aaaf77d07cd/tools/clang/scripts/run_tool.py
[modify] https://crrev.com/e095db10c8125d183801c89d575b1aaaf77d07cd/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/e095db10c8125d183801c89d575b1aaaf77d07cd/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e095db10c8125d183801c89d575b1aaaf77d07cd/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/e095db10c8125d183801c89d575b1aaaf77d07cd/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c4d0c2338475c8ea1c1426472a8afa3fd82caed

commit 1c4d0c2338475c8ea1c1426472a8afa3fd82caed
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Sun Sep 24 17:42:13 2017

Bugs fixed in Network Traffic Annotation Auditor.

1. When an annotation was removed from a platform, os list was not updated
   for that item in annotaions.xml.
2. Constant FilePaths with separators resulted errors in Windows when
   Linux and Windows separators were mixed.

Bug:  656607 
Bug:  690323 
Change-Id: Id14a7680b1ab9d54aeb1bd1a8ff9081dfff51d28
Reviewed-on: https://chromium-review.googlesource.com/668447
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503959}
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/1c4d0c2338475c8ea1c1426472a8afa3fd82caed/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/099b747b3cfc0e1788e9997784d784b3380bb045

commit 099b747b3cfc0e1788e9997784d784b3380bb045
Author: Dirk Pranke <dpranke@chromium.org>
Date: Fri Oct 06 04:29:09 2017

Add a network traffic annotation presubmit checker.

We require every time Chromium talks to the network to be explainable.
In order to do this, we annotation functions that call out to the network.
This CL adds the tooling to ensure that all of the functions are correctly
annotated and that the annotations are syntactically correct and
semantically complete.

Bug:  690323 
Bug:  656607 
Change-Id: I3e5a8a3d753b70768dd42ad4aa880087a089b61d
Reviewed-on: https://chromium-review.googlesource.com/592721
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506965}
[modify] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/DEPS
[modify] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/testing/buildbot/chromium.linux.json
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/testing/scripts/check_network_annotations.py
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/tools/traffic_annotation/.gitignore
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/tools/traffic_annotation/README.md
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1
[add] https://crrev.com/099b747b3cfc0e1788e9997784d784b3380bb045/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0

commit 42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sat Oct 07 03:03:06 2017

Rev traffic_annotation binaries.

This CL updates the newly added traffic-annotation checker binaries,
and updates the docs to make sure the instructions for how to create
the binaries and how to disable the tests are clear(er).

R=thakis@chromium.org, rhalavati@chromium.org, msramek@chromium.org
BUG= 656607 ,  690323 

Change-Id: I44bcf406796c89f192a4f47b26d65e8bad4dabec
Reviewed-on: https://chromium-review.googlesource.com/705922
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507271}
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/testing/buildbot/trybot_analyze_config.json
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/testing/scripts/check_network_annotations.py
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/tools/traffic_annotation/README.md
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1
[modify] https://crrev.com/42c2ee855758cb36a59b7c5ae6ebbbab9b032ca0/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 25 by bugdroid1@chromium.org, Oct 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bee77a591083e06d5fed71d094418bcb2baecb8

commit 4bee77a591083e06d5fed71d094418bcb2baecb8
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Oct 13 09:35:29 2017

More error log added network traffic annotation auditor.

More detailed log of errors added to network traffic annotation auditor
when it fails to call clang tool.

Bug:  656607 
Bug:  690323 
Change-Id: Ic8a64c6991b86c07e27622db2400c4bb01e8905a
Reviewed-on: https://chromium-review.googlesource.com/708256
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508656}
[modify] https://crrev.com/4bee77a591083e06d5fed71d094418bcb2baecb8/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/4bee77a591083e06d5fed71d094418bcb2baecb8/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 26 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb64f98baf46886c5eead51365eab181cfa443a4

commit eb64f98baf46886c5eead51365eab181cfa443a4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 19 10:51:38 2017

Bug fixed in Network Traffic Annotation Auditor.

Network Traffic Annotation Auditor switches current directory to source
before calling 'tools/clang/scripts/run_tool.py' as the script expects
to be run from there.

Bug:  656607 
Bug:  690323 
Change-Id: I5eeb872281b6966a341d159260c6037cba73aa99
Reviewed-on: https://chromium-review.googlesource.com/727881
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510050}
[modify] https://crrev.com/eb64f98baf46886c5eead51365eab181cfa443a4/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
Project Member

Comment 27 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/239da85259ab7ac922ff8948def3b5c66a7f1d36

commit 239da85259ab7ac922ff8948def3b5c66a7f1d36
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Oct 20 06:31:57 2017

Roll traffic_annotation checkers

Updating network traffic annotation auditor to have mode debug data.

Bug:656607
Bug:690323
Change-Id: I0c3d5cd9acedf864ed53a27662fb6ed55e6f60d7

TBR=dpranke

Change-Id: I0c3d5cd9acedf864ed53a27662fb6ed55e6f60d7
Reviewed-on: https://chromium-review.googlesource.com/730003
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510359}
[modify] https://crrev.com/239da85259ab7ac922ff8948def3b5c66a7f1d36/tools/traffic_annotation/README.md
[modify] https://crrev.com/239da85259ab7ac922ff8948def3b5c66a7f1d36/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 28 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e290f176907c293600367f527f936edb186cf4a6

commit e290f176907c293600367f527f936edb186cf4a6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 09:39:59 2017

Annotation.xml update mechanism and errors updated.

Traffic annotation auditor was updated as follows:
1- If a new annotation is found, it is added to annotations.xml for all
   supported platforms, to minimize the need to run the auditor on all
   platforms to updated os_list.
2- If annotation.xml requires updates and it is run in test mode, the
   list of updates are added to output errors.

Bug:  656607 
Bug:  690323 
Change-Id: Icbdceddfc9a3e31cf9be397e19b002597119bb61
Reviewed-on: https://chromium-review.googlesource.com/730687
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511773}
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/README.md
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/auditor_result.h
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff12.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff13.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_diff23.txt
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample1.xml
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample2.xml
[add] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/tests/annotations_sample3.xml
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[modify] https://crrev.com/e290f176907c293600367f527f936edb186cf4a6/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 29 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88e484114f5dd5b8ac8d085e44f733228d848fa4

commit 88e484114f5dd5b8ac8d085e44f733228d848fa4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 11:41:28 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

TBR=dpranke

Bug:  690323 
Change-Id: I096b583a4579073da2038111bb15a22d54abf2ba
Reviewed-on: https://chromium-review.googlesource.com/738377
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511788}
[modify] https://crrev.com/88e484114f5dd5b8ac8d085e44f733228d848fa4/tools/traffic_annotation/README.md
[modify] https://crrev.com/88e484114f5dd5b8ac8d085e44f733228d848fa4/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f66cdd604fcd9274770160a6671f47840dea5c2c

commit f66cdd604fcd9274770160a6671f47840dea5c2c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Oct 26 12:29:02 2017

Network Traffic Annotation Auditor's TSV output updated.

The TSV output of Network Traffic Annotation Auditor creates links to
CodeSearch for file paths, instead of just file paths.

Bug:  656607 
Bug:  690323 
Change-Id: I53c659f713eea5a21d83d223fd96892657c15310
Reviewed-on: https://chromium-review.googlesource.com/739142
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511793}
[modify] https://crrev.com/f66cdd604fcd9274770160a6671f47840dea5c2c/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5bdc63d43b762556d8f70d131a1e427ff50e8c4

commit f5bdc63d43b762556d8f70d131a1e427ff50e8c4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Oct 27 05:38:07 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

Bug:690323
Change-Id: I21f621cf4292bca036b7d4c46db5604a29eabb63

TBR=dpranke@chromium.org

Change-Id: I21f621cf4292bca036b7d4c46db5604a29eabb63
Reviewed-on: https://chromium-review.googlesource.com/741222
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512097}
[modify] https://crrev.com/f5bdc63d43b762556d8f70d131a1e427ff50e8c4/tools/traffic_annotation/README.md
[modify] https://crrev.com/f5bdc63d43b762556d8f70d131a1e427ff50e8c4/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f600d602309799c09356d1cf4545a293448f18f

commit 7f600d602309799c09356d1cf4545a293448f18f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Oct 27 07:43:06 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

Bug:690323
Change-Id: I3a73a52246dc742a1c932019760ece4a831bebbb

TBR=dpranke@chromium.org

Change-Id: I3a73a52246dc742a1c932019760ece4a831bebbb
Reviewed-on: https://chromium-review.googlesource.com/741227
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512119}
[modify] https://crrev.com/7f600d602309799c09356d1cf4545a293448f18f/tools/traffic_annotation/README.md
[modify] https://crrev.com/7f600d602309799c09356d1cf4545a293448f18f/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 33 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0793e6f78baf52fbe21e0e554756f1c9f86e754

commit f0793e6f78baf52fbe21e0e554756f1c9f86e754
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Nov 02 10:08:31 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

Bug:690323
Change-Id: Ifc62287f88e1bb6ac9b3293b1723b7d0aa171066

TBR=dpranke

Change-Id: Ifc62287f88e1bb6ac9b3293b1723b7d0aa171066
Reviewed-on: https://chromium-review.googlesource.com/750084
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513444}
[modify] https://crrev.com/f0793e6f78baf52fbe21e0e554756f1c9f86e754/tools/traffic_annotation/README.md
[modify] https://crrev.com/f0793e6f78baf52fbe21e0e554756f1c9f86e754/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 34 by bugdroid1@chromium.org, Nov 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0061e2423f0d8d440d9b87b6c4b4161eecc67a

commit 0e0061e2423f0d8d440d9b87b6c4b4161eecc67a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Nov 02 13:53:08 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

Bug:690323
Change-Id: Ib8fd3798338e171afb6aadcb547e0e92c8b9a96a

TBR=dpranke

Change-Id: Ib8fd3798338e171afb6aadcb547e0e92c8b9a96a
Reviewed-on: https://chromium-review.googlesource.com/749810
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513478}
[modify] https://crrev.com/0e0061e2423f0d8d440d9b87b6c4b4161eecc67a/tools/traffic_annotation/README.md
[modify] https://crrev.com/0e0061e2423f0d8d440d9b87b6c4b4161eecc67a/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c17b3ce68dd7b012f52c2c0e0607c8345dd10d0f

commit c17b3ce68dd7b012f52c2c0e0607c8345dd10d0f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Nov 03 10:06:18 2017

Roll traffic_annotation checkers

Network traffic annotation's binary is updated to the latest version.

Bug:690323
Change-Id: Icf4adb04d36f2b39d84b467830f5a51536829468

TBR=dpranke

Change-Id: Icf4adb04d36f2b39d84b467830f5a51536829468
Reviewed-on: https://chromium-review.googlesource.com/753090
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513733}
[modify] https://crrev.com/c17b3ce68dd7b012f52c2c0e0607c8345dd10d0f/tools/traffic_annotation/README.md
[modify] https://crrev.com/c17b3ce68dd7b012f52c2c0e0607c8345dd10d0f/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d267d4638a525cbff6b5c41124005ab4cc6c8fe3

commit d267d4638a525cbff6b5c41124005ab4cc6c8fe3
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Nov 03 15:19:09 2017

Roll traffic_annotation checkers

Network traffic annotation's auditor and extractor binaries are updated
to the latest version.

Bug:690323
Change-Id: I18ebfd212ab99889370109f69b3992c9ea9745ed

TBR=dpranke

Change-Id: I18ebfd212ab99889370109f69b3992c9ea9745ed
Reviewed-on: https://chromium-review.googlesource.com/753366
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513779}
[modify] https://crrev.com/d267d4638a525cbff6b5c41124005ab4cc6c8fe3/tools/traffic_annotation/README.md
[modify] https://crrev.com/d267d4638a525cbff6b5c41124005ab4cc6c8fe3/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/d267d4638a525cbff6b5c41124005ab4cc6c8fe3/tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7e55d99e5d4567684e7caa83a81500938eda17e

commit b7e55d99e5d4567684e7caa83a81500938eda17e
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Nov 21 08:00:57 2017

Adding a traffic annotation presubmit checker for Windows.

To provide transparency on Chromium's requests to the network, we add
network traffic annotations to all functions that call out to the
network.
This CL adds the tooling required on Windows to ensure that all of the
functions are correctly annotated and the annotations are syntactically
correct and semantically complete.

Bug:  690323 
Bug:  656607 
Change-Id: I56ca754cf320db62cacf954c8e0bc64db2ce301a
Reviewed-on: https://chromium-review.googlesource.com/779139
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518173}
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/DEPS
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/testing/buildbot/chromium.win.json
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/.gitignore
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/README.md
[add] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[add] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1
[modify] https://crrev.com/b7e55d99e5d4567684e7caa83a81500938eda17e/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 39 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e247e4076e4539bd15874f59ec264c500b1ebca2

commit e247e4076e4539bd15874f59ec264c500b1ebca2
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Nov 24 13:05:17 2017

Adding a switch to traffic annotation auditor to use compile_commands.

Traffic annotation auditor uses git to extract the list of files that
need auditing. This will fail if build switches are used that modify
files (like jumbo). This CL adds a switch that forces auditor to use
compile_commands.json instead of git to extract files list.
The CL also disables the test on annotations.xml if auditor is not run
on the complete repository and path filters are provided.

Bug:  656607 
Bug:  690323 
Change-Id: I7b206798623bdfbf3611a982e7d97e8369b901d8
Reviewed-on: https://chromium-review.googlesource.com/789031
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519095}
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e247e4076e4539bd15874f59ec264c500b1ebca2/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 40 by bugdroid1@chromium.org, Dec 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/956ce4c30ce4af4d003fcbfb54212e1239accf4c

commit 956ce4c30ce4af4d003fcbfb54212e1239accf4c
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Dec 07 10:04:09 2017

Add temporary annotation tag to auditor.

A temporary network traffic annotation tag is added to be used during
refactoring of the socket classes. Network Traffic Annotation Auditor
is updated to add this tag to reserved words and ignore it in tests.

Bug:  690323 
Change-Id: I79f570ced37a8572b6f495de478d18d998dc4189
Reviewed-on: https://chromium-review.googlesource.com/813674
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522391}
[modify] https://crrev.com/956ce4c30ce4af4d003fcbfb54212e1239accf4c/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/956ce4c30ce4af4d003fcbfb54212e1239accf4c/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/956ce4c30ce4af4d003fcbfb54212e1239accf4c/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
Project Member

Comment 41 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36e99a557191d54179c546cc9fdcd323508a2365

commit 36e99a557191d54179c546cc9fdcd323508a2365
Author: rhalavati@google.com <rhalavati@google.com>
Date: Mon Jan 08 09:15:08 2018

Activate Network traffic annotation tests for Linux trybot.

Traffic annotation tests are updated to run on the changed files instead
of the whole repository, which should make tests much faster.

Bug:  690323 
Bug:  788035 
Change-Id: Ie67c1abe02d2f1670e1d5c0b4491682157f390c1
Reviewed-on: https://chromium-review.googlesource.com/842403
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527588}
[modify] https://crrev.com/36e99a557191d54179c546cc9fdcd323508a2365/tools/traffic_annotation/README.md
[modify] https://crrev.com/36e99a557191d54179c546cc9fdcd323508a2365/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/36e99a557191d54179c546cc9fdcd323508a2365/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 42 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96de83c487be35a0ca3d55be03198a6bebc4a7f7

commit 96de83c487be35a0ca3d55be03198a6bebc4a7f7
Author: John Abd-El-Malek <jam@chromium.org>
Date: Mon Jan 08 15:30:21 2018

Revert "Activate Network traffic annotation tests for Linux trybot."

This reverts commit 36e99a557191d54179c546cc9fdcd323508a2365.

Lots of failures on CQ like this:
Running ['/usr/bin/python', '/b/c/b/linux/src/tools/traffic_annotation/scripts/check_annotations.py', '--build-path', u'/b/c/b/linux/src/out/Release'] in None (env: None)
[Errors]
  (1)	'tools/traffic_annotation/summary/annotations.xml' requires update. It is recommended to run traffic_annotation_auditor locally to do the updates automatically (please refer to tools/traffic_annotation/auditor/README.md), but you can also apply the following edit(s) to do it manually:
	Update line: ' <item id="download_web_contents_frame" hash_code="56351037" type="0" content_hash_code="3657889" os_list="linux,windows" file_path="content/browser/web_contents/web_contents_impl.cc"/>' --> ' <item id="download_web_contents_frame" hash_code="56351037" type="0" content_hash_code="3657889" os_list="windows" file_path="content/browser/web_contents/web_contents_impl.cc"/>'
 If you are using build flags that modify files (like jumbo), rerun the auditor using --all-files switch.
Command ['/usr/bin/python', '/b/c/b/linux/src/tools/traffic_annotation/scripts/check_annotations.py', '--build-path', u'/b/c/b/linux/src/out/Release'] returned exit code 1
step returned non-zero exit code: 1

Original change's description:
> Activate Network traffic annotation tests for Linux trybot.
> 
> Traffic annotation tests are updated to run on the changed files instead
> of the whole repository, which should make tests much faster.
> 
> Bug:  690323 
> Bug:  788035 
> Change-Id: Ie67c1abe02d2f1670e1d5c0b4491682157f390c1
> Reviewed-on: https://chromium-review.googlesource.com/842403
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#527588}

TBR=dpranke@chromium.org,msramek@chromium.org,rhalavati@chromium.org

Change-Id: If2a8b71463dcfd4d298a125925d64877a78e6c86
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  690323 ,  788035 
Reviewed-on: https://chromium-review.googlesource.com/854073
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527637}
[modify] https://crrev.com/96de83c487be35a0ca3d55be03198a6bebc4a7f7/tools/traffic_annotation/README.md
[modify] https://crrev.com/96de83c487be35a0ca3d55be03198a6bebc4a7f7/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/96de83c487be35a0ca3d55be03198a6bebc4a7f7/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 43 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba2f602f5979b220e7ff94cbed7904c1138182e

commit 6ba2f602f5979b220e7ff94cbed7904c1138182e
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 09 14:26:41 2018

Update traffic annotation auditor to run tests on partial repository.

Network traffic annotation auditor is updated to be able to run all
tests on a partial subset of the repository.

Bug:  690323 
Bug:  656607 
Change-Id: If9a97e14de116530b3fb05f5e27f2b4e2d41e871
Reviewed-on: https://chromium-review.googlesource.com/839600
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527985}
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_id_checker.cc
[modify] https://crrev.com/6ba2f602f5979b220e7ff94cbed7904c1138182e/tools/traffic_annotation/auditor/traffic_annotation_id_checker.h
Project Member

Comment 44 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1009ad76d789cd118c778fc85019445025a4c7c8

commit 1009ad76d789cd118c778fc85019445025a4c7c8
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 09 14:46:10 2018

Update annotation auditor TSV output.

Annotation auditor's TSV output is updated:
 1- An empty line with just unique id is added for every annotation that
    belongs to other platforms.
 2- Incomplete annotations are not reported in the TSV file.
 3- A comment is added for merged annotations stating the partial
    annotations used to make them.

Bug:  656607 
Bug:  690323 
Change-Id: I9168e9d537e5bc4aca0b89636c778f869c0b6fd3
Reviewed-on: https://chromium-review.googlesource.com/842642
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527988}
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/1009ad76d789cd118c778fc85019445025a4c7c8/tools/traffic_annotation/auditor/traffic_annotation_exporter.h
Project Member

Comment 45 by bugdroid1@chromium.org, Jan 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f

commit 86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f
Author: rhalavati@google.com <rhalavati@google.com>
Date: Thu Jan 11 07:01:55 2018

Activate Network traffic annotation tests for Linux trybot.

Traffic annotation tests are updated to run on the changed files instead
of the whole repository, which should make tests much faster.

Bug:  690323 
Bug:  788035 
Change-Id: I4eb7c173f5d677cdb9944f02e9c15dfa0a374b10
Reviewed-on: https://chromium-review.googlesource.com/856456
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528573}
[modify] https://crrev.com/86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f/tools/traffic_annotation/README.md
[modify] https://crrev.com/86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 46 by bugdroid1@chromium.org, Jan 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5

commit 3efb8443e8e9475ab0fa600fb594d0aa6168a6c5
Author: rhalavati@google.com <rhalavati@google.com>
Date: Fri Jan 12 16:14:36 2018

Make network traffic annotation auditor error resilient.

A switch is added to network traffic annotation auditor to avoid
returning error, if there would be an operational error preventing it
from actual testing. This '--error-resilient' switch will be used on
the trybot to avoid spamming when the test cannot be run.

Auditor is also updated to return no error (even without the new
switch) if the given path filters do not include any relevant file.

Bug:  690323 
Bug:  801192 
Change-Id: I4aa3172c356d6daa9403c8a0b5447cefe2141f5c
Reviewed-on: https://chromium-review.googlesource.com/863483
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528959}
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/README.md
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/3efb8443e8e9475ab0fa600fb594d0aa6168a6c5/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 47 by bugdroid1@chromium.org, Jan 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27

commit 5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27
Author: rhalavati@google.com <rhalavati@google.com>
Date: Tue Jan 16 07:44:29 2018

Fix traffic annotation auditor's summary error for policies.

Traffic annotation auditor didn't write the policy fields of partial
annotations in annotations.xml. This could result in extra errors, when
two partial annotations were tested and the data was fetched fron the
annotations.xml instead of actual files.

TBR=msramek

Bug:  690323 
Change-Id: I1ce14f500cb4cbb181ba4283756c9e475a95527d
Reviewed-on: https://chromium-review.googlesource.com/866835
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529374}
[modify] https://crrev.com/5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27/tools/traffic_annotation/README.md
[modify] https://crrev.com/5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/5c06a257f2c37b1d2d4e1b42e35f22a5d53aed27/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 48 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25ae0312619fff32d4f91e67589d1deb810daf9a

commit 25ae0312619fff32d4f91e67589d1deb810daf9a
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Thu Jan 18 09:48:09 2018

Update traffic annotation auditor's file path archiving.

The following issues are updated in traffic annotation auditor:
 1- If an annotation is moved from one file to another, annotations.xml
    is updated to reflect that.
 2- If an annotation gets deprecated, its file path and field details
    are removed from annotations.xml.

Bug:  690323 
Change-Id: I491f0dff3c5e036092982a7e2d28f02df84c2bbb
Reviewed-on: https://chromium-review.googlesource.com/873030
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530102}
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/README.md
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/auditor/traffic_annotation_exporter.cc
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/25ae0312619fff32d4f91e67589d1deb810daf9a/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 49 by bugdroid1@chromium.org, Jan 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06c8cabd79fe69845f11220b370c9b332618517a

commit 06c8cabd79fe69845f11220b370c9b332618517a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Jan 22 09:34:30 2018

Update traffic annotation auditor on Windows.

Network traffic annotation auditor is updated to pass '-Wno-comment'
switch to clang tool, so that the clang tool does not consider
multi-line comments as errors.

tools/clang/script/run_tool.py is updated to accept more than one
argument as 'tool-args' and pass them to the clang tool.

Bug:  656607 
Bug:  690323 
Change-Id: I2b0e662ac94ef362cdab5aa8498fa7fce97d40d3
Reviewed-on: https://chromium-review.googlesource.com/870321
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530827}
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/clang/scripts/run_tool.py
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/README.md
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/06c8cabd79fe69845f11220b370c9b332618517a/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 50 by bugdroid1@chromium.org, Jan 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1418dc6b23af3d29c0b203980cdb2df1e07ca8a4

commit 1418dc6b23af3d29c0b203980cdb2df1e07ca8a4
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Jan 24 08:02:34 2018

Update traffic annotation check for renamed files.

tools/traffic_annotation/scripts/check_annotations.py gets the list of
changed files from git. '--no-renames' is added to ensure that both the
former name and the new name of renamed files are passed to the tests.

Bug:  690323 
Change-Id: I6f4256f12786e07f1fcffa7145634b94f94dfb49
Reviewed-on: https://chromium-review.googlesource.com/878119
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531477}
[modify] https://crrev.com/1418dc6b23af3d29c0b203980cdb2df1e07ca8a4/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 51 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0e6d654fcdae192825324c811798a63dff0ae9

commit 0e0e6d654fcdae192825324c811798a63dff0ae9
Author: John Abd-El-Malek <jam@chromium.org>
Date: Tue Jan 30 03:11:20 2018

Revert "Activate Network traffic annotation tests for Linux trybot."

This reverts commit 86ff9bc4d831eebf5c0f0b0a04214d1b28e50c3f.

Reason for revert:
flaky, i.e. see

https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634904
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634934
https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_chromium_rel_ng/634954

which fail with
Returned error text: Traceback (most recent call last):
  File "/b/c/b/linux/src/tools/clang/scripts/run_tool.py", line 315, in <module>
    sys.exit(main())
  File "/b/c/b/linux/src/tools/clang/scripts/run_tool.py", line 281, in main
    f.write(compile_db.GenerateWithNinja(args.p))
  File "/b/c/b/linux/src/tools/clang/pylib/clang/compile_db.py", line 94, in GenerateWithNinja
    GetNinjaPath(), '-C', path, '-t', 'compdb', 'cc', 'cxx', 'objc',
  File "/b/c/b/linux/src/tools/clang/pylib/clang/compile_db.py", line 76, in GetNinjaPath
    os.path.dirname(os.realpath(__file__)), '..', '..', '..', 'third_party',
AttributeError: 'module' object has no attribute 'realpath'




Original change's description:
> Activate Network traffic annotation tests for Linux trybot.
>
> Traffic annotation tests are updated to run on the changed files instead
> of the whole repository, which should make tests much faster.
>
> Bug:  690323 
> Bug:  788035 
> Change-Id: I4eb7c173f5d677cdb9944f02e9c15dfa0a374b10
> Reviewed-on: https://chromium-review.googlesource.com/856456
> Reviewed-by: Martin Šrámek <msramek@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#528573}

TBR=dpranke@chromium.org,msramek@chromium.org,rhalavati@chromium.org


Bug:  690323 ,  788035 
Change-Id: I048be491eb64c221bb4edeab2e0d2aa051b5faa7
Reviewed-on: https://chromium-review.googlesource.com/892383
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532741}
[modify] https://crrev.com/0e0e6d654fcdae192825324c811798a63dff0ae9/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 52 by bugdroid1@chromium.org, Jan 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b695a4881858d817c41ef3bb242c8d4a39805cf0

commit b695a4881858d817c41ef3bb242c8d4a39805cf0
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Jan 30 10:33:57 2018

Fix error sensitivity in traffic annotation presubmit check.

Network traffic annotations presubmit check returned an error if there
was run-time errors.
This was not an intended behavior as in error resilient mode, there
might be some run time errors that will not block the CL from landing.
The script is updated to return the exit code that auditor returns in
all cases.

Bug:  690323 
Bug:  807146 
Change-Id: Ic5a34511a78a3607b5e2071b267180236e88f358
Reviewed-on: https://chromium-review.googlesource.com/892858
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532829}
[modify] https://crrev.com/b695a4881858d817c41ef3bb242c8d4a39805cf0/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 53 by bugdroid1@chromium.org, Jan 31 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f66d3495f4f9836548d5262bf47a3f959dc4caaf

commit f66d3495f4f9836548d5262bf47a3f959dc4caaf
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Jan 31 06:36:54 2018

Activate Network Traffic Annotations trybot test on Linux.

After fixing the following two files, the trybot test on Linux are
reactivated:
'tools/clang/pylib/clang/compile_db.py'
'tools/traffic_annotation/scripts/check_annotations.py'

Bug:  690323 
Bug:  807146 
Change-Id: Id769e4bb4e5d416eb04e2436d38cec5af04606ec
Reviewed-on: https://chromium-review.googlesource.com/891960
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533218}
[modify] https://crrev.com/f66d3495f4f9836548d5262bf47a3f959dc4caaf/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 54 by bugdroid1@chromium.org, Feb 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4478d1139e6721470d093cf0902f6acaf38a4f75

commit 4478d1139e6721470d093cf0902f6acaf38a4f75
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 01 06:33:52 2018

Update annotation test executables for Windows.

A bug is fixed in DEPS to download traffic annotation test executables
on Windows, and the executables are updated.

Bug:  690323 
Change-Id: I0fca767d012f8bad37e0d38bc337aa9442b38a97
Reviewed-on: https://chromium-review.googlesource.com/895593
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533596}
[modify] https://crrev.com/4478d1139e6721470d093cf0902f6acaf38a4f75/DEPS
[modify] https://crrev.com/4478d1139e6721470d093cf0902f6acaf38a4f75/tools/traffic_annotation/README.md
[modify] https://crrev.com/4478d1139e6721470d093cf0902f6acaf38a4f75/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[modify] https://crrev.com/4478d1139e6721470d093cf0902f6acaf38a4f75/tools/traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1
Project Member

Comment 55 by bugdroid1@chromium.org, Feb 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/783e48a9b8535f189fb27e9c55d78699dfb79910

commit 783e48a9b8535f189fb27e9c55d78699dfb79910
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 05 09:22:22 2018

Update traffic annotation checker executables.

Executable files of traffic_annotation_auditor for Linux and Windows
are updated.

Bug:  690323 
Change-Id: I24443057255d4c77016197a2a758ae41293439cb
Reviewed-on: https://chromium-review.googlesource.com/898922
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534353}
[modify] https://crrev.com/783e48a9b8535f189fb27e9c55d78699dfb79910/tools/traffic_annotation/README.md
[modify] https://crrev.com/783e48a9b8535f189fb27e9c55d78699dfb79910/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/783e48a9b8535f189fb27e9c55d78699dfb79910/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 56 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f39567c5a2f3a0b80de2d661bebbbc67184e77d

commit 8f39567c5a2f3a0b80de2d661bebbbc67184e77d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 08 08:08:24 2018

Add ASM parser to traffic_annotation_extractor.

Two required initializers are added to traffic annotation extractor
clang tool to comply with Windows needs.

Bug:  690323 
Change-Id: I893a4424314d7afd25d34759357c33f72c4919fb
Reviewed-on: https://chromium-review.googlesource.com/904984
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535331}
[modify] https://crrev.com/8f39567c5a2f3a0b80de2d661bebbbc67184e77d/tools/clang/traffic_annotation_extractor/CMakeLists.txt
[modify] https://crrev.com/8f39567c5a2f3a0b80de2d661bebbbc67184e77d/tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp
Project Member

Comment 57 by bugdroid1@chromium.org, Feb 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2748389a0dad8944d14ac6b504e44d5fd065d40f

commit 2748389a0dad8944d14ac6b504e44d5fd065d40f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Feb 08 11:35:35 2018

Roll traffic annotation extractor clang tool executable.

Traffic annotation extractor is updated in crrev.com/c/904984.
This CL updates its executable for Windows and Linux.

Bug:  690323 
Change-Id: I8ed514e570c882a7e1e160b3737ffadc7be9cdd4
Reviewed-on: https://chromium-review.googlesource.com/906343
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535356}
[modify] https://crrev.com/2748389a0dad8944d14ac6b504e44d5fd065d40f/tools/traffic_annotation/README.md
[modify] https://crrev.com/2748389a0dad8944d14ac6b504e44d5fd065d40f/tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1
[modify] https://crrev.com/2748389a0dad8944d14ac6b504e44d5fd065d40f/tools/traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1
Project Member

Comment 58 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293dda88c38e3eb03b68d2548662be72e2a16322

commit 293dda88c38e3eb03b68d2548662be72e2a16322
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 09 05:44:41 2018

Update traffic annotation tests outputs.

Traffic annotation auditor did not return error if downstream scripts
silently failed to run the clang tool.
This CL fixes this issue and performs two minor output updates.

Bug:  690323 
Change-Id: Id1cf963dc64cdd72039683db50a1716555815dcc
Reviewed-on: https://chromium-review.googlesource.com/908460
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535655}
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/README.md
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[modify] https://crrev.com/293dda88c38e3eb03b68d2548662be72e2a16322/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 59 by bugdroid1@chromium.org, Feb 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce1dbb2de90624ef7594b144c1a0f0ba2e3b226b

commit ce1dbb2de90624ef7594b144c1a0f0ba2e3b226b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 09 05:46:18 2018

Update check_annotations.py.

Two minor fixes in check_annotations.py:
 1- Inserting system executable for Windows is not required when an
    executable is called.
 2- Potential path to src folder is updated.

Bug:  690323 
Change-Id: Iadef6bc6199dbd895f3b9da518bc967406091c25
Reviewed-on: https://chromium-review.googlesource.com/908749
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535656}
[modify] https://crrev.com/ce1dbb2de90624ef7594b144c1a0f0ba2e3b226b/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 60 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05fd879e9597c3423e8f82388d42a8b21b5d8317

commit 05fd879e9597c3423e8f82388d42a8b21b5d8317
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 08:23:38 2018

Add Serialize() function to traffic annotation auditor.

Serialize function for text output of annotations is added to
traffic_annotation_auditor for debugging purposes.
Also two small updates in output and documentation are done.

Bug:  690323 
Change-Id: I35ab3381a116dde685f283982b378c6549ce8a90
Reviewed-on: https://chromium-review.googlesource.com/916196
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536677}
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/README.md
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/auditor/README.md
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/auditor/instance.h
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/05fd879e9597c3423e8f82388d42a8b21b5d8317/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 61 by bugdroid1@chromium.org, Feb 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e457e948b1408b9e5e42e4636793001b513fb4bc

commit e457e948b1408b9e5e42e4636793001b513fb4bc
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 14 20:27:43 2018

Roll Trafic Annotation Auditor excutable for Windows.

Traffic annotation auditor's executable is rolled for Windows.

Bug:  690323 
Change-Id: I5038d56fce1efa11d98786790d6ba874495bedc3
Reviewed-on: https://chromium-review.googlesource.com/918561
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536800}
[modify] https://crrev.com/e457e948b1408b9e5e42e4636793001b513fb4bc/tools/traffic_annotation/README.md
[modify] https://crrev.com/e457e948b1408b9e5e42e4636793001b513fb4bc/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 62 by bugdroid1@chromium.org, Feb 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd

commit 9eb4cb3d58201337f51bc46ab23ecf4a85da29bd
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 16 12:46:54 2018

Make Network Traffic Annotation Auditor more error resilient.

Network Traffic Annotation Auditor adds the following switch when
calling the clang tool: '-Wno-tautological-unsigned-enum-zero-compare'

Also to be faster, auditor does not rerun the clang tool to get errors
when called in error resilient mode.

Bug:  690323 
Change-Id: Ie099b902395da5c4bb9526925d71b6dd4b94c290
Reviewed-on: https://chromium-review.googlesource.com/924061
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537290}
[modify] https://crrev.com/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd/tools/traffic_annotation/README.md
[modify] https://crrev.com/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/9eb4cb3d58201337f51bc46ab23ecf4a85da29bd/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 63 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c2653d070028ae8456173a2708cebe4204b82c

commit 46c2653d070028ae8456173a2708cebe4204b82c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 19 06:09:52 2018

Add more strict filter for tests to traffic annotation auditor.

Traffic annotation auditor file filter is expanded to ignore all files
that end with test.cc or test.mm.

Bug:  690323 
Change-Id: Iac0eb5aca403f4fa40b6b81dd85a46c317fd6684
Reviewed-on: https://chromium-review.googlesource.com/924062
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537585}
[modify] https://crrev.com/46c2653d070028ae8456173a2708cebe4204b82c/tools/traffic_annotation/README.md
[modify] https://crrev.com/46c2653d070028ae8456173a2708cebe4204b82c/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc
[modify] https://crrev.com/46c2653d070028ae8456173a2708cebe4204b82c/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 64 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de6d8dbbed9ca67bce6bd81e16d652dc11dc9a6c

commit de6d8dbbed9ca67bce6bd81e16d652dc11dc9a6c
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 19 09:20:07 2018

Activate annotation tests to remoting.

'remoting/client' and 'remoting/host' are added to the set of targets
that network traffic annotation tests are activated for them.

Bug:  690323 
Change-Id: I415cf930df8d788437ac48ba5bfb2bcef925a4ab
Reviewed-on: https://chromium-review.googlesource.com/888618
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537610}
[modify] https://crrev.com/de6d8dbbed9ca67bce6bd81e16d652dc11dc9a6c/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/de6d8dbbed9ca67bce6bd81e16d652dc11dc9a6c/testing/buildbot/manage.py
[modify] https://crrev.com/de6d8dbbed9ca67bce6bd81e16d652dc11dc9a6c/testing/scripts/check_network_annotations.py
Project Member

Comment 65 by bugdroid1@chromium.org, Feb 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/292623794361f3efcb35581b4ec95badd610dbc6

commit 292623794361f3efcb35581b4ec95badd610dbc6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Feb 19 10:17:53 2018

Update traffic annotation auditor executable for Windows.

Following patchsets crrev.com/c/924061 and crrev.com/c/924062, SHA1 for
traffic annotation auditor executable for Windows is updated.

Bug:  690323 
Change-Id: Ic6112c60ea6d98c16bffcd596b669d69df8d1d3b
Reviewed-on: https://chromium-review.googlesource.com/924004
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537618}
[modify] https://crrev.com/292623794361f3efcb35581b4ec95badd610dbc6/tools/traffic_annotation/README.md
[modify] https://crrev.com/292623794361f3efcb35581b4ec95badd610dbc6/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 66 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a538a15ff8a7e8a152365465b256ec2f254f50fa

commit a538a15ff8a7e8a152365465b256ec2f254f50fa
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 21 11:36:02 2018

Improve traffic annotation auditor's TSV output.

Possible extra trailing space in cloud policy serialization of annotations
removed.

Bug:  690323 
Change-Id: Ibdc0b485abfccddf4c1023095903e74e5c5fe52a
Reviewed-on: https://chromium-review.googlesource.com/928501
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538065}
[modify] https://crrev.com/a538a15ff8a7e8a152365465b256ec2f254f50fa/tools/traffic_annotation/README.md
[modify] https://crrev.com/a538a15ff8a7e8a152365465b256ec2f254f50fa/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/a538a15ff8a7e8a152365465b256ec2f254f50fa/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
Project Member

Comment 67 by bugdroid1@chromium.org, Feb 21 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/378204c26f8a1a679a0bc0375c399e4fab7bb7af

commit 378204c26f8a1a679a0bc0375c399e4fab7bb7af
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 21 18:47:27 2018

Test removed from Network traffic annotation unittest.

Traffic annotation auditor unittests are updated not to check for clang
tool. This is done to make test available on swarming bots.
The test will be included in the end-to-end tests on the FYI bot.

Bug:  789768 
Bug:  690323 
Change-Id: I580ac0eee164efeb0347d890fe7dda5c5388f15c
Reviewed-on: https://chromium-review.googlesource.com/926125
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538164}
[modify] https://crrev.com/378204c26f8a1a679a0bc0375c399e4fab7bb7af/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/378204c26f8a1a679a0bc0375c399e4fab7bb7af/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
Project Member

Comment 68 by bugdroid1@chromium.org, Feb 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/779a8e035025c76ee76bf11f8dc7aa95ebb56c9a

commit 779a8e035025c76ee76bf11f8dc7aa95ebb56c9a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Feb 23 07:16:41 2018

Filter required files before running clang tool on Windows.

Compile commands on Windows need updating before clang tools run on
them. This process is slow as the compile commands file is quite large.
This CL filters the compile commands file to only include the required
items, and then updates the remaining for the clang tools.

Bug:  690323 
Change-Id: I9cf45018afb47a3fbf67a05e5e0ab16de575de76
Reviewed-on: https://chromium-review.googlesource.com/921222
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538721}
[modify] https://crrev.com/779a8e035025c76ee76bf11f8dc7aa95ebb56c9a/tools/clang/pylib/clang/compile_db.py
[modify] https://crrev.com/779a8e035025c76ee76bf11f8dc7aa95ebb56c9a/tools/clang/scripts/run_tool.py
Project Member

Comment 69 by bugdroid1@chromium.org, Feb 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f468224ace2193f820b8526496e67bbb1622198

commit 6f468224ace2193f820b8526496e67bbb1622198
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Sat Feb 24 06:52:23 2018

Activate network traffic annotation tests on Windows trybot.

Network traffic annotation test on win7_chromium_rel_ng is activated.

Bug:  690323 
Change-Id: Ic3dcba34e9898b7a4f71067f5531db1952f19c9a
Reviewed-on: https://chromium-review.googlesource.com/781461
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539000}
[modify] https://crrev.com/6f468224ace2193f820b8526496e67bbb1622198/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 70 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/173f75777d45a86c285140580dd295035c1c8d66

commit 173f75777d45a86c285140580dd295035c1c8d66
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Feb 28 05:08:15 2018

Add 'no-missing-error' switch to network traffic annotation auditor.

An optional 'no-missing-error' switch is added to Network Traffic
Annotation Auditor.
If provided, auditor would not issue error in cases that an annotation
is missing. This would be useful on platforms that still do not fully
cover annotations and auditor is just run to check existing ones.

Bug:  690323 
Change-Id: I5b74d5c86b12c1a85fdeaba7bc71381c6b6451dc
Reviewed-on: https://chromium-review.googlesource.com/930761
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539715}
[modify] https://crrev.com/173f75777d45a86c285140580dd295035c1c8d66/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 71 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4421cf2e589df7212f1787f8d795e3d5b766281d

commit 4421cf2e589df7212f1787f8d795e3d5b766281d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 02 06:11:41 2018

Add Full Repository Test to  Traffic Annotation FYI Bot.

linux-annotator-rel FYI bot passes 'end-to-end' switch to
check_network_annotations.py to initiate a test on the whole repository
instead of just the changed files.

Bug:  690323 
Change-Id: I1e14db0cb3c770d31515b70a3d46983d32af0996
Reviewed-on: https://chromium-review.googlesource.com/942887
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540463}
[modify] https://crrev.com/4421cf2e589df7212f1787f8d795e3d5b766281d/testing/buildbot/waterfalls.pyl
[modify] https://crrev.com/4421cf2e589df7212f1787f8d795e3d5b766281d/testing/scripts/check_network_annotations.py
Project Member

Comment 72 by bugdroid1@chromium.org, Mar 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30102c05cc7d5d046d31e2b1b16c44574bf65329

commit 30102c05cc7d5d046d31e2b1b16c44574bf65329
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon Mar 05 17:57:27 2018

Update traffic annotation auditor to check annotations.xml format.

Traffic annotation auditor is updated to check annotations.xml's format
regardless of data modification. This is done to ensure that manual
updates to the XML comply with the XML generator format and next CLs
won't be spammed because of a format nit.

Bug:  690323 
Change-Id: I605d4e1e012aaaccad9c78b706058e524f97efbc
Reviewed-on: https://chromium-review.googlesource.com/946190
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540864}
[modify] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/30102c05cc7d5d046d31e2b1b16c44574bf65329/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 73 by bugdroid1@chromium.org, Mar 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f597d37e1774c9c9588162c7bf63cf40887f96b6

commit f597d37e1774c9c9588162c7bf63cf40887f96b6
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Mar 06 07:04:35 2018

Roll traffic annotation auditor's executable.

Traffic annotation auditor's executable is rolled for Linux and Windows.

Bug:690323
Change-Id: Ic56b8c1f28c0d9fee59ffe6c5949dfc5f77a9b90

TBR=msramek

Change-Id: Ic56b8c1f28c0d9fee59ffe6c5949dfc5f77a9b90
Reviewed-on: https://chromium-review.googlesource.com/950662
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541050}
[modify] https://crrev.com/f597d37e1774c9c9588162c7bf63cf40887f96b6/tools/traffic_annotation/README.md
[modify] https://crrev.com/f597d37e1774c9c9588162c7bf63cf40887f96b6/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/f597d37e1774c9c9588162c7bf63cf40887f96b6/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 74 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2418cebbda28730b811d71aa97894ad13427abdb

commit 2418cebbda28730b811d71aa97894ad13427abdb
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 08 08:53:26 2018

Add traffic annotation self tests.

A script is added to check network traffic annotation tests. Common
parts of this script and the former annotation checker are separated
as annotation_tools.py.

Bug:  690323 
Change-Id: If712cca4359a98549318fafe80d64b651765d800
Reviewed-on: https://chromium-review.googlesource.com/951255
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541755}
[modify] https://crrev.com/2418cebbda28730b811d71aa97894ad13427abdb/tools/traffic_annotation/scripts/README.md
[add] https://crrev.com/2418cebbda28730b811d71aa97894ad13427abdb/tools/traffic_annotation/scripts/annotation_tools.py
[modify] https://crrev.com/2418cebbda28730b811d71aa97894ad13427abdb/tools/traffic_annotation/scripts/check_annotations.py
[add] https://crrev.com/2418cebbda28730b811d71aa97894ad13427abdb/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 75 by bugdroid1@chromium.org, Mar 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61eb267d400f1b4816e0d91e0a4bd86bd417b26d

commit 61eb267d400f1b4816e0d91e0a4bd86bd417b26d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Sun Mar 11 09:54:14 2018

Fix tools/clang/scripts/run_tool.py

Bug fixed which resulted in run_tool.py crash, when a path was given
which could cover the last file in the repository, such as './'.

Bug:  690323 
Change-Id: I01e767b73d7c768283a868933d40ac209453c3de
Reviewed-on: https://chromium-review.googlesource.com/955644
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542397}
[modify] https://crrev.com/61eb267d400f1b4816e0d91e0a4bd86bd417b26d/tools/clang/scripts/run_tool.py
Project Member

Comment 76 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a99710924811a33149748d5d9d09f289af477704

commit a99710924811a33149748d5d9d09f289af477704
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Mar 14 06:48:40 2018

Change Traffic Annotation FYI bot's script.

The script that traffic annotations FYI bot runs is changed to a new one
that specifically checks network traffic annotation auditor's health.

Bug:  690323 
Change-Id: Iaa97d5ce27b2b9f9d2c523deae7fda803ffb5079
Reviewed-on: https://chromium-review.googlesource.com/955688
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543020}
[modify] https://crrev.com/a99710924811a33149748d5d9d09f289af477704/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a99710924811a33149748d5d9d09f289af477704/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/a99710924811a33149748d5d9d09f289af477704/testing/buildbot/waterfalls.pyl
[add] https://crrev.com/a99710924811a33149748d5d9d09f289af477704/testing/scripts/check_network_annotation_auditor.py
[modify] https://crrev.com/a99710924811a33149748d5d9d09f289af477704/testing/scripts/check_network_annotations.py
Project Member

Comment 77 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b4123d2925da8f4cbb397c372a2e113de339d23

commit 2b4123d2925da8f4cbb397c372a2e113de339d23
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Mar 14 09:40:04 2018

Disable network traffic annotation FYI bot.

The bot seems to have no access to gen folder. This is required as some
files have includes from gen folder.
Disabling it for investigation.

TBR=msramek

Bug:  690323 
Change-Id: I378a0c7f0c1a5fb3571bd66cb49acf2140fc80cc
Reviewed-on: https://chromium-review.googlesource.com/962061
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543039}
[modify] https://crrev.com/2b4123d2925da8f4cbb397c372a2e113de339d23/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 78 by bugdroid1@chromium.org, Mar 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c41351d3b0c10939bf880c9f61a0d16679a4d94

commit 4c41351d3b0c10939bf880c9f61a0d16679a4d94
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Mar 14 10:24:57 2018

Add clang tool switch to traffic annotation auditor.

A switch is added to clang tool calls from traffic annotation auditor,
to ignore constant comparisons.
Some tests compare constants to prevent future regressions, but clang
sees these as unnecessary comparisons and issues error.

Bug:  690323 
Change-Id: Iaa194641f2d6a8cd66ae61f514703bccc28967da
Reviewed-on: https://chromium-review.googlesource.com/958518
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543045}
[modify] https://crrev.com/4c41351d3b0c10939bf880c9f61a0d16679a4d94/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
Project Member

Comment 79 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce8d748877753a6ffa860aff839b6a2889132844

commit ce8d748877753a6ffa860aff839b6a2889132844
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 15 09:41:03 2018

Update traffic annotations.xml.

Updating annotations.xml is requested before landing any CL that changes
an annotation. To do the tests fast on trybots, only .mm and .cc files
are checked. Also the tests do not cover ChromeOS and ios specifc code.

This annotation has been moved to ChromeOS specific code by a build file
change, hence gone unnoticed by the trybots. This is a typical case that
the FYI bot gets the problem and fires an error for manual update of
annotations.xml

Annotation is marked deprecated as we still do not support ChromeOS in
annotations.xml.

Bug:  690323 
Change-Id: Iab001e8916c3da7e97f68e9dfc67b42017d4f658
Reviewed-on: https://chromium-review.googlesource.com/962764
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543331}
[modify] https://crrev.com/ce8d748877753a6ffa860aff839b6a2889132844/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 80 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbe0767929ef56aeb6fc2ab537837cde217139de

commit bbe0767929ef56aeb6fc2ab537837cde217139de
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 15 10:38:13 2018

Roll traffic annotation auditor's executables.

Traffic annotation auditor new executables are rolled for Linux and
Windows.

Bug:  690323 
Change-Id: Ibbfa8868736b4cbe6fd101ecf93fbf15626832f0
Reviewed-on: https://chromium-review.googlesource.com/963323
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543338}
[modify] https://crrev.com/bbe0767929ef56aeb6fc2ab537837cde217139de/tools/traffic_annotation/README.md
[modify] https://crrev.com/bbe0767929ef56aeb6fc2ab537837cde217139de/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/bbe0767929ef56aeb6fc2ab537837cde217139de/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 81 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e81170d2478fc54b9113d1310524983be33f7a53

commit e81170d2478fc54b9113d1310524983be33f7a53
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Mar 15 16:32:57 2018

Add wildcard and test sensitivity to trafic annotation auditor.

Traffic annotation auditor checks that test annotationa are only used in
test files with whitelisted keywords in file path.
File path white list checking is updated to accept wildcards.

Bug:  690323 
Change-Id: I5ccde0bb3d449fa75667bf1b293bd533fdfcd2c0
Reviewed-on: https://chromium-review.googlesource.com/947945
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543399}
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/net/traffic_annotation/network_traffic_annotation_test_helper.h
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/BUILD.gn
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/DEPS
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/auditor_result.cc
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/instance.cc
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/safe_list.txt
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/e81170d2478fc54b9113d1310524983be33f7a53/tools/traffic_annotation/auditor/traffic_annotation_file_filter.cc
Project Member

Comment 82 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40947715076253709d5908677babb752184b1c3d

commit 40947715076253709d5908677babb752184b1c3d
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 10:21:33 2018

Roll traffic annotation auditor.

Traffic annotation auditor's binaries for Linux and Windows are rolled.
TBR=msramek

Bug:  690323 
Change-Id: Ib313528d8605805c05d09aa9fd17ad83f1e1220a
Reviewed-on: https://chromium-review.googlesource.com/966182
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543661}
[modify] https://crrev.com/40947715076253709d5908677babb752184b1c3d/tools/traffic_annotation/README.md
[modify] https://crrev.com/40947715076253709d5908677babb752184b1c3d/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/40947715076253709d5908677babb752184b1c3d/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
Project Member

Comment 83 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bea452cef8cd89ebf50409b96d59a70fe373e52

commit 5bea452cef8cd89ebf50409b96d59a70fe373e52
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 15:19:38 2018

Add debug data for Traffic Annotation FYI bot.

Traffic annotations FYI bot cannot access some files in build_path/gen.
Some Debug data is added to find out why?

TBR=msramek

Bug:  690323 
Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732
Reviewed-on: https://chromium-review.googlesource.com/966303
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543702}
[modify] https://crrev.com/5bea452cef8cd89ebf50409b96d59a70fe373e52/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 84 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4676523093f095d4142f87da6ade66e2160bc124

commit 4676523093f095d4142f87da6ade66e2160bc124
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Mar 16 17:17:45 2018

Revert "Add debug data for Traffic Annotation FYI bot."

This reverts commit 5bea452cef8cd89ebf50409b96d59a70fe373e52.

Reason for revert: This CL was for collecting debug data on FYI bot.
Data is now collected.

Original change's description:
> Add debug data for Traffic Annotation FYI bot.
> 
> Traffic annotations FYI bot cannot access some files in build_path/gen.
> Some Debug data is added to find out why?
> 
> TBR=msramek
> 
> Bug:  690323 
> Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732
> Reviewed-on: https://chromium-review.googlesource.com/966303
> Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
> Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#543702}

TBR=msramek@chromium.org,rhalavati@chromium.org

Change-Id: Ia3c53a938c1f19122e4b82ca77b357502feaeb89
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  690323 
Reviewed-on: https://chromium-review.googlesource.com/966762
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543741}
[modify] https://crrev.com/4676523093f095d4142f87da6ade66e2160bc124/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 85 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20a0254e21c0f82275674b59d4df2e3cfb943f83

commit 20a0254e21c0f82275674b59d4df2e3cfb943f83
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Apr 04 14:45:27 2018

Add clang switch to traffic annotation auditor.

A new switch is add to traffic annotation auditor's call to clang tool,
to ignore uknown switches and do not stop on them. This is done as a
quick fix to reactivate traffic annotation auditor's tests and will be
updated to a more presistant approach after discussing with clang team.

Bug:  690323 
Change-Id: If350a83b2d70003a2600f9ad84d774a049a9f532
Reviewed-on: https://chromium-review.googlesource.com/995132
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548054}
[modify] https://crrev.com/20a0254e21c0f82275674b59d4df2e3cfb943f83/tools/traffic_annotation/README.md
[modify] https://crrev.com/20a0254e21c0f82275674b59d4df2e3cfb943f83/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/20a0254e21c0f82275674b59d4df2e3cfb943f83/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/20a0254e21c0f82275674b59d4df2e3cfb943f83/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[modify] https://crrev.com/20a0254e21c0f82275674b59d4df2e3cfb943f83/tools/traffic_annotation/summary/annotations.xml
Project Member

Comment 86 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6261f4316888edcb6905845fe5e0963f278232f

commit b6261f4316888edcb6905845fe5e0963f278232f
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Apr 05 16:15:22 2018

Move traffic annotation auditor's clang tool switches to a text file.

Switches that are passed from traffic annotation auditor to clang tool
are moved from source to a text file for easier update.

Bug:  690323 
Change-Id: Icb1fbfdfde6898532158bb3c9ee0e4710a3e043b
Reviewed-on: https://chromium-review.googlesource.com/997738
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548442}
[modify] https://crrev.com/b6261f4316888edcb6905845fe5e0963f278232f/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/b6261f4316888edcb6905845fe5e0963f278232f/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[add] https://crrev.com/b6261f4316888edcb6905845fe5e0963f278232f/tools/traffic_annotation/auditor/traffic_annotation_extractor_switches.txt
Project Member

Comment 87 by bugdroid1@chromium.org, Apr 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb3644e148cab56f289d6bda9663d22ddaea7de

commit 5fb3644e148cab56f289d6bda9663d22ddaea7de
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 06 05:24:42 2018

Update traffic annotation auditor.

Fix traffic annotation auditor bug, when no path filter was provided and
--no-filtering switch was passed, no file was processed.

Bug:  690323 
Change-Id: I0235a4c30cf985cf68d7f05080c64bc26f4a29d8
Reviewed-on: https://chromium-review.googlesource.com/958503
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548679}
[modify] https://crrev.com/5fb3644e148cab56f289d6bda9663d22ddaea7de/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
Project Member

Comment 90 by bugdroid1@chromium.org, Apr 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9461cf2bbfa653b911f8f0ae07776080c6652482

commit 9461cf2bbfa653b911f8f0ae07776080c6652482
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue Apr 17 11:37:11 2018

Update network traffic annotation auditor tests.

Tests are added to compare outputs of traffic_annotation_auditor using
different parameters.

Bug:  690323 
Change-Id: I69bc0234310020e2e92ecdd25c90f543f9b99459
Reviewed-on: https://chromium-review.googlesource.com/960143
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551298}
[modify] https://crrev.com/9461cf2bbfa653b911f8f0ae07776080c6652482/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 91 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5637d2fe8db0946df22af98db25f8ad8c783697e

commit 5637d2fe8db0946df22af98db25f8ad8c783697e
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Apr 18 07:56:56 2018

Update traffic annotation auditor tester.

Traffic annotation auditor's tester on FYI bot is updated to return more
gracefull output if auditor cannot produce any result.

Bug:  690323 
Change-Id: If39c0cf092010c43d4c8a5b26a786172ba3cf937
TBR: msramek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1015901
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551609}
[modify] https://crrev.com/5637d2fe8db0946df22af98db25f8ad8c783697e/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 92 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc77a6b60b19353d7d39f361fba8bbd0d6fccff3

commit bc77a6b60b19353d7d39f361fba8bbd0d6fccff3
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Apr 18 12:01:14 2018

Update traffic annotation tester.

Order of tests in auditor tester are changed to provide more debug
data.

Bug:  690323 
Change-Id: If17d5cb4a159b34b21a7b07b86ce181e165c9998
TBR: msramek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1016288
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551638}
[modify] https://crrev.com/bc77a6b60b19353d7d39f361fba8bbd0d6fccff3/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 93 by bugdroid1@chromium.org, Apr 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396164ee41bf7317ac1faa6ee24715a8b7dd9ae8

commit 396164ee41bf7317ac1faa6ee24715a8b7dd9ae8
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed Apr 18 17:09:06 2018

Update traffic annotation auditor's test build targets and output.

Build targets for traffic annotation auditor's tests are expanded to
cover all required generated files.
The test result is corrected.

Bug:  690323 
Change-Id: Iefb2e61fda12e34aa85879da73f1f174baa56c38
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1016901
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551724}
[modify] https://crrev.com/396164ee41bf7317ac1faa6ee24715a8b7dd9ae8/testing/scripts/check_network_annotation_auditor.py
[modify] https://crrev.com/396164ee41bf7317ac1faa6ee24715a8b7dd9ae8/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 94 by bugdroid1@chromium.org, Apr 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ffe35cc0d46b3f12651592499391da81dfcbb52

commit 1ffe35cc0d46b3f12651592499391da81dfcbb52
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Apr 19 08:37:27 2018

Update traffic annotation auditor's test script.

A new test is activated for traffic annotation auditor's test on FYI bot
which checks if the test is runnable on the whole repository without any
heuristic filters.

Bug:  690323 
Change-Id: Ide0e815b5cd78b688f230eda04ba781ad13bbf6d
TBR: msramek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1018464
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551968}
[modify] https://crrev.com/1ffe35cc0d46b3f12651592499391da81dfcbb52/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 95 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e01424a93f256f17cef4bff2e008376f08adf63

commit 8e01424a93f256f17cef4bff2e008376f08adf63
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 20 05:29:14 2018

Add errors-file switch to traffic annotation auditor.

Adds a new switch to traffic annotation auditor to specify a file to
dump errors.

Bug:  690323 
Change-Id: I72cb86867191bddb42497909830062170453e495
Reviewed-on: https://chromium-review.googlesource.com/1019303
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552266}
[modify] https://crrev.com/8e01424a93f256f17cef4bff2e008376f08adf63/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/8e01424a93f256f17cef4bff2e008376f08adf63/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/8e01424a93f256f17cef4bff2e008376f08adf63/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 96 by bugdroid1@chromium.org, Apr 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a58cb9c42aadecf15d36f1a0636f244d19b1727

commit 4a58cb9c42aadecf15d36f1a0636f244d19b1727
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 20 12:21:00 2018

Disable one test in auditor testers.

Unfiltered test in traffic annotation auditor's test script on trybot is
disabled.

Bug:  690323 
Change-Id: I42eb6a8681690f351d23ef9fe5cb7778da6bd014
Reviewed-on: https://chromium-review.googlesource.com/1021220
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552308}
[modify] https://crrev.com/4a58cb9c42aadecf15d36f1a0636f244d19b1727/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 98 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1621e54dd424f9ac217591fd69fc9bf91d1c30e7

commit 1621e54dd424f9ac217591fd69fc9bf91d1c30e7
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Tue Apr 24 08:02:22 2018

Update traffic annotation extractor.

Traffic annotation extractor clang tool is updated to return the
expansion path of the macros for returned elements.

Bug:  690323 
Change-Id: I2fe33a42bfcbf0e19bcbf798ecb7a9690e53d020
Reviewed-on: https://chromium-review.googlesource.com/1023399
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553028}
[modify] https://crrev.com/1621e54dd424f9ac217591fd69fc9bf91d1c30e7/tools/clang/traffic_annotation_extractor/tests/test-expected.txt
[modify] https://crrev.com/1621e54dd424f9ac217591fd69fc9bf91d1c30e7/tools/clang/traffic_annotation_extractor/tests/test-original.cc
[modify] https://crrev.com/1621e54dd424f9ac217591fd69fc9bf91d1c30e7/tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp
Project Member

Comment 99 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35995ac311b854019e576648b30b87604464501

commit b35995ac311b854019e576648b30b87604464501
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 27 07:33:02 2018

Update traffic annotation auditor.

Traffic annotation auditor is updated as follows:
 1- It ignores clang tool's errors if the tool has been able to produce
    outputs. This is done because we might pass files to clang tool
    that belong to other platforms, and the tool's errors on these
    files should not prevent processing of the other returned results.
 2- safe_list.txt is updated and all tests are excluded.
 3- A bug in usage of safe listed exception type ALL is fixed. If a
    file that is in safe list type ALL is processed by the clang tool,
    its outputs are ignored when clang tool results are parsed.

Bug:  690323 
Change-Id: I61334f2bc5170bc04b399439daac6f6b6f20bc0a
Reviewed-on: https://chromium-review.googlesource.com/1024010
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554334}
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/auditor/safe_list.txt
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/bin/README.md
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/bin/linux64/traffic_annotation_extractor.sha1
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/bin/win32/traffic_annotation_auditor.exe.sha1
[modify] https://crrev.com/b35995ac311b854019e576648b30b87604464501/tools/traffic_annotation/bin/win32/traffic_annotation_extractor.exe.sha1
Project Member

Comment 100 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/572855c69d770b4d5bc42acef12cda655390d569

commit 572855c69d770b4d5bc42acef12cda655390d569
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri Apr 27 11:02:35 2018

Activate test on traffic annotation FYI bot.

Running with no filter test is activated on traffic annotation auditor
FYIbot.

Bug:  690323 
Change-Id: I13c8c3eda25d8203fee2412fa6160db56515b139
Reviewed-on: https://chromium-review.googlesource.com/1026731
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554354}
[modify] https://crrev.com/572855c69d770b4d5bc42acef12cda655390d569/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py
Project Member

Comment 101 by bugdroid1@chromium.org, May 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126f89615d87f545ac273ec0ca5a9c1e82bf7e49

commit 126f89615d87f545ac273ec0ca5a9c1e82bf7e49
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed May 02 07:21:26 2018

Increate traffic annotation FYI bot's time out.

Network traffic annotation's FYI bot time out is increased to 4hrs to
comply with the unfiltered tests.

Bug:  690323 
Change-Id: I1d96b693e062d702ba0a018c3512f380f10d9ecd
TBR: dpranke@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1039184
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555324}
[modify] https://crrev.com/126f89615d87f545ac273ec0ca5a9c1e82bf7e49/testing/buildbot/test_suites.pyl
Project Member

Comment 102 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d65877e97e50871dea74af9125e4552aa2ae81a

commit 9d65877e97e50871dea74af9125e4552aa2ae81a
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu May 03 04:37:20 2018

Expand annotation tests to all targets.

Network traffic annotation tests on trybots are triggered only if Chrome
or remoting targets are modified. In cases that a file out of this
scope, like in components, is modified, the test is not triggered and
annotation changes miss tests.

The test scope is expanded to all targets. It is expected that this
does not have any negative speed effect as traffic annotation tests
prefilter files that do not include any annotations.

Bug:  690323 
Change-Id: Iaa771443a40285c4b547b5e3c15f26f6cb61457e
Reviewed-on: https://chromium-review.googlesource.com/1030270
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555666}
[modify] https://crrev.com/9d65877e97e50871dea74af9125e4552aa2ae81a/testing/scripts/check_network_annotations.py
Project Member

Comment 103 by bugdroid1@chromium.org, May 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b47ef5be5a873a4c06e2f301f57af3810749466

commit 6b47ef5be5a873a4c06e2f301f57af3810749466
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri May 04 04:27:46 2018

Increase io timeout of traffic annotation tests.

IO time out of network traffic annotation tests on the FYI bot is
increased. One of the tests takes a considerably long time to make an
output and needs to stay alive to do so.

Bug:  690323 
Change-Id: Iae8384aaea46d48ad9d584b8747d1a576cec9fe1
Reviewed-on: https://chromium-review.googlesource.com/1042287
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555981}
[modify] https://crrev.com/6b47ef5be5a873a4c06e2f301f57af3810749466/testing/buildbot/test_suites.pyl
Project Member

Comment 104 by bugdroid1@chromium.org, May 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16d9ea8fc7f52b8ace64c1dafe6d77bcc0d155d

commit f16d9ea8fc7f52b8ace64c1dafe6d77bcc0d155d
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Mon May 07 07:14:18 2018

Remove extra patterns from Traffic Annotation Extractor.

Socket patterns are no longer required in traffic annotation tests,
hence they are removed from traffic_annotation_extractor clang tool.

The original plan was to have network traffic annotation as an optional
argument of socket create functions, and we needed to check if the
argument existed for all calls that originate from Chrome. This is now
changed to having annotations as a mandatory argument of the socket
write functions, and as it is enforced by the compiler, we do not need
to test it.

Bug:  690323 
Change-Id: I101fb7295662c3488807091cb9a8686cfc87d249
Reviewed-on: https://chromium-review.googlesource.com/1046087
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556388}
[modify] https://crrev.com/f16d9ea8fc7f52b8ace64c1dafe6d77bcc0d155d/tools/clang/traffic_annotation_extractor/traffic_annotation_extractor.cpp
Project Member

Comment 105 by bugdroid1@chromium.org, May 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f28913f4f24fcffbe6a8ec0452034392f6b0e6b

commit 8f28913f4f24fcffbe6a8ec0452034392f6b0e6b
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Tue May 08 05:22:43 2018

Remove unnecessary socket tests from traffic_annotation_auditor.

Network traffic annotation is added to sockets write functions and hence
their create functions do not need to be tested in traffic annotation
tests anymore. Hence unnecessary code is removed from
traffic_annotation_auditor.

Bug:  690323 
Change-Id: I70676ea7dab9f1db3a6d5c3625d85dda6ddc8a11
Reviewed-on: https://chromium-review.googlesource.com/1046166
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556697}
[modify] https://crrev.com/8f28913f4f24fcffbe6a8ec0452034392f6b0e6b/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/8f28913f4f24fcffbe6a8ec0452034392f6b0e6b/tools/traffic_annotation/auditor/traffic_annotation_auditor_unittest.cc
Project Member

Comment 107 by bugdroid1@chromium.org, May 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3e1c143da13a37a641839334df9cfad6bba89b2

commit a3e1c143da13a37a641839334df9cfad6bba89b2
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Wed May 09 05:07:56 2018

Update traffic_annotation_auditor to accept absolute files.

The latest update of traffic_annotation_extractor clang tool returns
absolute file paths in the reports instead of relative ones, and this
breaks safe list checking.
traffic_annotation_auditor is updated to convert the received file
paths from absolute to relative (based on source folder) so that safe
list checking would run.

Bug:  690323 
Change-Id: Iea610f6e3371923f4d1d9c19bd030cf859b8ac44
Reviewed-on: https://chromium-review.googlesource.com/1049547
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557099}
[modify] https://crrev.com/a3e1c143da13a37a641839334df9cfad6bba89b2/tools/traffic_annotation/auditor/auditor_result.h
[modify] https://crrev.com/a3e1c143da13a37a641839334df9cfad6bba89b2/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/a3e1c143da13a37a641839334df9cfad6bba89b2/tools/traffic_annotation/auditor/traffic_annotation_auditor.h
[modify] https://crrev.com/a3e1c143da13a37a641839334df9cfad6bba89b2/tools/traffic_annotation/auditor/traffic_annotation_auditor_ui.cc
Project Member

Comment 108 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ebfed4cb2784625cbcccb588dc7e7bd9c87c9eb

commit 5ebfed4cb2784625cbcccb588dc7e7bd9c87c9eb
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Fri May 11 09:29:55 2018

Update network traffic annotations test script.

Network traffic annotation test script sends the list of changed files
in a CL to the traffic annotation auditor and auditor passes them to
clang tools for actual processing. If the list of files would be too
long, this may create errors in argument passing buffers.
A threshold for size of change list is added to trigger full test of
annotations and avoiding sending long list of changed files.

Bug:  690323 
Change-Id: I3f9386ade4b93041a27fb21f9c9d3205caf6f17e
Reviewed-on: https://chromium-review.googlesource.com/1054869
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557822}
[modify] https://crrev.com/5ebfed4cb2784625cbcccb588dc7e7bd9c87c9eb/tools/traffic_annotation/scripts/check_annotations.py
Project Member

Comment 109 by bugdroid1@chromium.org, May 11 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/4389462f30c1d3d18605ccaa1f135fe1dd2b8e82

commit 4389462f30c1d3d18605ccaa1f135fe1dd2b8e82
Author: rhalavati@chromium.org <rhalavati@google.com>
Date: Fri May 11 20:28:28 2018

Update timeout for traffic annotation fyibot.

The timeout of network traffic annotation FYIBot test is increased to
12hrs, it can be decreased when we get a better estimate of how long it
needs on the virtual machines.

Bug:690323
Change-Id: Iaef81d9fb9d742e45f480ba057a2bd3db40e7ab3
Reviewed-on: https://chromium-review.googlesource.com/1054868
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/4389462f30c1d3d18605ccaa1f135fe1dd2b8e82/masters/master.chromium.fyi/master.cfg
[modify] https://crrev.com/4389462f30c1d3d18605ccaa1f135fe1dd2b8e82/masters/master.tryserver.chromium.linux/master.cfg
Project Member

Comment 110 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2edced5d340bd5eba8f6a46c3a98ef2bf5e55161

commit 2edced5d340bd5eba8f6a46c3a98ef2bf5e55161
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Mon May 14 05:53:29 2018

Update traffic_annotation_auditor's safe list processing.

A minor bug in processing safe list in traffic annotation auditor is
fixed.

Bug:  690323 
Change-Id: I76f6d023f88106bf69b6c5546142afb52e8e37c5
Reviewed-on: https://chromium-review.googlesource.com/1054877
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558206}
[modify] https://crrev.com/2edced5d340bd5eba8f6a46c3a98ef2bf5e55161/tools/traffic_annotation/auditor/traffic_annotation_auditor.cc
[modify] https://crrev.com/2edced5d340bd5eba8f6a46c3a98ef2bf5e55161/tools/traffic_annotation/bin/README.md
[modify] https://crrev.com/2edced5d340bd5eba8f6a46c3a98ef2bf5e55161/tools/traffic_annotation/bin/linux64/traffic_annotation_auditor.sha1

Comment 111 by rhalavati@chromium.org, May 17 2018

Blockedon: 844014
Project Member

Comment 112 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90ca9042b601ff1c9f0349a93a854552ed4c7a95

commit 90ca9042b601ff1c9f0349a93a854552ed4c7a95
Author: Ramin Halavati <rhalavati@chromium.org>
Date: Thu Jul 05 15:07:22 2018

Add annotations count test to traffic_annotation_auditor_tests.py.

A test is added to traffic_annotation_auditor_tests.py to check if the
number of extracted annotations is above a fixed threshold.

Bug:  690323 
Change-Id: I6c18feddd4e176c2d10833db00d8d62d85125b0f
Reviewed-on: https://chromium-review.googlesource.com/1126767
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572795}
[modify] https://crrev.com/90ca9042b601ff1c9f0349a93a854552ed4c7a95/tools/traffic_annotation/scripts/traffic_annotation_auditor_tests.py

Comment 113 by rhalavati@chromium.org, Jul 13

Status: Fixed (was: Started)
Two trybots in commit queue for Windows and Linux and two FYI bots for Windows and Linux for more comprehensive tests are active.
Showing comments 14 - 113 of 113 Older ›
►

Sign in to add a comment