New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

BackgroundOfflinerTask::startBackgroundRequests should release a waiter

Project Member Reported by fgor...@chromium.org, Feb 9 2017

Issue description

BackgroundOfflinerTask::startBackgroundRequests should release a waiter in cases where it will not start any work. We are currently not doing that if the device conditions are not met.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f0be6ea9ee6b8f44a56673a26996a767fd4539c

commit 4f0be6ea9ee6b8f44a56673a26996a767fd4539c
Author: fgorski <fgorski@chromium.org>
Date: Fri Feb 10 01:22:02 2017

[Offline pages] Refactoring and code fix in BackgroundOffinerTask

This patch deals with 2 issues:
* We need to simplify the logic in BackgroundOffinerTask to reuse it
  when converting background work to JobService for O,
* It turns out that the waiter provided by ChromeBackgroundService
  was not released by the BackgroundOffinerTask in cases when device
  conditions were not met,
* Relevant test are updated: wait is added to make sure lock is
  released in all cases,
* Additionally tests are refactored to apply to new interface:
  boolean result of startBackgroundRequests was never used, hence it was
  removed and replaced with proper lock release.

BUG= 690322 ,683802

Review-Url: https://codereview.chromium.org/2685873003
Cr-Commit-Position: refs/heads/master@{#449502}

[modify] https://crrev.com/4f0be6ea9ee6b8f44a56673a26996a767fd4539c/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
[modify] https://crrev.com/4f0be6ea9ee6b8f44a56673a26996a767fd4539c/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

Cc: dim...@chromium.org
Dmitry, this bug causes us to take 4 minutes to do nothing, when triggering conditions are not met or we are on svelte devices... Please take a look and let's chat. I'd like to see it merged to M57 if RM allows it.
Status: Started (was: Assigned)
The bug is already fixed on trunk.

Comment 4 by dim...@chromium.org, Feb 15 2017

Labels: ReleaseBlock-Stable M-57
Labels: Merge-Request-57
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 15 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 15 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d

commit 4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d
Author: Filip Gorski <fgorski@chromium.org>
Date: Wed Feb 15 22:40:42 2017

[Offline pages] Refactoring and code fix in BackgroundOffinerTask

This patch deals with 2 issues:
* We need to simplify the logic in BackgroundOffinerTask to reuse it
  when converting background work to JobService for O,
* It turns out that the waiter provided by ChromeBackgroundService
  was not released by the BackgroundOffinerTask in cases when device
  conditions were not met,
* Relevant test are updated: wait is added to make sure lock is
  released in all cases,
* Additionally tests are refactored to apply to new interface:
  boolean result of startBackgroundRequests was never used, hence it was
  removed and replaced with proper lock release.

BUG= 690322 ,683802

Review-Url: https://codereview.chromium.org/2685873003
Cr-Commit-Position: refs/heads/master@{#449502}
(cherry picked from commit 4f0be6ea9ee6b8f44a56673a26996a767fd4539c)

Review-Url: https://codereview.chromium.org/2692853011 .
Cr-Commit-Position: refs/branch-heads/2987@{#533}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTask.java
[modify] https://crrev.com/4da2d1afd4c2ca9f1d40e91e66a012fb6ca7983d/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/BackgroundOfflinerTaskTest.java

Sign in to add a comment