New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690291 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Sep 2017
Cc:
█ kcaratt...@chromium.org
vakh@chromium.org
nparker@chromium.org
█ awoz@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Test Safe Browsing page is broken for blacklisting

Project Member Reported by kcaratt...@chromium.org, Feb 9 2017 

testsafebrowsing.appspot.com has a section for permissions blacklisting. It should behave as follows:
1) All permission requests blocked when the blacklisting flag is on
2) no permission requests blocked when the blacklisting flag is off.

Currently, the same behaviour is exhibited when either the blacklisting flag is on or off:
1) All geolocation permission requests are blocked.
2) None of the notification permission requests are blocked.

This behaviour should be fixed.

Comment 1 by kcaratt...@chromium.org, Feb 9 2017

Cc: nparker@chromium.org
Some more info:

Geolocation is blocked because the request is not https.

The actual response from Safe Browsing is empty for these pages.

Comment 2 by kcaratt...@chromium.org, Feb 13 2017

Cc: -meredithl@google.com kcaratt...@chromium.org

Comment 3 by kcaratt...@chromium.org, Jun 20 2017 

Hey Dom, are there any updates on this?

Comment 4 by dominickn@chromium.org, Jun 20 2017

Cc: vakh@chromium.org
Currently following up offline with vakh@ on this. It looks like some part of the hash generation might still be broken.

Comment 5 by vakh@chromium.org, Jun 20 2017 

It seems like the hash generation code is working fine. Let's wait for awoz@ to look at it from the server side.

Comment 6 by kcaratt...@chromium.org, Jun 20 2017 

I don't think Alex is following this bug. What exactly do we need him to check? Can you send him an email (cc me)? Thanks!

Comment 7 by vakh@chromium.org, Jun 20 2017 

The offline discussion continued and here's the latest:
<quote>
...
I just remembered that we haven't yet pushed the changes to the test entries. That should happen by EOW, at which point I'll ping this thread for you to verify.
</quote>

I'll CC you on that email thread.

Comment 8 by dominickn@chromium.org, Sep 25 2017

Status: Fixed (was: Assigned)
This is now fixed thanks to some server side redeployments.
►

Sign in to add a comment