New issue
Advanced search Search tips

Issue 690267 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CrOS: explicitly specify cellular USE flags in profiles/targets/chromeos/make.defaults

Project Member Reported by benchan@chromium.org, Feb 9 2017

Issue description

CrOS targets currently rely on IUSE=+cellular in packages (like shill) to enable cellular by default, which is cumbersome to maintain and sometimes error-prone (e.g. cellular USE flag isn't currently turned on in debugd, so modem_status isn't available on a cellular SKU).

Instead of relying on IUSE=+cellular, we should explicitly specify cellular USE flag in profiles/targets/chromeos/make.defaults, which propagates to CrOS targets by default and can be selectively turned off on a per-target basis.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4e0b3a99ee2b80d4d968a5833e6b6f481dcd678d

commit 4e0b3a99ee2b80d4d968a5833e6b6f481dcd678d
Author: Ben Chan <benchan@chromium.org>
Date: Thu Feb 09 09:18:28 2017

shill: don't explicitly enable cellular by default

With CL:439905 now explicitly enabling the 'cellular' USE flag by
default in the chromeos profile, shill doesn't need to explicitly enable
the cellular USE flag by default.

BUG= chromium:690267 
CQ-DEPEND=CL:439905
TEST=Verify that the 'cellular' USE flag for shill is still enabled for regular CrOS targets.

Change-Id: Ibe4c5cc49fb083e57a60e3e2fbb341bb21d151ab
Reviewed-on: https://chromium-review.googlesource.com/439887
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4e0b3a99ee2b80d4d968a5833e6b6f481dcd678d/chromeos-base/shill/shill-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a60f601423474f78d44e7d55b4cdc4acfe879b6d

commit a60f601423474f78d44e7d55b4cdc4acfe879b6d
Author: Ben Chan <benchan@chromium.org>
Date: Thu Feb 09 09:18:27 2017

make.defaults: explicitly enable cellular USE flags in chromeos profile

Cellular features are supported on regular ChromeOS targets. However,
ChromeOS targets currently rely on individual packages (e.g. shill) to
specify IUSE=+cellular to enable cellular features, which is cumbersome
to maintain and sometimes error-prone. This CL explicitly enables the
'cellular' USE flag by default for the chromeos profile. USE flags
related to cellular features are also grouped together to help identify
them together.

BUG= chromium:690267 
TEST=Verify that 'cellular' USE flag is enabled for regular CrOS
     targets, but disabled for targets based on the minimal profile:

     equery-$BOARD u virtual/target-chromium-os-1
     equery-$BOARD u chromeos-base/debugd
     equery-$BOARD u chromeos-base/shill

Change-Id: I77e52354f54f7cba7ee130acfc0ecadaa3da4876
Reviewed-on: https://chromium-review.googlesource.com/439905
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/a60f601423474f78d44e7d55b4cdc4acfe879b6d/profiles/targets/chromeos/make.defaults

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/473c52aeb6d39256632c5f0f8bd890386cbe1efa

commit 473c52aeb6d39256632c5f0f8bd890386cbe1efa
Author: Ben Chan <benchan@chromium.org>
Date: Thu Feb 09 11:10:23 2017

target-chromiumos: don't explicitly enable cellular by default

With CL:439905 now explicitly enabling the 'cellular' USE flag by
default in the chromeos profile, target-chromiumos doesn't need to
explicitly enable the cellular USE flag by default.

BUG= chromium:690267 
CQ-DEPEND=CL:439905
TEST=Verify that the 'cellular' USE flag is still enabled for regular CrOS targets.

Change-Id: I205ac7cc097584417798586751090d620c02aed8
Reviewed-on: https://chromium-review.googlesource.com/440044
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/473c52aeb6d39256632c5f0f8bd890386cbe1efa/virtual/target-chromium-os/target-chromium-os-1-r64.ebuild
[modify] https://crrev.com/473c52aeb6d39256632c5f0f8bd890386cbe1efa/virtual/target-chromium-os/target-chromium-os-1.ebuild

Status: Fixed (was: Started)

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment