New issue
Advanced search Search tips

Issue 690266 link

Starred by 1 user
Status: Fixed
Owner:
dominickn@chromium.org
Closed: Feb 2017
Cc:
dominickn@chromium.org
hanxi@chromium.org
pkotw...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature



Sign in to add a comment

Log UMA metric to determine how often users install non-webapp-compatible webapps

Project Member Reported by pkotw...@chromium.org, Feb 9 2017 
Log UMA metric to determine how often users install non-webapp-compatible webapps

Based on the web manifest, "Add to homescreen" in the app menu does three different things based on the contents of the site's Web Manifest (and whether the site has a Web Manifest):
1) Adds a shortcut on the homescreen which opens Chrome in a browser tab
2) Adds a shortcut on the homescreen which opens Chrome in fullscreen
3) Installs a WebAPK

It would be nice to be able to get rid of (2). However, we need to figure out how often (2) occurs

Comment 1 by pkotw...@chromium.org, Feb 9 2017

Owner: hanxi@chromium.org
Status: Assigned (was: Untriaged)
Xi, this is very similar to the work that you are already doing. Assigning to you

Comment 2 by sbirch@chromium.org, Feb 13 2017

Mergedinto: 689326
Status: Duplicate (was: Assigned)

Comment 3 by dominickn@chromium.org, Feb 14 2017

Labels: -Type-Bug -Pri-3 M-57 Pri-1 Type-Feature
Owner: dominickn@chromium.org
Status: Assigned (was: Duplicate)
Unduping and assigning to me. This needs to be merged to M57.
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de938a8e39930cca0d2a1f8c96f2cdc9b15192de

commit de938a8e39930cca0d2a1f8c96f2cdc9b15192de
Author: dominickn <dominickn@chromium.org>
Date: Thu Feb 16 08:51:04 2017

Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

BUG= 690266 

Review-Url: https://codereview.chromium.org/2697473005
Cr-Commit-Position: refs/heads/master@{#450902}

[modify] https://crrev.com/de938a8e39930cca0d2a1f8c96f2cdc9b15192de/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/de938a8e39930cca0d2a1f8c96f2cdc9b15192de/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/de938a8e39930cca0d2a1f8c96f2cdc9b15192de/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/de938a8e39930cca0d2a1f8c96f2cdc9b15192de/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/de938a8e39930cca0d2a1f8c96f2cdc9b15192de/tools/metrics/histograms/histograms.xml

Comment 6 by dominickn@chromium.org, Feb 20 2017

Labels: Merge-Request-57
Requesting merge of #5 to M57. This is a metrics CL that will be important to collect in M57 with WebAPKs. The change is baked in Canary and we are already seeing metrics come in from that channel.
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 20 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 20 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3feb5fba279ded7c74309592bc573063de5fd28f

commit 3feb5fba279ded7c74309592bc573063de5fd28f
Author: Dominick Ng <dominickn@chromium.org>
Date: Mon Feb 20 06:35:52 2017

Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

BUG= 690266 

Review-Url: https://codereview.chromium.org/2697473005
Cr-Commit-Position: refs/heads/master@{#450902}
(cherry picked from commit de938a8e39930cca0d2a1f8c96f2cdc9b15192de)

Review-Url: https://codereview.chromium.org/2707773003 .
Cr-Commit-Position: refs/branch-heads/2987@{#593}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/3feb5fba279ded7c74309592bc573063de5fd28f/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/3feb5fba279ded7c74309592bc573063de5fd28f/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/3feb5fba279ded7c74309592bc573063de5fd28f/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/3feb5fba279ded7c74309592bc573063de5fd28f/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/3feb5fba279ded7c74309592bc573063de5fd28f/tools/metrics/histograms/histograms.xml

Comment 9 by vitaliii@chromium.org, Feb 20 2017 

The merge in #8 seems to cause compile errors in branch 2987 (at least in my local build):

../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc: In member function 'void AddToHomescreenDataFetcher::OnDidPerformInstallableCheck(const InstallableData&)':
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:218:16: error: 'const struct InstallableData' has no member named 'badge_icon'
       if (data.badge_icon && !data.badge_icon->drawsNothing()) {
                ^
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:218:36: error: 'const struct InstallableData' has no member named 'badge_icon'
       if (data.badge_icon && !data.badge_icon->drawsNothing()) {
                                    ^
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:219:24: error: 'struct ShortcutInfo' has no member named 'best_badge_icon_url'
         shortcut_info_.best_badge_icon_url = data.badge_icon_url;
                        ^
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:219:51: error: 'const struct InstallableData' has no member named 'badge_icon_url'
         shortcut_info_.best_badge_icon_url = data.badge_icon_url;
                                                   ^
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:220:9: error: 'badge_icon_' was not declared in this scope
         badge_icon_ = *data.badge_icon;
         ^
../../chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:220:29: error: 'const struct InstallableData' has no member named 'badge_icon'
         badge_icon_ = *data.badge_icon;

Comment 10 by dominickn@chromium.org, Feb 20 2017 

#9: dammit, another CL landed before this one on tip of tree with changes that aren't on M57. I'll revert and reland it tomorrow.

Comment 12 by vitaliii@chromium.org, Feb 20 2017 

Great thank you for handling this so soon and so fast!
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/086340785581c211b9647370d63b609aed5c5a76

commit 086340785581c211b9647370d63b609aed5c5a76
Author: Dominick Ng <dominickn@chromium.org>
Date: Mon Feb 20 23:07:32 2017

[Reland] Improve the resolution of the menu item homescreen launch source metric.

This CL deprecates the SOURCE_ADD_TO_HOMESCREEN source for homescreen
launch intents on Android. Three new buckets are added in its place:
SOURCE_ADD_TO_HOMESCREEN_PWA, SOURCE_ADD_TO_HOMESCREEN_STANDALONE, and
SOURCE_ADD_TO_HOMESCREEN_SHORTCUT.

Existing shortcuts are mapped to either the STANDALONE or SHORTCUT
sources, as it is impossible to properly distinguish PWAs from non-PWAs
when added from the menu item prior to this CL. Following this CL, PWAs
added from the menu item are explicitly tagged with
SOURCE_ADD_TO_HOMESCREEN_PWA.

This is a reland on M57 branch as the earlier merge inadvertently brought
an M57-incompatible change along with it.

BUG= 690266 

Review-Url: https://codereview.chromium.org/2697473005
Cr-Commit-Position: refs/heads/master@{#450902}
(cherry picked from commit de938a8e39930cca0d2a1f8c96f2cdc9b15192de)

Review-Url: https://codereview.chromium.org/2709613002 .
Cr-Commit-Position: refs/branch-heads/2987@{#601}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/086340785581c211b9647370d63b609aed5c5a76/chrome/browser/android/metrics/launch_metrics.cc
[modify] https://crrev.com/086340785581c211b9647370d63b609aed5c5a76/chrome/browser/android/shortcut_info.cc
[modify] https://crrev.com/086340785581c211b9647370d63b609aed5c5a76/chrome/browser/android/shortcut_info.h
[modify] https://crrev.com/086340785581c211b9647370d63b609aed5c5a76/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/086340785581c211b9647370d63b609aed5c5a76/tools/metrics/histograms/histograms.xml

Comment 14 by dominickn@chromium.org, Feb 21 2017

Status: Fixed (was: Assigned)
Should be fixed and merged properly now.
►

Sign in to add a comment