Different behaviour when clicking Enter on a first vs non-first autocomplete suggestion
Reported by
kdzwinel@gmail.com,
Feb 9 2017
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.76 Safari/537.36 Steps to reproduce the problem: 1. Go to any page 2. Open DevTools ➡ Elements tab ➡ Class Pane Widget 3. Start typing so that class suggestions show up 4. When at least two selections are shown, select the first one and click enter 5. Repeat step 4, but select the second suggestion instead and click enter What is the expected behavior? For both steps 4 and 5 the behaviour should be the same. What went wrong? When the first suggestion is selected and user clicks enter class is autocompleted AND immediately applied (added to the list of classes below). When non-first suggestion is selected and user clicks enter it gets autocompleted but not applied. Did this work before? No Chrome version: 56.0.2924.76 Channel: n/a OS Version: OS X 10.12.2 Flash Version: Shockwave Flash 24.0 r0
,
Feb 9 2017
,
Mar 21 2017
I've started it here: https://codereview.chromium.org/2764003002
,
Mar 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ec06ab81aae16ab444938342c2bf0a6fc712374 commit 2ec06ab81aae16ab444938342c2bf0a6fc712374 Author: kdzwinel <kdzwinel@gmail.com> Date: Wed Mar 22 21:47:21 2017 DevTools: Do not apply first suggestion in the classes pane on enter Now it works like this: http://i.imgur.com/IYk13Yf.gif . Which is consistent with the behaviour in the styles pane. BUG= 690255 Review-Url: https://codereview.chromium.org/2764003002 Cr-Commit-Position: refs/heads/master@{#458884} [modify] https://crrev.com/2ec06ab81aae16ab444938342c2bf0a6fc712374/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js [modify] https://crrev.com/2ec06ab81aae16ab444938342c2bf0a6fc712374/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js
,
Dec 10
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by nyerramilli@chromium.org
, Feb 9 2017