Issue metadata
Sign in to add a comment
|
80kb regression in resource_sizes (MonochromePublic.apk) at 448620:448620 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 9 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8988180337111639264
,
Feb 9 2017
=== BISECT JOB RESULTS === NO Perf regression found, tests failed to produce values Bisect Details Configuration: android_nexus7_perf_bisect Benchmark : (MonochromePublic.apk) Metric : MonochromePublic.apk_Specifics/normalized apk size To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=normalized.apk.size resource_sizes (MonochromePublic.apk) Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8988180337111639264 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=6416675454320640 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Feb 10 2017
Bisect failed.
,
Feb 10 2017
There is only one CL in the roll, the v8 roll at r448620. Do we care about 80kib regression?
,
Feb 13 2017
We certainly care, but there's not much we can do until bisects are fixed. (well, we could manually build all revisions, but that's not a good long-term solution). In this case, I can tell from the log that it's: https://codereview.chromium.org/2679063003 Since it was reverted in this roll, and a similar 80kb improvement was seen in the v8 roll where it landed (rev 448310). Also - the commit description states that it saves 80kb :P. In this case, I think the appropriate action is to note the change in: https://docs.google.com/spreadsheets/d/1GrRkszV7Oy5pVsaMb5Eb6s8izW9t4dElBxIH3iGq93o/edit#gid=1894856744 It's valuable to collect a the list of things that can reduce our size. In addition, comment on the review to see if a reland is being attempted (which I've now done).
,
Feb 13 2017
-RVG
,
Feb 13 2017
I wasn't planning on relanding this CL since it regresses RegExp.prototype.exec microbenchmarks by around 5%. Unfortunate, the space savings would've been very nice.. There's a tracking bug here for large builtins in V8: https://bugs.chromium.org/p/v8/issues/detail?id=5737
,
Feb 13 2017
,
Feb 16 2017
,
Mar 11 2017
,
May 9 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by briander...@chromium.org
, Feb 9 2017