New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690239 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 630357



Sign in to add a comment

DevTools: DevTools Harmony UI controls

Project Member Reported by einbinder@chromium.org, Feb 9 2017

Issue description

Buttons, checkboxes, dropdowns, radios, and text fields
 

Comment 1 by l...@chromium.org, May 12 2017

Cc: l...@chromium.org
Proposal:
harmony1.png
486 KB View Download

Comment 2 by l...@chromium.org, May 16 2017

themedCheckboxesBeforeAfter.png
92.3 KB View Download

Comment 3 by l...@chromium.org, May 18 2017

Second iteration
harmony2.png
546 KB View Download

Comment 4 by l...@chromium.org, May 18 2017

partialCheckboxes.png
40.3 KB View Download

Comment 5 by l...@chromium.org, May 22 2017

Blocking: 630357
Cc: -l...@chromium.org einbinder@chromium.org
Owner: l...@chromium.org

Comment 6 by l...@chromium.org, May 23 2017

Third iteration, after confirming the stickersheet.
- Focus rings around text inputs now have no inner gray border
iteration3.png
551 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13fb906c913d2886ecec2bb50b42f7d7629711f0

commit 13fb906c913d2886ecec2bb50b42f7d7629711f0
Author: luoe <luoe@chromium.org>
Date: Thu Jun 01 23:55:08 2017

DevTools: cleanup text input styles

We may want to land another CL to update text input styles:
https://codereview.chromium.org/2875193002/

BUG= 690239 

Review-Url: https://codereview.chromium.org/2906983002
Cr-Commit-Position: refs/heads/master@{#476487}

[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/devices/devicesView.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/emulation/sensors.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/network/BlockedURLsPane.js
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/network/blockedURLsPane.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/persistence/editFileSystemView.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/persistence/workspaceSettingsTab.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/settings/frameworkBlackboxSettingsTab.css
[modify] https://crrev.com/13fb906c913d2886ecec2bb50b42f7d7629711f0/third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css

Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b73ea5c134104f1d27512c58ac88f60b7cdd889e

commit b73ea5c134104f1d27512c58ac88f60b7cdd889e
Author: luoe <luoe@chromium.org>
Date: Fri Jun 02 19:28:15 2017

DevTools: cleanup button styles

- Migrates some buttons to be made with UI.createTextButton
- Use the same shade of 'blue' color on active buttons

This CL also prepares the way for new button styles:
https://codereview.chromium.org/2881453003

BUG= 690239 

Review-Url: https://codereview.chromium.org/2912563003
Cr-Commit-Position: refs/heads/master@{#476752}

[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/help/ReleaseNoteView.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/help/releaseNote.css
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/ui/searchableView.css
[modify] https://crrev.com/b73ea5c134104f1d27512c58ac88f60b7cdd889e/third_party/WebKit/Source/devtools/front_end/ui/textButton.css

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1192df1565e6591124601a249336a0879d0f4d09

commit 1192df1565e6591124601a249336a0879d0f4d09
Author: luoe <luoe@chromium.org>
Date: Tue Jun 06 02:43:22 2017

DevTools: update dropdowns to new style

BUG= 690239 

Review-Url: https://codereview.chromium.org/2906603004
Cr-Commit-Position: refs/heads/master@{#477160}

[modify] https://crrev.com/1192df1565e6591124601a249336a0879d0f4d09/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/067ae0c565d431228fbcada9823b47d371f54b7d

commit 067ae0c565d431228fbcada9823b47d371f54b7d
Author: luoe <luoe@chromium.org>
Date: Tue Jun 06 04:28:11 2017

DevTools: update buttons to new style

Please see crbug for a screenshot.

BUG= 690239 

Review-Url: https://codereview.chromium.org/2881453003
Cr-Commit-Position: refs/heads/master@{#477194}

[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/LayoutTests/inspector/help/release-note-expected.txt
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/help/releaseNote.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/inline_editor/cssShadowEditor.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/mobile_throttling/networkConditionsSettingsTab.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/profiler/ProfileLauncherView.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/settings/frameworkBlackboxSettingsTab.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/SearchableView.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/listWidget.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/searchableView.css
[modify] https://crrev.com/067ae0c565d431228fbcada9823b47d371f54b7d/third_party/WebKit/Source/devtools/front_end/ui/textButton.css

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99

commit ea62429d8dcfa87cd32a2ce9dcaa83167c827b99
Author: luoe <luoe@chromium.org>
Date: Tue Jun 06 04:37:31 2017

DevTools: update text inputs to new style

Please see crbug for a screenshot.

BUG= 690239 

Review-Url: https://codereview.chromium.org/2875193002
Cr-Commit-Position: refs/heads/master@{#477195}

[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/color_picker/Spectrum.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/emulation/deviceModeToolbar.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/emulation/devicesSettingsTab.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/emulation/sensors.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/inline_editor/CSSShadowEditor.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/inline_editor/cssShadowEditor.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/persistence/WorkspaceSettingsTab.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/screencast/screencastView.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/settings/settingsScreen.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/sources/AddSourceMapURLDialog.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/sources/sourcesSearch.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
[modify] https://crrev.com/ea62429d8dcfa87cd32a2ce9dcaa83167c827b99/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Comment 12 by l...@chromium.org, Aug 14 2017

Status: Fixed (was: Assigned)
No further work is planned at this time, so marking as fixed.

Sign in to add a comment