New issue
Advanced search Search tips

Issue 690218 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in blink::TextRun::codepointAtAndNext

Project Member Reported by ClusterFuzz, Feb 8 2017

Issue description

Cc: tkent@chromium.org esprehn@chromium.org
Components: Blink
Labels: OS-Android OS-Chrome OS-Linux OS-Windows
Owner: jochen@chromium.org
Status: Assigned (was: Untriaged)
Adding some third_party/WebKit/Source/platform/OWNERS. Can you please redirect this to the right person? Thanks!

I am also assuming that this applies to any Blink platform.

Comment 2 by tkent@chromium.org, Feb 9 2017

Cc: -tkent@chromium.org jochen@chromium.org
Components: -Blink Blink>Fonts
Owner: e...@chromium.org
This is in text rendering area.  eae@, would you assign a proper owner please?


Comment 3 by e...@chromium.org, Feb 9 2017

Thanks tkent.
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 9 2017

Labels: M-58
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 9 2017

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Feb 9 2017

Labels: Pri-1

Comment 7 by e...@chromium.org, Feb 9 2017

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357719bae98584d89410828312d37fe6cdc15b03

commit 357719bae98584d89410828312d37fe6cdc15b03
Author: eae <eae@chromium.org>
Date: Fri Feb 10 02:58:39 2017

Have codePointAt DCHECKS apply to 8bit strings too

BUG= 690218 
R=szager@chromium.org

Review-Url: https://codereview.chromium.org/2691443002
Cr-Commit-Position: refs/heads/master@{#449540}

[modify] https://crrev.com/357719bae98584d89410828312d37fe6cdc15b03/third_party/WebKit/Source/platform/text/TextRun.h

Project Member

Comment 10 by ClusterFuzz, Feb 15 2017

ClusterFuzz has detected this issue as fixed in range 450446:450496.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6531355262582784

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 2
Crash Address: 0x60a000180374
Crash State:
  blink::TextRun::codepointAtAndNext
  blink::CachingWordShapeIterator::nextWordEndIndex
  blink::CachingWordShapeIterator::next
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=448729:448967
Fixed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=450446:450496

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv96j-vgVnSPN6Cm2J0f7X3Y9tmSl9w3fxcqDJFEDI13FXB40443Stb5rIM9-kRGfyo-DJcxKHL4Z-K6Dy_BmuuraEF1khwkp2D9aTyQANv7odhL3laSjtBz4hO95NuUtbEBvxUFhd6_DDI01n-cAP3rdBDfx1ahxbPgXb2BJOdcC-ugod9od-0BHWbCMalXkkyZy7I0ntlS9C4V9xC3bLwz7AwchTuQZqXPQgjLg2urMPL2Ls4wpdKjU9kGM_1uaDRV4dnR9XgwzmoQpUKjjh0BMq5FEHA9IxEFgWDvqntFyJWwmWSR3Z7s2ZVDp9ci12r9xzDLEbOBouz1pSWRwTj5_gIp2qZ002kShDuEHkwnSHg-BTjGtLvEOIAcckq_BHIb1Rxv_NssUE-DO9mzwT-sNA_UAsw?testcase_id=6531355262582784


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 11 by ClusterFuzz, Feb 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6531355262582784 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 15 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Beta
Project Member

Comment 14 by sheriffbot@chromium.org, May 24 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment