New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690195 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

No support for self.origin

Reported by bzbar...@mit.edu, Feb 8 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:54.0) Gecko/20100101 Firefox/54.0

Steps to reproduce the problem:
1. Evaluate self.origin

What is the expected behavior?
Get the origin of the window or worker I'm in.

What went wrong?
I got undefined.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: <Copy from: 'about:version'>  Channel: n/a
OS Version: OS X 10.12
Flash Version: 

See https://html.spec.whatwg.org/multipage/webappapis.html#dom-origin
 

Comment 1 by mkwst@chromium.org, Feb 9 2017

Labels: OS-Android OS-Chrome OS-Linux OS-Windows
Owner: mkwst@chromium.org
Status: Assigned (was: Unconfirmed)
Components: Blink>Workers
Added "Blink>Workers" because this adds a new property to WorkerGlobalScope.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7

commit f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7
Author: andypaicu <andypaicu@chromium.org>
Date: Sat Mar 04 02:00:13 2017

Added support for self.origin in Window and WorkerGlobalScope

Added origin to the interface files
Added firefox tests for frames into the wpt
Created and added tests for workers into the wpt
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/oPGdc9lqpg8/gSjBah0YCAAJ

BUG= 690195 , 694444 
R=mkwst@chromium.org

Review-Url: https://codereview.chromium.org/2706013002
Cr-Commit-Position: refs/heads/master@{#454747}

[delete] https://crrev.com/f5a29c6561e3820a5e71e03c85eb7597b797bfd7/third_party/WebKit/LayoutTests/external/wpt/html/dom/self-origin.sub-expected.txt
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/Worker_Self_Origin.html
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginSharedWorker.js
[add] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/external/wpt/html/webappapis/the-windoworworkerglobalscope-mixin/support/WorkerSelfOriginWorker.js
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-maxlength.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/handshake-fail-by-prepended-null.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/iframe-sandbox-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/iframe-sandbox.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/http/tests/websocket/send-onmessage-origin.html
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/LocalDOMWindow.h
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/frame/Window.idl
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.h
[modify] https://crrev.com/f5a130d1fb31ab5ab19a0c85edd65d6719c0c3f7/third_party/WebKit/Source/core/workers/WorkerGlobalScope.idl

Comment 5 by tkent@chromium.org, Jun 4 2017

Status: Fixed (was: Assigned)

Sign in to add a comment