Refactor buildbucket related logic in buildbucket_lib, build_stauts
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58 commit d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58 Author: Ningning Xia <nxia@chromium.org> Date: Fri Feb 10 04:48:46 2017 Consolidate BuildbucketInfo in buildbucket_lib and build_status Previously we maintained two different buildbucket_info_dict formats in buildbucket_lib and build_status. Consolidate them into one namedtuple. BUG= chromium:690192 TEST=unit_test Change-Id: Icbb8e8673b3b9eb1b8e692d08709ab76ad3a577c Reviewed-on: https://chromium-review.googlesource.com/439771 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58/cbuildbot/build_status_unittest.py [modify] https://crrev.com/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58/cbuildbot/build_status.py [modify] https://crrev.com/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58/cbuildbot/buildbucket_lib_unittest.py [modify] https://crrev.com/d25f9dbfa44a81e4a1431e93ef95c73b42b4ba58/cbuildbot/buildbucket_lib.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3 commit 6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3 Author: Ningning Xia <nxia@chromium.org> Date: Thu Mar 30 22:48:16 2017 Move buildbucket_lib to lib/ Move buildbucket_lib to lib/ to avoid circle dependency when builder_status_lib tries to call it for chromium:694730. BUG= chromium:690192 TEST=unit_tests Change-Id: I2de5aacf9d26aa36f3e970f95262d82e68b72a1d Reviewed-on: https://chromium-review.googlesource.com/461320 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Aviv Keshet <akeshet@chromium.org> [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/remote_try.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/build_stages_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/generic_stages.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/scheduler_stages.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/manifest_version_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/build_status_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/completion_stages_unittest.py [rename] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/lib/buildbucket_lib_unittest [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/build_status.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/generic_stages_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/sync_stages_unittest.py [rename] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/lib/buildbucket_lib.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/scheduler_stages_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/build_stages.py [rename] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/lib/buildbucket_lib_unittest.py [modify] https://crrev.com/6de0c7cb8c2c31513e69e48b058f5c30b1b34ec3/cbuildbot/stages/report_stages.py
Comment 1 by bugdroid1@chromium.org
, Feb 10 2017