New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690182 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

CRIWVWebsiteDataStore should own browser state instead of CRIWVWebMainParts.

Project Member Reported by michaeldo@chromium.org, Feb 8 2017

Issue description

The website data store should be the owner of the specific browser state being used instead of holding a pointer to a shared one.
 
Mike, have you already started working on it? Because it would likely conflict with https://bugs.chromium.org/p/chromium/issues/detail?id=700791 which I'm going to start working on. (Because CWVWebViewConfiguration should own browser state instead.)
Status: Assigned (was: Started)
I had started, but stopped once I ran into issues with creating the browser states at allocation time of the DataStore. I don't have any saved progress on this task, so I set the status back to Assigned. Feel free to continue with the merge of the objects in 700791. Thank you for checking!
Thanks, got it.
Update to this bug:

As discussed above, CWVWebViewConfiguration should own the BrowserState instead.
Also, after this change, +defaultConfiguration and +incognitoConfiguration should return a new instance of CWVWebViewConfiguration (with a new instance of BrowserState) each time, instead of returning a singleton.

Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21fa55c1594deac368f09c8847b451bea0c1bc2

commit f21fa55c1594deac368f09c8847b451bea0c1bc2
Author: michaeldo <michaeldo@chromium.org>
Date: Sat Apr 15 01:45:12 2017

Remove CWV class and move setting User Agent to CWVWebViewConfiguration.
Move Browser State and Web Client ownership to CWVWebViewConfiguration.
CWVWebViewConfiguration will now create it’s own browser state and will not
share a browser state between copies of the configuration.

BUG= 690182 ,  703359 , 706287

Review-Url: https://codereview.chromium.org/2791403005
Cr-Commit-Position: refs/heads/master@{#464848}

[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/BUILD.gn
[delete] https://crrev.com/c77104dfbdbdb4e4952dad12fa2d2352a07e65ff/ios/web_view/internal/cwv.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/cwv_web_view_configuration.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_browser_state.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_client.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_client.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_delegate.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_delegate.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_parts.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/internal/web_view_web_main_parts.mm
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/public/ChromeWebView.h
[delete] https://crrev.com/c77104dfbdbdb4e4952dad12fa2d2352a07e65ff/ios/web_view/public/cwv.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/shell/shell_app_delegate.m
[modify] https://crrev.com/f21fa55c1594deac368f09c8847b451bea0c1bc2/ios/web_view/shell/shell_view_controller.m

Status: Fixed (was: Started)

Sign in to add a comment