New issue
Advanced search Search tips

Issue 690176 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

cros md - update connecting vpn image

Project Member Reported by est...@chromium.org, Feb 8 2017

Issue description

seems we're still using pre-md assets for this

 
Owner: sgabr...@chromium.org
Status: Assigned (was: Available)
Sebastien, can you please take a look? Note this is 'animated' over top of the network icon by throbbing its opacity (similar to what we do to the network icon itself when a network is connecting).

FTR asset ID is IDR_AURA_UBER_TRAY_NETWORK_VPN.
Aren't we using the VPN key already ? Is it supposed to be an icon before we show the key ?

vpn.png
14.5 KB View Download

Comment 3 by est...@chromium.org, Feb 10 2017

Cc: varkha@chromium.org
I'm not sure if comment 1 is correct. This is used in the VPN list view. When an item is connected (or not connected), it's just a big key. Otherwise it's this extra long ellipsis. If anyone knows how to make it show up, it's Valery.

Comment 4 by est...@chromium.org, Feb 10 2017

sorry, I attached the wrong asset. It's not the badge.


statusbar_vpn_dark.png
350 bytes View Download

Comment 5 by est...@chromium.org, Mar 30 2017

ping Sebastien.

Comment 6 by est...@chromium.org, Mar 30 2017

We can probably just use the big key and throb it.
Sorry guys this bug fell through the crack. Can somebody send me a video /screenshot of this UI in place. Throbbing the key icon on top of network as is might result in weird looking UI.

Comment 8 by est...@chromium.org, Mar 30 2017

no, it's not a badge. It's what you see when the VPN is connecting. It would take the place of the large key here during connecting. (Unfortunately I can't easily fake this to show you what it presently looks like, but it should be the above attached png icon throbbing in and out.)
JyzW9nUDts1.png
11.0 KB View Download
Oh got it I thought it was in the status tray.
Why do we have an animation here where we do not have any in Bluetooth or wifi.
Label should read "connecting" in grey as specced and that's it no?
I think we do have one for wifi/cell.
to be clear, there's no special asset for it. From reading code it looks like we just pump and fade in/out the wedge/triangle.
ah yes I see I forgot we had animation for wifi. Ok let's throb the key icon.
Labels: -M-58 M-59
Cc: sgabr...@chromium.org
Owner: est...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bc254c581e0fab52e1a3772cd1d21bd373e38e

commit e1bc254c581e0fab52e1a3772cd1d21bd373e38e
Author: estade <estade@chromium.org>
Date: Tue Apr 04 15:44:20 2017

Remove a use of raster asset for VPN; update to MD.

This is the icon seen in the vpn detailed page. The png is not removed
because it's still used in //chrome/ and making that use network_icon.cc
is blocked by DEPS rules --- a move/refactor of some sort will be
necessary.

BUG= 690176 

Review-Url: https://codereview.chromium.org/2792253002
Cr-Commit-Position: refs/heads/master@{#461731}

[modify] https://crrev.com/e1bc254c581e0fab52e1a3772cd1d21bd373e38e/ash/common/system/chromeos/network/network_icon.cc

Status: Fixed (was: Started)

Comment 17 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment