cros md - update connecting vpn image |
||||||
Issue descriptionseems we're still using pre-md assets for this
,
Feb 10 2017
Aren't we using the VPN key already ? Is it supposed to be an icon before we show the key ?
,
Feb 10 2017
I'm not sure if comment 1 is correct. This is used in the VPN list view. When an item is connected (or not connected), it's just a big key. Otherwise it's this extra long ellipsis. If anyone knows how to make it show up, it's Valery.
,
Feb 10 2017
sorry, I attached the wrong asset. It's not the badge.
,
Mar 30 2017
ping Sebastien.
,
Mar 30 2017
We can probably just use the big key and throb it.
,
Mar 30 2017
Sorry guys this bug fell through the crack. Can somebody send me a video /screenshot of this UI in place. Throbbing the key icon on top of network as is might result in weird looking UI.
,
Mar 30 2017
no, it's not a badge. It's what you see when the VPN is connecting. It would take the place of the large key here during connecting. (Unfortunately I can't easily fake this to show you what it presently looks like, but it should be the above attached png icon throbbing in and out.)
,
Mar 30 2017
Oh got it I thought it was in the status tray. Why do we have an animation here where we do not have any in Bluetooth or wifi. Label should read "connecting" in grey as specced and that's it no?
,
Mar 30 2017
I think we do have one for wifi/cell.
,
Mar 30 2017
to be clear, there's no special asset for it. From reading code it looks like we just pump and fade in/out the wedge/triangle.
,
Mar 30 2017
ah yes I see I forgot we had animation for wifi. Ok let's throb the key icon.
,
Mar 30 2017
,
Apr 4 2017
,
Apr 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1bc254c581e0fab52e1a3772cd1d21bd373e38e commit e1bc254c581e0fab52e1a3772cd1d21bd373e38e Author: estade <estade@chromium.org> Date: Tue Apr 04 15:44:20 2017 Remove a use of raster asset for VPN; update to MD. This is the icon seen in the vpn detailed page. The png is not removed because it's still used in //chrome/ and making that use network_icon.cc is blocked by DEPS rules --- a move/refactor of some sort will be necessary. BUG= 690176 Review-Url: https://codereview.chromium.org/2792253002 Cr-Commit-Position: refs/heads/master@{#461731} [modify] https://crrev.com/e1bc254c581e0fab52e1a3772cd1d21bd373e38e/ash/common/system/chromeos/network/network_icon.cc
,
Apr 4 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tdander...@chromium.org
, Feb 10 2017Status: Assigned (was: Available)