New issue
Advanced search Search tips

Issue 690173 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug

Blocking:
issue 662084



Sign in to add a comment

[Win 3P] Move module inspection logic from enumerate_modules_model to browser/conflicts.

Project Member Reported by chrisha@chromium.org, Feb 8 2017

Issue description

enumerate_modules_model is being deprecated in favor of browser/conflicts/module_database. The various pieces of module inspection and normalization logic need to be moved to browser/conflicts/module_info_utils. This is also a prime time to add unittests :)
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61e93409b7a95da223db45f8abf4d9eaa8dd52c6

commit 61e93409b7a95da223db45f8abf4d9eaa8dd52c6
Author: pmonette <pmonette@chromium.org>
Date: Mon Mar 06 22:48:48 2017

Add InspectModule() that returns a populated ModuleInspectionResult struct

BUG=690173

Review-Url: https://codereview.chromium.org/2720513005
Cr-Commit-Position: refs/heads/master@{#454986}

[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_util_win.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_util_win.h
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_util_win_unittest.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_win.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_win.h
[add] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/conflicts/module_info_win_unittest.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/win/enumerate_modules_model.h
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/browser/win/enumerate_modules_model_unittest.cc
[modify] https://crrev.com/61e93409b7a95da223db45f8abf4d9eaa8dd52c6/chrome/test/BUILD.gn

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f693974068bced80bd750931026f248e5b9c6dff

commit f693974068bced80bd750931026f248e5b9c6dff
Author: pmonette <pmonette@chromium.org>
Date: Tue Mar 07 17:15:31 2017

Add ModuleInspector

ModuleInspector maintains a queue of modules to inspect and process
them on a background task runner one by one in order to minimize the
resource usage of this expensive operation.

BUG=690173

Review-Url: https://codereview.chromium.org/2721503003
Cr-Commit-Position: refs/heads/master@{#455107}

[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/BUILD.gn
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_database_win.cc
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_database_win.h
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_database_win_unittest.cc
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_event_sink_impl_win_unittest.cc
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_info_win.cc
[add] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_inspector_win.cc
[add] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_inspector_win.h
[add] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/browser/conflicts/module_inspector_win_unittest.cc
[modify] https://crrev.com/f693974068bced80bd750931026f248e5b9c6dff/chrome/test/BUILD.gn

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e657379dbe7bee876bad248cb62efc6f471f56e3

commit e657379dbe7bee876bad248cb62efc6f471f56e3
Author: Patrick Monette <pmonette@chromium.org>
Date: Thu Jul 13 23:32:17 2017

Refactor ShellExtensionEnumerator into a single function.

EnumerateInputMethodEditors() is a much simpler function that does
pretty much the same thing as what ShellExtensionEnumerator is doing.

This CL creates EnumerateShellExtensions() to replace
ShellExtensionEnumerator.

In addition to the code being simpler, this doesn't leave a useless
class instance laying around when it is finished.

Bug: 690173
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ib0ff9dfcbc20b307666cf1f9d1f676565f8c8f25
Reviewed-on: https://chromium-review.googlesource.com/562496
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486532}
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/BUILD.gn
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/chrome_browser_main_win.h
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_input_method_editors_win.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_input_method_editors_win.h
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_input_method_editors_win_unittest.cc
[add] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_shell_extensions_win.cc
[add] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_shell_extensions_win.h
[add] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/enumerate_shell_extensions_win_unittest.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/module_info_util_win.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/conflicts/module_info_util_win.h
[delete] https://crrev.com/de853a0f2629ba4c46344e9a7654171a31907ddf/chrome/browser/conflicts/shell_extension_enumerator_win.cc
[delete] https://crrev.com/de853a0f2629ba4c46344e9a7654171a31907ddf/chrome/browser/conflicts/shell_extension_enumerator_win.h
[delete] https://crrev.com/de853a0f2629ba4c46344e9a7654171a31907ddf/chrome/browser/conflicts/shell_extension_enumerator_win_unittest.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/browser/win/enumerate_modules_model.cc
[modify] https://crrev.com/e657379dbe7bee876bad248cb62efc6f471f56e3/chrome/test/BUILD.gn

Labels: Type-Launch
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4e4fa6ce4488287943643c520a4a19565e5c2da

commit f4e4fa6ce4488287943643c520a4a19565e5c2da
Author: Patrick Monette <pmonette@chromium.org>
Date: Tue Aug 01 00:11:02 2017

Integrate third-party metrics in ModuleDatabase

Those metrics already exist in EnumerateModulesModel.

Bug: 690173
Change-Id: I14757cde09e365c8d994782350fdffc07813586a
Reviewed-on: https://chromium-review.googlesource.com/592633
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490824}
[modify] https://crrev.com/f4e4fa6ce4488287943643c520a4a19565e5c2da/chrome/browser/conflicts/third_party_metrics_recorder_win.cc
[modify] https://crrev.com/f4e4fa6ce4488287943643c520a4a19565e5c2da/chrome/browser/conflicts/third_party_metrics_recorder_win.h

Labels: -Type-Launch
Status: Assigned (was: Untriaged)

Sign in to add a comment