New issue
Advanced search Search tips

Issue 690163 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add support for checking whether a windows machine is managed

Project Member Reported by rogerta@chromium.org, Feb 8 2017

Issue description

Right now, on windows, chrome checks to see if the machine is enrolled in an AD domain before enabling certain enterprise features.  This check does not work on machines that are AAD joined instead, or machines that are only managed via MDM.

The solution is to check if the machine is managed via MDM or whether the machine is enrolled in an AD domain.  The former will detect newer enterprise devices and the latter will check legacy devices.

 
Just adding a note that this has been discussed with the privacy team and approved; the bit is still sent for the same purpose of distinguishing managed devices as before, we just have a more precise definition of what a managed device is.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0c03ddb4a10c8c9d14244bdefc8034054e846e

commit ee0c03ddb4a10c8c9d14244bdefc8034054e846e
Author: rogerta <rogerta@chromium.org>
Date: Wed Feb 22 14:02:04 2017

Use the Windows MDM API to check if the machine is being managed.

BUG= 690163 

Review-Url: https://codereview.chromium.org/2581353002
Cr-Commit-Position: refs/heads/master@{#452028}

[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/base/win/win_util.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/base/win/win_util.h
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/common/crash_keys.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/chrome/common/crash_keys.h
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/update_client/updater_state.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/update_client/updater_state.h
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/update_client/updater_state_unittest.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/update_client/updater_state_win.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/components/update_client/utils.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/content/renderer/render_process_impl.cc
[modify] https://crrev.com/ee0c03ddb4a10c8c9d14244bdefc8034054e846e/tools/metrics/histograms/histograms.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4dd371c464f77b6fbef56d212f7de71e03bf002

commit e4dd371c464f77b6fbef56d212f7de71e03bf002
Author: fdoray <fdoray@chromium.org>
Date: Wed Feb 22 15:59:23 2017

Revert "Use the Windows MDM API to check if the machine is being managed."

This reverts commit ee0c03ddb4a10c8c9d14244bdefc8034054e846e.

Commit causes failures on Google Chrome ChromeOS and
Google Chrome Win:

../../components/update_client/utils.cc:171:39: error: 'IsEnterpriseManaged' is a private member of 'update_client::UpdaterState'
      if (attr.first != UpdaterState::IsEnterpriseManaged) {

BUG= 690163 
TBR=rogerta@chromium.org,sky@chromium.org,asvitkine@chromium.org,grt@chromium.org,avi@chromium.org,waffles@chromium.org,georgesak@chromium.org,pastarmovj@chromium.org

Review-Url: https://codereview.chromium.org/2710713004
Cr-Commit-Position: refs/heads/master@{#452068}

[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/base/win/win_util.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/base/win/win_util.h
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/common/crash_keys.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/chrome/common/crash_keys.h
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/update_client/updater_state.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/update_client/updater_state.h
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/update_client/updater_state_unittest.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/update_client/updater_state_win.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/components/update_client/utils.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/content/renderer/render_process_impl.cc
[modify] https://crrev.com/e4dd371c464f77b6fbef56d212f7de71e03bf002/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57aed38568117ea2787c4b7aa7e24ce27934c7e8

commit 57aed38568117ea2787c4b7aa7e24ce27934c7e8
Author: rogerta <rogerta@chromium.org>
Date: Thu Feb 23 14:50:45 2017

Use the Windows MDM API to check if the machine is being managed.

BUG= 690163 

Review-Url: https://codereview.chromium.org/2581353002
Cr-Original-Commit-Position: refs/heads/master@{#452028}
Committed: https://chromium.googlesource.com/chromium/src/+/ee0c03ddb4a10c8c9d14244bdefc8034054e846e
Review-Url: https://codereview.chromium.org/2581353002
Cr-Commit-Position: refs/heads/master@{#452484}

[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/base/win/win_util.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/base/win/win_util.h
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/component_updater/chrome_component_updater_configurator.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/prefs/chrome_pref_service_factory.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/safe_browsing/incident_reporting/environment_data_collection_win.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/common/crash_keys.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/chrome/common/crash_keys.h
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/policy/core/common/policy_loader_win.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/update_client/updater_state.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/update_client/updater_state.h
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/update_client/updater_state_unittest.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/update_client/updater_state_win.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/components/update_client/utils.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/content/renderer/render_process_impl.cc
[modify] https://crrev.com/57aed38568117ea2787c4b7aa7e24ce27934c7e8/tools/metrics/histograms/histograms.xml

Comment 5 by tnagel@chromium.org, Feb 28 2017

Labels: Enterprise-Triaged

Comment 6 by tnagel@chromium.org, Feb 28 2017

Components: Enterprise

Comment 7 by tnagel@chromium.org, Feb 28 2017

Components: -Enterprise>Triaged
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08f4cddf58834a8d8a7d7057e0b8d020c8ef73e1

commit 08f4cddf58834a8d8a7d7057e0b8d020c8ef73e1
Author: rogerta <rogerta@chromium.org>
Date: Fri Mar 03 16:19:50 2017

Free mdm library after use.

BUG= 690163 

Review-Url: https://codereview.chromium.org/2722323002
Cr-Commit-Position: refs/heads/master@{#454593}

[modify] https://crrev.com/08f4cddf58834a8d8a7d7057e0b8d020c8ef73e1/base/win/win_util.cc

Looks like the last progress made on this was over a year ago. Any update?

Microsoft is starting to push MDM as the preferred way to manage Windows 10 and you miss out on some great features if the device isn't joined to Azure Active Directory. We use Microsoft Intune and it has no issues applying Chrome ADMX policies, except for the ones that require GPO in a domain environment. This is disappointing; as a small office that is entirely cloud based we have no reason for an on-site server.

We've been getting around it by using a master-preference file but if the homepage needs to be changed remotely in the future were out of luck.
Status: Fixed (was: Assigned)
This is now supported in chrome 69.  Please this help center article for details.

https://support.google.com/chrome/a/answer/9102677?hl=en

Sign in to add a comment