New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690161 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add page load metrics observer for subresource filtered pages

Project Member Reported by bmcquade@chromium.org, Feb 8 2017

Issue description

We'd like to track metrics on pages where subresource filtering is applied. We should add a new page load metrics observer for this.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9bf372ebfcea5043ba08a15320e8ddace508f19

commit f9bf372ebfcea5043ba08a15320e8ddace508f19
Author: bmcquade <bmcquade@chromium.org>
Date: Tue Feb 14 00:20:56 2017

Add subresource filter page load metrics observer

SubresourceFilterMetricsObserver tracks key page load
performance metrics, as well as bytes loaded per page,
for page loads where at least one subresource was filtered.

BUG= 690161 

Review-Url: https://codereview.chromium.org/2684153003
Cr-Commit-Position: refs/heads/master@{#450167}

[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/BUILD.gn
[add] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
[add] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.h
[add] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/browser/subresource_filter/subresource_filter_browsertest.cc
[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/chrome/test/BUILD.gn
[modify] https://crrev.com/f9bf372ebfcea5043ba08a15320e8ddace508f19/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment