clang-format quality problem: ObjC prefers to break between receiver and selector, rather than arguments |
||||
Issue description
clang-format produced code that (choose all that apply):
[x] Doesn't match Chromium style
- Doesn't match blink style
[x] Riles my finely honed stylistic dander
[x] No sane human would ever choose
Here's the code before formatting:
[destWindow setCollectionBehavior:
NSWindowCollectionBehaviorMoveToActiveSpace];
item->menu_item.reset(
[[NSMenuItem alloc] initWithTitle:base::SysUTF16ToNSString(title)
action:nil
keyEquivalent:@""]);
Here's the code after formatting:
[destWindow
setCollectionBehavior:NSWindowCollectionBehaviorMoveToActiveSpace];
item->menu_item.reset([[NSMenuItem alloc]
initWithTitle:base::SysUTF16ToNSString(title)
action:nil
keyEquivalent:@""]);
Here's how it ought to look:
[destWindow setCollectionBehavior:
NSWindowCollectionBehaviorMoveToActiveSpace];
item->menu_item.reset(
[[NSMenuItem alloc] initWithTitle:base::SysUTF16ToNSString(title)
action:nil
keyEquivalent:@""]);
Code review link for full files/context:
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/browser_window_controller_private.mm?q=browser_window_controller_private.mm&sq=package:chromium&dr&l=432
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/history_menu_bridge.mm?sq=package:chromium&dr&l=295
Breaking after the receiver looks wrong, as in Chromium we prefer to break after the argument.
,
Feb 8 2017
Filed upstream as https://llvm.org/bugs/show_bug.cgi?id=31906.
,
Oct 26 2017
,
Nov 27
,
Jan 11
Issue has a component, but no priority. Updating to have default priority (Pri-2) |
||||
►
Sign in to add a comment |
||||
Comment 1 by rsesek@chromium.org
, Feb 8 2017