New issue
Advanced search Search tips

Issue 690143 link

Starred by 5 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 674593


Show other hotlists

Hotlists containing this issue:
Non-Standard-IDL


Sign in to add a comment

Deprecate and remove |incremental| attribute and |search| event

Project Member Reported by lunalu@chromium.org, Feb 8 2017

Issue description

Couldn't find any links the the spec for Document#onsearch. Please fix this by either:
a) adding the link to the spec for Document#onsearch,
b) adding Document#onsearch to the spec and link it to standardize it, OR
c) remove this non-standard API.

Thanks

Please also take a look at Element#onsearch and Window#onsearch.
 

Comment 1 by tkent@chromium.org, Feb 8 2017

Components: -Blink>DOM Blink>Forms>Search
Labels: -Pri-2 Hotlist-Interop Needs-BlinkIntent OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows Pri-3
Status: Available (was: Untriaged)
Summary: Deprecate and remove |incremental| attribute and |search| event (was: Standardize or remove Document#onsearch API)
https://www.chromestatus.com/metrics/feature/timeline/popularity/25

Please also take a look at Element#onsearch as well. 
Description: Show this description

Comment 4 by phistuck@gmail.com, Feb 9 2017

Apple invented this, as part of <input type=search>, but it was rejected -
https://lists.w3.org/Archives/Public/public-whatwg-archive/2008Nov/0403.html

I think that any issue filed about nonstandard stuff that should be removed or specified, should start the process by adding a use counter. I suspect those can be removed, but we will never know without metrics.

Comment 5 by tkent@chromium.org, Feb 28 2017

 Issue 695894  has been merged into this issue.
Cc: foolip@chromium.org
Project Member

Comment 9 by sheriffbot@chromium.org, Apr 26 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by tkent@chromium.org, Apr 27 2018

Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1cdcf311c707ea6f0378a9561cd39e484235513

commit e1cdcf311c707ea6f0378a9561cd39e484235513
Author: Kent Tamura <tkent@chromium.org>
Date: Fri Sep 14 04:55:18 2018

WebUI: Stop using non-standard 'incremental' attribute and 'search' event.

All of CrSearchFieldBehavior users use 'incremental' attribute and
'search' event handler in the same way. So CrSearchFieldBehavior
dispatches CustomEvents named 'search' regardless of existence of
'incremental' attribute, and 'search' event handlers continue to work
well.

This CL has no behavior changes.
This is a preparation to remove 'incremental' attribute and 'search'
event.


Bug: 690143
Change-Id: I5ababa9276be6c527bc1b0c4ac571fbdfb9ceccd
Reviewed-on: https://chromium-review.googlesource.com/1218483
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591289}
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/chrome/browser/resources/settings/settings_page/settings_subpage_search.html
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/chrome/test/data/webui/cr_elements/cr_input_test.js
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/ui/webui/resources/cr_elements/cr_input/cr_input.html
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/ui/webui/resources/cr_elements/cr_input/cr_input.js
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js
[modify] https://crrev.com/e1cdcf311c707ea6f0378a9561cd39e484235513/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html

NextAction: 2018-12-11
The NextAction date has arrived: 2018-12-11
NextAction: ----
Hmm, removing usage in Chrome's WebUI didn't affect the UseCounter.
We need to identify users.

Sign in to add a comment