Favicons should be synced |
||||||
Issue descriptionFavicons are only populated after navigation. This means that when logged into multiple devices many web ui that show favicons will have the default icon. The default icon doesn't provide helpful information. Favicons should be synced in the background. This will be noticeable in history, saved passwords, search engines and anywhere else that we need to show favicons.
,
Feb 8 2017
,
Feb 10 2017
See also bug 608069
,
Mar 31 2017
Added to the discussion the owner of bookmarks component - sky@ I realized that icons in bookmarks works much better than on other pages. There are no empty icons (almost). I made a brief investigation. The bookmarks uses chrome://favicon service as other components (password, search engines) do, but also fetch icons in code (https://cs.chromium.org/chromium/src/components/bookmarks/browser/bookmark_model.cc?rcl=bb03bc3127de97898e62323b12cd2997267cfd5a&l=1062) and paint them (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.cc?rcl=bb03bc3127de97898e62323b12cd2997267cfd5a&l=537). Perhaps the same stuff should be implemented for all MD pages. sky@: could you please clarify how you fetch icons for the bookmarks?
,
Mar 31 2017
+estade@ since he made some changes related to icons.
,
Apr 4 2017
forgot to add sky@ to cc. sky@: Please take a look at #4. Thx.
,
Apr 20 2017
dpapad@: Is there any other way to cache icons in the history backend? For example, send some requests that fetch icons from the given URL, but don't visit the URL. During visiting page, Chrome save the icon somehow. Could we just emulate this code (i.e. only icon fetching)? |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hcarmona@chromium.org
, Feb 8 2017