New issue
Advanced search Search tips

Issue 690132 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 148757



Sign in to add a comment

Delete legacy ScriptValueSerializer

Project Member Reported by jbroman@chromium.org, Feb 8 2017

Issue description

It's been superseded, and can now be removed with some cleanup work.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f94559a234a15ed12c9244ffee47279f5dca8a5

commit 4f94559a234a15ed12c9244ffee47279f5dca8a5
Author: jbroman <jbroman@chromium.org>
Date: Thu Feb 09 08:43:46 2017

Remove SerializedScriptValue::serialize and ScriptValueSerializer::serializeWTFString.

To do so, make WebFrameTest serialize inefficiently (but it's just a unit test)
to call postMessage, and have EventSource construct a MessageEvent with a string,
rather than serialized script value, as its data.

BUG= 690132 

Review-Url: https://codereview.chromium.org/2686503005
Cr-Commit-Position: refs/heads/master@{#449241}

[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/core/events/MessageEvent.cpp
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/core/events/MessageEvent.h
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/4f94559a234a15ed12c9244ffee47279f5dca8a5/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba52edd083f1ab24615082c9cd0d9834ed5db206

commit ba52edd083f1ab24615082c9cd0d9834ed5db206
Author: jbroman <jbroman@chromium.org>
Date: Fri Feb 10 01:01:44 2017

Inline the V8BasedStructuredClone feature.

It has been enabled for a milestone (currently at beta), and should not need
to be turned off. This prepares for removing the legacy code.

BUG= 690132 

Review-Url: https://codereview.chromium.org/2684843005
Cr-Commit-Position: refs/heads/master@{#449498}

[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializer.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/ba52edd083f1ab24615082c9cd0d9834ed5db206/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a638ec1d008ef280e454329604a495c3124d9a88

commit a638ec1d008ef280e454329604a495c3124d9a88
Author: jbroman <jbroman@chromium.org>
Date: Fri Feb 10 01:37:59 2017

Remove ScriptValueSerializer.

It has been superseded by V8ScriptValueSerializer and is no longer reachable.

BUG= 690132 

Review-Url: https://codereview.chromium.org/2686113002
Cr-Commit-Position: refs/heads/master@{#449510}

[modify] https://crrev.com/a638ec1d008ef280e454329604a495c3124d9a88/third_party/WebKit/Source/bindings/bindings.gni
[delete] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.cpp
[delete] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializer.h
[delete] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/third_party/WebKit/Source/bindings/core/v8/ScriptValueSerializerTest.cpp
[modify] https://crrev.com/a638ec1d008ef280e454329604a495c3124d9a88/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/a638ec1d008ef280e454329604a495c3124d9a88/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValueFactory.h
[delete] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.cpp
[delete] https://crrev.com/7bca188f60e1398463fc64d9fdc7eab6bc13d0a0/third_party/WebKit/Source/bindings/modules/v8/ScriptValueSerializerForModules.h
[modify] https://crrev.com/a638ec1d008ef280e454329604a495c3124d9a88/third_party/WebKit/Source/bindings/modules/v8/v8.gni

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d6e33a43cc4b5bd70dd69f9104fbf8d31fc31c70

commit d6e33a43cc4b5bd70dd69f9104fbf8d31fc31c70
Author: jbroman <jbroman@chromium.org>
Date: Wed Feb 22 23:54:31 2017

Remove unused tags from blink::SerializationTag.

These tags are no longer interpreted by Blink, so all enumerators not used
in the Blink-side logic have been removed.

BUG= 690132 

Review-Url: https://codereview.chromium.org/2708363003
Cr-Commit-Position: refs/heads/master@{#452283}

[modify] https://crrev.com/d6e33a43cc4b5bd70dd69f9104fbf8d31fc31c70/third_party/WebKit/Source/bindings/core/v8/SerializationTag.h
[modify] https://crrev.com/d6e33a43cc4b5bd70dd69f9104fbf8d31fc31c70/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueDeserializer.cpp

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af8599b05922a8f2b945afe6b7d8468ed3565130

commit af8599b05922a8f2b945afe6b7d8468ed3565130
Author: jbroman <jbroman@chromium.org>
Date: Sat Feb 25 13:43:03 2017

SerializedScriptValue: Remove the 16-bit string representation.

This was used by the legacy serializer, but the new one only produces the
representation backed by a PartitionAlloc buffer. Make the only other path
use it as well, and simplify the code.

BUG= 690132 

Review-Url: https://codereview.chromium.org/2716733006
Cr-Commit-Position: refs/heads/master@{#453088}

[modify] https://crrev.com/af8599b05922a8f2b945afe6b7d8468ed3565130/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.cpp
[modify] https://crrev.com/af8599b05922a8f2b945afe6b7d8468ed3565130/third_party/WebKit/Source/bindings/core/v8/SerializedScriptValue.h

Sign in to add a comment