New issue
Advanced search Search tips

Issue 690128 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

git cl descriptions aren’t UTF-8-clean on Windows

Project Member Reported by mark@chromium.org, Feb 8 2017

Issue description

Descriptions entered into an editor in git cl on Windows aren’t UTF-8-clean.

https://chromium-review.googlesource.com/c/439644/1//COMMIT_MSG

That’s a commit message I wrote on Windows during “git cl upload”. What should have been UTF-8 looking like this:

| Chunked encoding doesn’t require the length

came out like this:

| Chunked encoding doesn’t require the length

I corrected the description in the PolyGerrit UI, which gave https://chromium-review.googlesource.com/c/439644/2//COMMIT_MSG. Then, on a subsequent git cl upload from Windows, the messed-up description reappeared at https://chromium-review.googlesource.com/c/439644/3//COMMIT_MSG. I had to correct it again manually, https://chromium-review.googlesource.com/c/439644/4//COMMIT_MSG.

I am able to use non-ASCII UTF-8 in commit messages that I type on macOS and Linux.
 
Cc: tandrii@chromium.org
Components: -Infra>Git Infra>Codereview
Labels: Milestone-Afterglow Proj-Gerrit-Migration
Owner: aga...@chromium.org
Status: Assigned (was: Untriaged)
Cc: scottmg@chromium.org
Components: -Infra>Codereview Infra>Codereview>Gerrit Infra>SDK
Owner: ----
Status: Available (was: Assigned)
Labels: -Milestone-Afterglow
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
Labels: -Restrict-View-Google -Proj-Gerrit-Migration Pri-2 Type-Bug
Project Member

Comment 7 by sheriffbot@chromium.org, Jan 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -tandrii@chromium.org
Labels: -Pri-2 Pri-3
Status: Available (was: Untriaged)

Sign in to add a comment