Gerrit's new "Rebase Always" strategy lands all dependencies |
||||||
Issue descriptionEg: * change B depends on change A. * Both changes are open (not landed yet). * Submitting B will also cause A to be submitted because of the new "Merge Always" strategy. This happens via both the CQ and by clicking Gerrit's "Submit" button. I know there is a plan to handle this in the CQ by rejecting the run if there are open dependencies (similar to how the CQ handles Rietveld issues). If there is no easy way to prevent this from happening for the "Submit" button, then maybe we should just add a warning message saying to be cautious because all your open dependencies will also land.
,
Feb 13 2017
,
Feb 13 2017
CQ side this has already been implemented in issue 641422, and will be deployed to all Gerrit CQ projects in the next 2 weeks (I hope :)). So, the rest of this ticket is hiding submit button in CQ Gerrit plugin OR adding warning message. Hence, assigning to agable@
,
Feb 13 2017
Please do not hide the submit button. I vote for adding a warning message when the button is clicked if there are any open dependencies.
,
Apr 5 2017
Makes sense, but is a far-enough-out feature that I'm unassigning myself for now. FWIW I want to move the Submit button into the overflow dropdown, but we don't have sufficiently fine-grained API control for that yet.
,
Jul 27 2017
,
Sep 11 2017
The CQ rejects changes with open deps and the submit button has been hidden. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tandrii@chromium.org
, Feb 8 2017