clang-format produced code that (choose all that apply):
- Doesn't match Chromium style
- Doesn't match blink style
[x] Riles my finely honed stylistic dander
[x] No sane human would ever choose
Here's the code before formatting:
kern_return_t result =
mach_vm_region(mach_task_self(),
reprotection_start,
reprotection_length,
VM_REGION_BASIC_INFO_64,
reinterpret_cast<vm_region_info_t>(&info),
&count,
&unused);
Here's the code after formatting:
kern_return_t result = mach_vm_region(
mach_task_self(), reprotection_start, reprotection_length,
VM_REGION_BASIC_INFO_64, reinterpret_cast<vm_region_info_t>(&info),
&count, &unused);
Here's how it ought to look:
kern_return_t result =
mach_vm_region(mach_task_self(),
reprotection_start,
reprotection_length,
VM_REGION_BASIC_INFO_64,
reinterpret_cast<vm_region_info_t>(&info),
&count,
&unused);
Code review link for full files/context:
The reviewer also thought this was a change for the worse: https://codereview.chromium.org/2649973003/diff/20001/base/allocator/allocator_interception_mac.mm#newcode66
The argument list is objectively harder to read when the arguments are smooshed together like that.
Comment 1 by dcheng@chromium.org
, Feb 8 2017