don't reject CLs if tree is throttled at the end of a CQ run |
||||||
Issue descriptionCurrent behavior: If the tree was throttled *at the start* of a CQ run, then the CQ will not reject any changes if it fails (under the assumption that the tree was already broken). Problems: - Often, problems in the tree are first visible in the CQ itself. But throttling the tree in the middle of the CQ run once you notice that the tree is broken doesn't actually save any of the CLs in that run from rejection. - Existing behavior is confusing and difficult to understand. To predict whether the current CQ run will reject CLs, would need to look back at historical tree status at time it started. Suggestion: - Add a tree status check to CommitQueueCompletion stage, just prior to handling of CL submission/rejection. Skip rejection if tree status was throttled at the beginning (saved in validation_pool tree_was_throttled, I believe) or at the end of the run.
,
Feb 8 2017
reject = remove CQ +1 bit accet = submit (not reject) != accept
,
Feb 8 2017
Oh I see... thanks. So what do you call a CL that's neither accepted nor rejected? I hate to nitpick on this, but "rejecting" and "not accepting" have a well-established equivalence in English.
,
Feb 8 2017
> So what do you call a CL that's neither accepted nor rejected? retried
,
Feb 9 2017
,
Feb 14 2017
,
Feb 24 2017
#4 a better term for "neither accepted nor rejected" is IGNORED
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649 commit 93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649 Author: Ningning Xia <nxia@chromium.org> Date: Wed Apr 12 23:16:40 2017 Set TOT_sanity to False if tree isn't open at completion_stage. If a tree is throttled in the middle of its run, treat TOT_sanity as False and do not blame changes in failure handling. BUG= chromium:690105 TEST=unit_tests Change-Id: I45c0032ae20b043960894e05f6ed8fd769dca953 Reviewed-on: https://chromium-review.googlesource.com/470906 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/tree_status.py
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649 commit 93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649 Author: Ningning Xia <nxia@chromium.org> Date: Wed Apr 12 23:16:40 2017 Set TOT_sanity to False if tree isn't open at completion_stage. If a tree is throttled in the middle of its run, treat TOT_sanity as False and do not blame changes in failure handling. BUG= chromium:690105 TEST=unit_tests Change-Id: I45c0032ae20b043960894e05f6ed8fd769dca953 Reviewed-on: https://chromium-review.googlesource.com/470906 Commit-Ready: Ningning Xia <nxia@chromium.org> Tested-by: Ningning Xia <nxia@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/93e6cb3b9c3d72ad4adcc2fa0e8370572ba0b649/cbuildbot/tree_status.py
,
May 15 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by semenzato@chromium.org
, Feb 8 2017