Hide "Submit" button from everyone except Sheriffs (and CQ) |
||||||||
Issue descriptionThe submit button just gives me a modal prompt that I should use the CQ instead. Please make the button just use the CQ.
,
Feb 8 2017
,
Feb 8 2017
,
Feb 8 2017
,
Feb 8 2017
,
Feb 10 2017
We don't want to make the Submit button just use the CQ instead. Being able to bypass the CQ is a feature that people rely on (e.g. via "git cl land"), and we look forward to being able to provide that functionality to sheriffs in Gerrit without requiring them to use the command line. In the future, we do want to hide the Submit button from everyone except for current sheriffs. But in the mean time, we demote it being plain white, add the modal for people who choose to click it anyway, and provide the big blue "Submit to CQ" button as the default action. It looks like we don't have a bug on file for that, so I'm going to repurpose this one to track that work.
,
Apr 25 2017
Now that https://bugs.chromium.org/p/gerrit/issues/detail?id=5360 is fixed, this is unblocked.
,
May 4 2017
This should also mostly take care of the confusing "Submit including parents" buttons (see issue gerrit:5322 and issue gerrit:5835 )
,
May 4 2017
,
May 5 2017
,
May 5 2017
The above change has been landed but not yet deployed. Marking fixed, can verify after deployment. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dborowitz@google.com
, Feb 8 2017