New issue
Advanced search Search tips

Issue 690100 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----

Blocked on:
issue gerrit:5360
issue gerrit:5505


Previous locations:
gerrit:5496


Sign in to add a comment

Hide "Submit" button from everyone except Sheriffs (and CQ)

Project Member Reported by jochen@chromium.org, Feb 8 2017

Issue description

The submit button just gives me a modal prompt that I should use the CQ instead.

Please make the button just use the CQ.
 
Owner: andyb...@chromium.org
This is a Chrome-specific workflow issue that will be resolved with plugins. Andy, can you move to a Chrome project?
Project: chromium
Moved issue gerrit:5496 to now be  issue chromium:690100 .
Cc: vikt...@google.com
Components: Infra>Codereview>Gerrit
Labels: Milestone-Launch Proj-Gerrit-Migration Pri-2
Status: Assigned (was: New)
Summary: "Submit" button should be hidden (was: "Submit" button is pointless)
Blockedon: gerrit:5505
Owner: aga...@chromium.org

Comment 7 by aga...@chromium.org, Feb 10 2017

Labels: -Milestone-Launch Milestone-Afterglow
Summary: Hide "Submit" button from everyone except Sheriffs (and CQ) (was: "Submit" button should be hidden)
We don't want to make the Submit button just use the CQ instead. Being able to bypass the CQ is a feature that people rely on (e.g. via "git cl land"), and we look forward to being able to provide that functionality to sheriffs in Gerrit without requiring them to use the command line.

In the future, we do want to hide the Submit button from everyone except for current sheriffs. But in the mean time, we demote it being plain white, add the modal for people who choose to click it anyway, and provide the big blue "Submit to CQ" button as the default action.

It looks like we don't have a bug on file for that, so I'm going to repurpose this one to track that work.

Comment 8 by aga...@chromium.org, Apr 25 2017

Blockedon: gerrit:5360
Now that https://bugs.chromium.org/p/gerrit/issues/detail?id=5360 is fixed, this is unblocked.
This should also mostly take care of the confusing "Submit including parents" buttons (see issue gerrit:5322 and issue gerrit:5835 )
Labels: -Milestone-Afterglow Milestone-Launch
Status: Started (was: Assigned)
cl/155153151 moves the submit button into the overflow menu.
Status: Fixed (was: Started)
The above change has been landed but not yet deployed. Marking fixed, can verify after deployment.

Sign in to add a comment