Unable to roll v8 in PDFium |
|||||
Issue descriptionWhat steps will reproduce the problem? (1) Try to roll v8 to fc50a90de4f564c16968bc18610e73b2dd15325f in PDFium: https://pdfium-review.googlesource.com/c/2557/ (2) Compiler complains about missing '../../test/cctest/test-experimental-extra.js' and '../../test/cctest/test-extra.js'. They are in pdfium/v8/test/cctest but it is looking for them in pdfium/test/cctest. So this seems to be a problem in the v8 gn file. (3) If I move them to the directory and try to compile PDFium, I get: FAILED: gen/v8/src/inspector/protocol/Forward.h gen/v8/src/inspector/protocol/Protocol.cpp gen/v8/src/inspector/protocol/Protocol.h gen/v8/src/inspector/protocol/Console.cpp gen/v8/src/inspector/protocol/Console.h gen/v8/src/inspector/protocol/Debugger.cpp gen/v8/src/inspector/protocol/Debugger.h gen/v8/src/inspector/protocol/HeapProfiler.cpp gen/v8/src/inspector/protocol/HeapProfiler.h gen/v8/src/inspector/protocol/Profiler.cpp gen/v8/src/inspector/protocol/Profiler.h gen/v8/src/inspector/protocol/Runtime.cpp gen/v8/src/inspector/protocol/Runtime.h gen/v8/src/inspector/protocol/Schema.cpp gen/v8/src/inspector/protocol/Schema.h gen/v8/include/inspector/Debugger.h gen/v8/include/inspector/Runtime.h gen/v8/include/inspector/Schema.h python ../../v8/third_party/inspector_protocol/CodeGenerator.py --jinja_dir ../../third_party/ --output_base gen/v8/src/inspector --config ../../v8/src/inspector/inspector_protocol_config.json Traceback (most recent call last): File "../../v8/third_party/inspector_protocol/CodeGenerator.py", line 592, in <module> main() File "../../v8/third_party/inspector_protocol/CodeGenerator.py", line 489, in main jinja_env = initialize_jinja_env(jinja_dir, config.protocol.output, config) File "../../v8/third_party/inspector_protocol/CodeGenerator.py", line 168, in initialize_jinja_env import jinja2 ImportError: No module named jinja2
,
Feb 8 2017
I thought Franziska is already working on this? Tentatively assigning.
,
Feb 8 2017
Ah wait a second. This is something else. The inspector is missing a dependency.
,
Feb 8 2017
I'm very unfamiliar with pdfium. But from the sound of this it seems like pdfium includes its own copy of V8, which infrequently rolls? If that's the case, can we simply configure this V8 to build without inspector support? This can be done by setting the GN flag v8_enable_inspector to false.
,
Feb 8 2017
We have v8_enable_inspector_override = false [1], it doesn't work because you recently changed the gni to force it to true [2]. As for the other test/cctest issue, you start with "//" in [2], so it searches for pdfium/test/cctest instead of pdfium/v8/test/cctest. And again, you took out the if defines for these in CL [3]. Let me know what I can do to override them now. [1] https://cs.chromium.org/chromium/src/third_party/pdfium/build_overrides/v8.gni [2] https://cs.chromium.org/chromium/src/v8/gni/v8.gni?q=gni/v8.gni+v8_enable_inspector+package:%5Echromium$&dr=C&l=41 [3] https://cs.chromium.org/chromium/src/third_party/pdfium/build_overrides/v8.gni?ssfr=1&type=cs&q=v8_enable_inspector_override&l=21
,
Feb 8 2017
,
Feb 9 2017
I found an attempt to fix this two weeks ago but it never landed: https://pdfium-review.googlesource.com/c/2410
,
Feb 9 2017
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67f3f47d2661a6354199df01384607474bdd9fb1 commit 67f3f47d2661a6354199df01384607474bdd9fb1 Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org> Date: Thu Feb 09 22:40:00 2017 Roll src/third_party/pdfium/ 687a79c5c..e818bcba7 (1 commit). https://pdfium.googlesource.com/pdfium.git/+log/687a79c5ce07..e818bcba7e03 $ git log 687a79c5c..e818bcba7 --date=short --no-merges --format='%ad %ae %s' 2017-02-09 npm Roll build, buildtools, and V8 Created with: roll-dep src/third_party/pdfium BUG= 690088 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Review-Url: https://codereview.chromium.org/2685883006 Cr-Commit-Position: refs/heads/master@{#449441} [modify] https://crrev.com/67f3f47d2661a6354199df01384607474bdd9fb1/DEPS |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jochen@chromium.org
, Feb 8 2017