New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690087 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Use other robhogan account instead.
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

LayoutTable::distributeExtraLogicalHeight() should allocate all spare pixels

Project Member Reported by robhogan@chromium.org, Feb 8 2017

Issue description

Currently it can end up with 1 or 2 pixels to spare.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d22a0616e628fe5e88618b288a98844b6891671c

commit d22a0616e628fe5e88618b288a98844b6891671c
Author: Robert Hogan <robhogan@gmail.com>
Date: Wed Nov 01 09:48:38 2017

Distribute all extra height to rows

Bug: 690087
Change-Id: I9628c03accaf66fffae40d96bb1de2174e5fd3e2
Reviewed-on: https://chromium-review.googlesource.com/732110
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513102}
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/fast/css-intrinsic-dimensions/height-css-tables-expected.html
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/paint/invalidation/table-two-pass-layout-overpaint-expected.txt
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug110566-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug11944-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug120364-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla/bugs/bug126742-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/linux/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug110566-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug11944-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug120364-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla/bugs/bug126742-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug110566-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug11944-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug120364-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/win/tables/mozilla/bugs/bug126742-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/LayoutTests/platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/d22a0616e628fe5e88618b288a98844b6891671c/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Sign in to add a comment