Ditto for telemtry_unittests https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.11/builds/6961/steps/telemetry_unittests/logs/json.output

+Kbr since telemetry_gpu_unittests is also failing.

+Dirk: do you know what may be going on here? I am suspecting some kind of infra failure as these bots not swarmed? 

https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.11/builds/6961

I'm not sure what's going on, but my guess is that there's something broken in the way the recipe is parsing the json test results.

I think you probably need to revert the typ change again until we figure out what's going on and fix it.

Dirk: I haven't landed the typ change yet.

Oh, I think this is probably because the bot is not swarmed, hence it's using IsolatedScriptTest recipe, which does not support the json test results format.

Do you mean the LocalIsolatedScriptTest step rather than the SwarmingIsolatedScriptTest step?

Could we refactor these so that the locally-run tests have the same capabilities as the new ones?

That bot looks pretty broken; it was failing generate_build_files for days, and now is stuck in a 8 hour run for its most recent build: https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Mac%2010.11/ . For the record, a bunch of the GPU bots have already been upgraded to 10.12 successfully, so I'm not sure this particular bug/bot should block the overall SDK upgrade.

Stephen: can you take a look at this?

I am suspecting that Mac10.12 is using LocalIsolatedScriptTest instead of SwarmingIsolatedScriptTest & we don't have the logic to handle the json test results properly in LocalIsolatedScriptTest.

I'll look at this.

Found a try-catch Exception, so going to try to remove that as well.

I also think this kind of stuff will go away when jbudorick's change lands. We can just make the triggering script specify the wrapper script, and have the telemetry_perf_unittests use a wrapper script which knows how to upload to swarming.

At least, I think so. Am I understanding his change correctly?

Triggering will support a postprocessing script. isolated_script collection already does. All of that's only for swarming, though -- I haven't made (and am not currently planning to make) any changes to LocalIsolatedScriptTest.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d53dc42bb3b5bf19c99606b51adf4ea1e4952642

commit d53dc42bb3b5bf19c99606b51adf4ea1e4952642
Author: Stephen Martinis <martiniss@google.com>
Date: Fri Feb 17 06:05:35 2017

chromium_tests: Print exception caught in LocalIsolatedScriptTest

I want to delete the try catch, but don't know what it's 
affecting in production.

BUG= 690085 

Change-Id: I403cdd23410fbc45f65f8c0d56a15de25fe643a6
Reviewed-on: https://chromium-review.googlesource.com/444154
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[modify] https://crrev.com/d53dc42bb3b5bf19c99606b51adf4ea1e4952642/scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 695334 has been merged into this issue.

Stephen is currently swarmed, so I am taking this bug.

 Issue 695467  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341

commit 2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341
Author: Nghia Nguyen <nednguyen@google.com>
Date: Thu Feb 23 23:06:33 2017

Add support to json results format for IsolatedScriptTest

BUG= 690085 

Change-Id: If1dd18ce61d4a7fe6de50b8b06fc16953ebb6980
Reviewed-on: https://chromium-review.googlesource.com/446737
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

[add] https://crrev.com/2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_passed_json_results.json
[add] https://crrev.com/2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341/scripts/slave/recipes/chromium.expected/dynamic_local_isolated_script_test_with_failed_json_results.json
[modify] https://crrev.com/2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341/scripts/slave/recipes/chromium.py
[modify] https://crrev.com/2b3cb8d7a2eb5ab6a04418b365ece1d9cd481341/scripts/slave/recipe_modules/chromium_tests/steps.py

This is fixed: https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28NVIDIA%20Quadro%20M2000%29/builds/219

Thank you Ned for picking this up and fixing it urgently!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/97ed8b703b49d79e0c62bc37152596ab088abdf9

commit 97ed8b703b49d79e0c62bc37152596ab088abdf9
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Mon Mar 06 12:09:39 2017

Recipes: Refactor global methods in steps.py into a parent class

BUG= 690085 

Change-Id: I42c5f7db942fd9402a44cc09233d88c57fc206c3
Reviewed-on: https://chromium-review.googlesource.com/445788
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

[modify] https://crrev.com/97ed8b703b49d79e0c62bc37152596ab088abdf9/scripts/slave/recipe_modules/chromium_tests/steps.py